cornelius / libkode Goto Github PK

There is a schematest.cpp in the schema folder which is at the moment not built at all. It would be useful to move it to a separate tests folder or remove it in the case if we add CI which runs similar test with the dependant projects (I think about running CI on libkode with kode/KDSOAP tests).

libkode supports setting initializers for (class) member variables.

However these initializers are always generated to the class constructors initializer section.
C++11 allows the non const variables to be initialized in the member declaration, and it would be useful to support it in the libkode. (I am generating some code where some nested classes exists only as a declaration.)

@dfaure-kdab I would love to hear your opinions about this!

If the C++11 will be a requirement for KDSoap in the near future I would vote for moving the initializers to the declarations and generate only C++11 compliant code.

If not it might be useful to add a member to the Printer which could be used to set the C++ standard of the generated code.
At the moment no other C++11 feature came into my mind which would be useful, but later we can implement other C++11 only features this way. However it adds some maintenance burden what we should really avoid.

common/fileprovider.cpp includes settings.h and uses the Settings class from kdwsdl2cpp

When compiling with Qt 5.14 the following deprecation warnings are shown:

https://github.com/cornelius/libkode/blob/master/libkode/printer.cpp#L741

Q_DECL_DEPRECATED_X("Use QSet<T>(list.begin(), list.end()) instead.")
    QSet<T> toSet() const;

https://github.com/cornelius/libkode/blob/master/libkode/printer.cpp#L743

Q_DECL_DEPRECATED_X("Use values() instead.")
    QList<T> toList() const { return values(); }

QXmlInputSource is marked deprecated in Qt 5.15, the parser codes needs to be ported to QXmlStreamReader.

We should add an option to being able to generate headers with #pragma once include guard

It is just a note for myself to not forgot to implement this at some point ;)

For KDSoap we still need to support the qmake buildsystem.

I see some problems already:

• common/common.pro, libkode/libkode.pro, schema/schema.pro refer to kdwsdl2cpp INCUDEPATHs
• common/common.pro, libkode/libkode.pro, schema/schema.pro include $${TOP_SOURCE_DIR}/variables.pri which is only found in kdsoap as the TOP_SOURCE_DIR
• common/common.pro, libkode/libkode.pro, schema/schema.pro need to add $${TOP_SOURCE_DIR}/kdwsdl2cpp/libkode to their INCLUDEPATHs

Not only that, there should be a top-level libkode.pro for building and installing as a stand-alone project

It would be useful to add a Travis CI to build and run the kdwsdl2cpp tests from KODE each commit (and kode once I manage to fix the tests).

@cornelius , @dfaure-kdab do you have any objections or hints around this idea?

There should be a toplevel CMakeLists.txt for building and installing the project

please add license information to the github page, probably with a top-level LICENSE.txt
also how the resulting generated code is licensed.

would be nice to use SPDX headers (https://reuse.software)