coreymbe / nodripa Goto Github PK

On *nix, /tmp is (usually) an in-memory file system intended for temporary files and files that do not need to survive a reboot. It should be used by scripts that need temp files (via mktemp for example), but not for the scripts themselves. There is also a security issue of users editing the scripts to contain arbitrary code that would then be run as root by systemd. I think the "sticky bit" is standard now, but this should still be avoided.

Depending on the use case, this should either use templates to set up the .service file to run the scripts from a different location, or use a Forge module that has types and providers for systemd resources.

The way this module works is essentially by allowing arbitrary, privileged code execution on the primary by agents. This is a huge security flaw, and IMO this module needs to be pulled from the Forge until reworked.

In PE and FOSS, the primary will only talk to agents that present a cert bundle signed by the Puppet CA, and the endpoints they are allowed to talk to are controlled by the service's auth.conf. This module circumvents both the CA and auth.conf and allows agents to run arbitrary code, which is a critical design flaw that needs to be addressed.

Also, the approach of installing Bolt on agents should not be used. When agents talk to the primary, it should be through Puppet's apis.