cordery / django-countries-plus Goto Github PK

After an error I had to delete my database and recreate it from scratch.
I have now an empty database.
If I run python manage.py makemigrations I get a django.db.utils.Programming Error :
table <database_name>.countries_plus_country does not exist

same problem if I run python manage.py migrate.

How can I create the countries_plus_country in my database after installing pycountry and django_countries_plus

Am trying to access the Nationalities from this library, forexample :

Country : Uganda, Nationality : Ugandan.
Country : America, Nationality: American.

etc.

How can this be achieved

In general it is better to use gettext_lazy:
https://github.com/cordery/django-countries-plus/blob/1eb0a0b61c83669224c33952b3fb4096c83cb587/countries_plus/models.py#L6C38-L6C45

Hey ! I just found this module and it's really useful !

I am trying to enable auto-complete on a Country foreignkey field in the CompanyAdmin class of my Company model.

autocomplete_fields = ['country']

However I get the following error:

CountryAdmin must define "search_fields", because it\'s referenced by CompanyAdmin.autocomplete_fields

I wonder if there is a workaround to have auto-complete enabled on a ForeignKeyField for easier selection of country.
Otherwise, is it planned to eventually have a "search_fields" attribute in the CountryAdmin class ?

Thanks in advance,

I have tested this issue with various python versions and installations (dokku, bare metal, dev and production), and can confirm that python manage.py update_countries_plus fails with following traceback:

python manage.py update_countries_plus
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/django/core/management/init.py", line 381, in execute_from_command_line
utility.execute()
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/django/core/management/init.py", line 375, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/django/core/management/base.py", line 323, in run_from_argv
self.execute(*args, **cmd_options)
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/django/core/management/base.py", line 364, in execute
output = self.handle(*args, **options)
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/countries_plus/management/commands/update_countries_plus.py", line 10, in handle
num_updated, num_created = update_geonames_data()
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/countries_plus/utils.py", line 218, in update_geonames_data
return parse_geonames_data(r.iter_lines())
File "/home/indigo/.pyenv/versions/3.6.5/lib/python3.6/site-packages/countries_plus/utils.py", line 235, in parse_geonames_data
if line[0] == "#":
IndexError: string index out of range

I suspect a change to geonames.org dataset causes this to fail.

Since data migrations are problematic in tests, and it may be faster to not rely on them (e.g. with pytest-django's --reuse-db), it would be helpful to have factories for this.

I am using factory-boy myself. Do you think it makes sense to provide factories through django-countries-plus itself?

(the same applies to django-languages-plus)

For example:

class CountryFactory(factory.django.DjangoModelFactory):
    """Factory for a Country"""
    class Meta:
        model = 'countries_plus.models.Country'
        django_get_or_create = ('name', 'iso')

    name = factory.Sequence(lambda n: "Country %d" % n)
    iso = factory.Sequence(lambda n: str(n))
    iso3 = factory.Sequence(lambda n: str(n))
    iso_numeric = factory.Sequence(lambda n: n)

We are developing an application that requires the United Nations listed as a country. Is it possible to add "United Nations (country)" with "UN" as its alpha-2 code to the list of countries? This country and code is reserved directly by ISO 3166/MA for the United Nations according to https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

I am seeing the following error when running the update_countries_plus command:

Traceback (most recent call last):
  File "…/pyenv/project/lib/python3.4/site-packages/django/db/backends/utils.py", line 67, in execute
    return self.cursor.execute(sql, params)
psycopg2.DataError: value too long for type character varying(5)

sql:
UPDATE "countries_plus_country" SET "iso3" = %s, "iso_numeric" = %s, "fips" = %s, "name" = %s, "capital" = %s, "area" = %s, "population" = %s, "continent" = %s, "tld" = %s, "currency_code" = %s, "currency_symbol" = %s, "currency_name" = %s, "phone" = %s, "postal_code_format" = NULL, "postal_code_regex" = NULL, "languages" = %s, "geoname id" = %s, "neighbours" = %s, "equivalent_fips_code" = NULL WHERE "countries_plus_country"."iso" = %s

params:
('ATG', 28, 'AC', 'Antigua and Barbuda', "St. John's", '443.0', 86754, 'NA', '.ag', 'XCD', '$', 'Dollar', '+1-268', 'en-AG', 3576396, '', 'AG')

The "varying(5)" field seems to be phone, and the value here is '+1-268'.

Hi back mates !
Thanks for the (very) quick fix to my latest issue, I am unfortunately coming to you with a new one ...

I am trying to migrate my models from django-countries to django-countries-plus.
I have a Company model with a "country" CountryField from django-countries. I am now adding a Country foreignkey "new_country".

from countries_plus.models import Country
from django_countries.fields import CountryField  # pragma: no cover

class Company(models.Model):  # pragma: no cover
   ....
    country = CountryField(blank=True)
    new_country = models.ForeignKey(Country, blank=True, null=True, on_delete=models.SET_NULL) # added during new migration

The migration file appears to show the right instructions:

    dependencies = [
        ('countries_plus', '0006_alter_country_options'),
        ('companies', '0014_individualactor_keyword_company_is_relevant_and_more'),
    ]

    operations = [
        migrations.AddField(
            model_name='company',
            name='new_country',
            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL,
                                    to='countries_plus.country'),
        ),
    ]

But the migration cannot go through, with the following logs:

  File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
    db.query(q)
  File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/MySQLdb/connections.py", line 259, in query
    _mysql.connection.query(self, query)
django.db.utils.OperationalError: (3780, "Referencing column 'new_country_id' and referenced column 'iso' in foreign key constraint 'companies_company_new_country_id_1a75fd29_fk_countries' are incompatible.")

I have run django-countries-plus successfully in the past and processed 0006_alter_country_options on a past migration. Countries have been installed with manage.py update_countries_plus.

I am running django 4.0.3, django-countries 7.3.2, django-countries-plus 2.1.0.
Currently the mysql DB is running utf8mb4_0900_ai_ci

Tried running python manage.py update_countries_plus today in a new project and ran into the following error:

countries_plus.utils.GeonamesParseError: I couldn't parse the Geonames file (http://download.geonames.org/export/dump/countryInfo.txt). The format may have changed. An updated version of this software may be required, please check for updates and/or raise an issue on github. Specific error: Unexpected field length: {'area': [u'Ensure that there are no more than 1 decimal place.']}

This error also exists in other projects where update_countries_plus previously worked without issue.

All of the projects (the new one + the old ones) are using v1.0.1 from pip.

There are mistakes in your fixtures. The codes of several countries are incorrect. For example, for Trinidad, the phone code should be 1-868. In your fixtures, it is -686!