cordazar / codecademy-jammming Goto Github PK

Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/Components/App/App.js#L47

Since we're adding the playlist, we want to clear out the current songs in playList tracks.

Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/util/Spotify.js#L31

We want to return this response, but it looks like you're not really doing anything with it here.

To increase the dependability of the application and to open up for further development in TDD style.

Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/Components/App/App.js#L30-L34

I think this could be done better by saving this.state.playlistTracks; as a variable, pushing to that variable, then calling setState and passing the updated version of the variable.

Nice work on this jammming project! I like how you chose to condense your codes (used simpler if else statements, tried to bind all the methods in app.js in a single line, etc. I also found your naming conventions to be pretty revealing of values.

In terms of improvements, I recommended some changes for savingPlaylists, a quick reminder to use setState when updating the values of variables, and how to efficiently update with setState. Wish you the best of luck as you continue, and keep up the good work! :)

Sorely lacking at the moment.

Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/util/Spotify.js#L16

I believe you want to cast this to a number.

Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/Components/SearchBar/SearchBar.js#L17

I noticed you're directly setting the variable, but you want to be sure to use this.setState! :)