Code Monkey home page Code Monkey logo

eslint-config-amex's Introduction

eslint-config-amex

This is American Express' eslint config.

Usage

  1. Install:
npm install --save-dev eslint-config-amex
  1. Extend your .eslintrc:
{
    "extends": "amex"
}
  1. (Optionally) Create an .eslintrc file at your test directory root and configure as follows:
{
    "extends": "amex/test"
}

This gives you the jest global and some jest specific rules.

Alter Rules

We extend airbnb's eslint config. Each of their rules has reasoning behind them.

If you feel that one or more of these rules affects code beauty < readability < maintainability then feel free to open a pull request:

  1. Fork this repo (after filling out agreement as described below)
  2. Create one branch per one rule change (bonus points for naming the branch after the rule)
  3. Edit the rule in that branch, with a comment above the rule with a short, one liner why it's useful/needed
  4. Commit the rule change, with your objective, clear reasons why the change is needed in the commit message
  5. Open a PR to merge your branch into our repo. Keep your reason(s) in the description, and (please) expound upon them

A discussion will then ensue. Airbnb has reasons for why they chose the rule settings they did; be sure to address why they're not helpful.

Unhelpful supporting arguments like "___ is dumb" will incline us to decline your PR. Styles can turn into Holy Wars too easily, please stay objective and meet the requirements for more than one developer for the goals stated above.

Contributing

We welcome Your interest in the American Express Open Source Community on Github. Any Contributor to any Open Source Project managed by the American Express Open Source Community must accept and sign an Agreement indicating agreement to the terms below. Except for the rights granted in this Agreement to American Express and to recipients of software distributed by American Express, You reserve all right, title, and interest, if any, in and to Your Contributions. Please fill out the Agreement.

License

Any contributions made under this project will be governed by the Apache License 2.0.

Code of Conduct

This project adheres to the American Express Community Guidelines. By participating, you are expected to honor these guidelines.

eslint-config-amex's People

Contributors

anescobar1991 avatar pixnbits avatar jackjocross avatar 10xlacroixdrinker avatar

Watchers

James Cloos avatar Paul Herve avatar  avatar Nick Jarzembowski avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.