Code Monkey home page Code Monkey logo

spellcalc's People

Contributors

coolmodi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

spellcalc's Issues

Paladin HoW

HoW isn't showing any crit in the tooltip. Also the hit chance is off. It shows 26% hit (23% + 3%) against +2 level targets.

LUA error when accessing vehicle last couple weeks

Hi there,

When entering a vehicle the following error is seen when having SpellCalc loaded:

27x ...ceSpellCalc/UI/actionbar/ActionBarValues.lua:249: attempt to index field '?' (a nil value)
[string "@SpellCalc/UI/actionbar/ActionBarValues.lua"]:249: in function <...ceSpellCalc/UI/actionbar/ActionBarValues.lua:242>
[string "@SpellCalc/UI/actionbar/ActionBarValues.lua"]:277: in function <...ceSpellCalc/UI/actionbar/ActionBarValues.lua:272>
[string "=[C]"]: ?
[string "=[C]"]: in function `SetAttribute'
[string "@FrameXML/SecureStateDriver.lua"]:114: in function <FrameXML/SecureStateDriver.lua:95>
[string "@FrameXML/SecureStateDriver.lua"]:127: in function <FrameXML/SecureStateDriver.lua:119>

Locals:
barData =

{
updateOffset = 0
origOffset = 0
}
updateOffset = 180
(for index) = 1
(for limit) = 12
(for step) = 1
i = 1
(*temporary) = nil
(*temporary) = 1
(*temporary) = "attempt to index field '?' (a nil value)"
slotMap =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
10 =
{
}
11 =
{
}
12 =
{
}
13 =
{
}
14 =
{
}
15 =
{
}
16 =
{
}
17 =
{
}
18 =
{
}
19 =
{
}
20 =
{
}
21 =
{
}
22 =
{
}
23 =
{
}
24 =
{
}
25 =
{
}
26 =
{
}
27 =
{
}
28 =
{
}
29 =
{
}
30 =
{
}
31 =
{
}
32 =
{
}
33 =
{
}
34 =
{
}
35 =
{
}
36 =
{
}
37 =
{
}
38 =
{
}
39 =
{
}
40 =
{
}
41 =
{
}
42 =
{
}
43 =
{
}
44 =
{
}
45 =
{
}
46 =
{
}
47 =
{
}
48 =
{
}
49 =
{
}
50 =
{
}
51 =
{
}
52 =
{
}
53 =
{
}
54 =
{
}
55 =
{
}
56 =
{
}
57 =
{
}
58 =
{
}
59 =
{
}
60 =
{
}
61 =
{
}
62 =
{
}
63 =
{
}
64 =
{
}
65 =
{
}
66 =
{
}
67 =
{
}
68 =
{
}
69 =
{
}
70 =
{
}
71 =
{
}
72 =
{
}
73 =
{
}
74 =
{
}
75 =
{
}
76 =
{
}
77 =
{
}
78 =
{
}
79 =
{
}
80 =
{
}
81 =
{
}
82 =
{
}
83 =
{
}
84 =
{
}
85 =
{
}
86 =
{
}
87 =
{
}
88 =
{
}
89 =
{
}
90 =
{
}
91 =
{
}
92 =
{
}
93 =
{
}
94 =
{
}
95 =
{
}
96 =
{
}
97 =
{
}
98 =
{
}
99 =
{
}
100 =
{
}
101 =
{
}
102 =
{
}
103 =
{
}
104 =
{
}
105 =
{
}
106 =
{
}
107 =
{
}
108 =
{
}
109 =
{
}
110 =
{
}
111 =
{
}
112 =
{
}
113 =
{
}
114 =
{
}
115 =
{
}
116 =
{
}
117 =
{
}
118 =
{
}
119 =
{
}
120 =
{
}
121 =
{
}
122 =
{
}
123 =
{
}
124 =
{
}
125 =
{
}
126 =
{
}
127 =
{
}
128 =
{
}
129 =
{
}
130 =
{
}
131 =
{
}
132 =
{
}
133 =
{
}
134 =
{
}
135 =
{
}
136 =
{
}
137 =
{
}
138 =
{
}
139 =
{
}
140 =
{
}
141 =
{
}
142 =
{
}
143 =
{
}
144 =
{
}
145 =
{
}
146 =
{
}
147 =
{
}
148 =
{
}
149 =
{
}
150 =
{
}
151 =
{
}
152 =
{
}
153 =
{
}
154 =
{
}
155 =
{
}
156 =
{
}
}
SlotUpdate = defined @SpellCalc/UI/actionbar/ActionBarValues.lua:210

bad argument

Message: Interface\AddOns\SpellCalc\system/buffs.lua:418: bad argument #1 to 'ipairs' (table expected, got nil)
Time: Thu Apr 16 11:48:45 2020
Count: 1
Stack: Interface\AddOns\SpellCalc\system/buffs.lua:418: bad argument #1 to 'ipairs' (table expected, got nil)
[C]: ?
[C]: in function ipairs' Interface\AddOns\SpellCalc\system/buffs.lua:418: in function UpdateTalents'
Interface\AddOns\SpellCalc\system/stats.lua:284: in function FullUpdate' Interface\AddOns\SpellCalc\events.lua:20: in function ?'
Interface\AddOns\SpellCalc\events.lua:109: in function <Interface\AddOns\SpellCalc\events.lua:108>

Locals:

Actionbar Paging not working

If you page through an actionbar, the 2nd actionbar doesn't have the amounts on the overlay.

Steps to reproduce:

  • Have spells on the first page of the actionbar
  • Switch to the 2nd page
  • I expected the 2nd page spells to have the spell amounts on the overlay. Instead I see the first page spells amounts still persisting

Interface\AddOns\SpellCalc\core/MeleeCalc.lua:244

Hi Coolmodi, I found one more error as druid, could you to check it pls?

LOG:

Message: Interface\AddOns\SpellCalc\core/MeleeCalc.lua:244: attempt to index field '?' (a nil value)
Time: Sun Jul 5 16:31:44 2020
Count: 2405
Stack: Interface\AddOns\SpellCalc\core/MeleeCalc.lua:244: attempt to index field '?' (a nil value)
Interface\AddOns\SpellCalc\core/MeleeCalc.lua:244: in function GetMDPGB' Interface\AddOns\SpellCalc\core/core.lua:306: in function <Interface\AddOns\SpellCalc\core/core.lua:151> Interface\AddOns\SpellCalc\core/core.lua:569: in function GetCalcedSpell'
Interface\AddOns\SpellCalc\UI/ActionbarValues.lua:116: in function <Interface\AddOns\SpellCalc\UI/ActionbarValues.lua:89>

Locals: self =

{
levelDiff = 0
isWhitehit = true
isOffhand = false
targetLevel = 21
calcedSpell =
{
}
ldef = 105
latk = 105
isPvP = false
ratk = 4
}
skillDiff = 101
hit = 74.800000
hitBonus = 0
weaponType = nil
(*temporary) = nil
(*temporary) = "mh"
(*temporary) = nil
(*temporary) = nil
(*temporary) =
{
WEAPON_TYPE_TO_MASK =
{
}
CostHandler =
{
}
UpdateSpellPower = defined @interface\AddOns\SpellCalc\system/stats.lua:167
target =
{
}
PrintDebug = defined @interface\AddOns\SpellCalc\helper.lua:85
effectHandler =
{
}
BUFF_CONDITIONS =
{
}
targetBuffs =
{
}
UpdateAttackDmg = defined @interface\AddOns\SpellCalc\system/stats.lua:266
itemSetData =
{
}
spellRankInfo =
{
}
JUDGEMENT_ID = 20271
GetShapeshiftName = defined @interface\AddOns\SpellCalc\helper.lua:40
FISHING_POLES =
{
}
UpdateAttackSpeeds = defined @interface\AddOns\SpellCalc\system/stats.lua:238
IsOffHandWeaponEquipped = defined @interface\AddOns\SpellCalc\system/items.lua:285
PrintSuccess = defined @interface\AddOns\SpellCalc\helper.lua:52
WEAPON_TYPES_MASK =
{
}
TriggerUpdate = defined @interface\AddOns\SpellCalc\core/core.lua:535
itemData =
{
}
GetCalcedSpell = defined @interface\AddOns\SpellCalc\core/core.lua:561
SPELL_EFFECT_FLAGS =
{
}
FullUpdate = defined @interface\AddOns\SpellCalc\system/stats.lua:310
SCHOOL_MASK =
{
}
RemoveTableEntry = defined @interface\AddOns\SpellCalc\helper.lua:9
stats =
{
}
UpdateTalents = defined @interface\AddOns\SpellCalc\system/buffs.lua:437
AddLocalization = defined @interface\AddOns\SpellCalc\i18n/loc.lua:13
talentData =
{
}
IsMainHandWeaponEquipped = defined @interface\AddOns\SpellCalc\system/items.lua:280
RemoveBuff = defined @interface\AddOns\SpellCalc\system/buffs.lua:298
SPELL_AURA_TYPES =
{
}
PrintWarn = defined @interface\AddOns\SpellCalc\helper.lua:64
SPELL_EFFECT_TYPES =
{
}
GetSettingsBuilder = defined @interface\AddOns\SpellCalc\libs/SettingsCreator.lua:553
IsDualWieldEquipped = defined @interface\AddOns\SpellCalc\system/items.lua:297
UpdateItems = defined @interface\AddOns\SpellCalc\system/items.lua:232
UpdateTarget = defined @interface\AddOns\SpellCalc\system/target.lua:20
GetCurrentSpellData = defined @interface\AddOns\SpellCalc\core/core.lua:578
MeleeCalc =
{
}
EFFECT_TYPE =
{
}
debuffData =
{
}
buffData =
{
}
GetEffectiveManaPool = defined @interface\AddOns\SpellCalc\core/core.lua:122
NewCalcedSpell = defined @interface\AddOns\SpellCalc\core/CalcedSpell.lua:194
GetLocalization = defined @interface\AddOns\SpellCalc\i18n/loc.lua:29
spellBaseInfo =
{
}
UpdateStats = defined @interface\AddOns\SpellCalc\system/stats.lua:217
MagicCalc =
{
}
HEALING_CLASSES =
{
}
GetCurrentState = defined @interface\AddOns\SpellCalc\core/core.lua:583
GetWeaponType = defined @interface\AddOns\SpellCalc\system/items.lua:303
GetHandledSpellID = <fu

nil value error from core.lua on flatMod assignment

image

So not sure what info you need to help debug this, feel free to ask me for anything else. I'm getting this constantly repeating (many times a second) error from line 249 in core.lua about trying to index this flatMod field when it is nil. I've looked at the line in question but I don't really know lua so I'm not sure what the issue is. I installed the latest from master branch just now.

Feature: ignore regeneration option for DPM/HPM

Great addon!

Motivation

Personally, I find spell efficiency more useful when computed without passive regeneration.

The way one assesses total efficiency depends on both DPM and DPS. Blending time into DPM makes that analysis harder, not easier. Regen-aware DPM (and DOOM, but that has other uses) artificially favors low costs and slow casting when these are strictly inferior to a higher cost (with the same effect-per-cost) and fast casting.

Consider 3 spells and a regeneration of 10mp5:
(1) 100 damage for 20 mana in 3.0sec cast -> 5 DPM-raw, 7.14 DPM-regen
(2) 100 damage for 20 mana in 1.5sec cast -> 5 DPM-raw, 5.88 DPM-regen
(3) 200 damage for 40 mana in 3.0sec cast -> 5 DPM-raw, 5.88 DPM-regen

In raw terms, all do 5 DPM. A regen-aware DPM calculation insists that (1) is the most efficient. In truth, (1) is less efficient because you could use spell (2) or (3) half the of time, spend the other half making a sandwich while doing /dance and enjoying out-of-5SR regeneration, and do identical DPS to (1) while having more mana left over at the end.

In non-hypotheticals, I notice that the low cost of lifebloom results in a massive distortion of its HPM when including regeneration - it has a raw HPM around 25 but regeneration can inflate this to 55 in SpellCalc. It is definitely the most efficient druid heal, but by a factor of 2 rather than 5. One can witness the same effect with any downranked spell - it will have inferior DPS but regen-aware DPM can muddy the comparison by giving the illusion of efficiency.

Feature

Could we get a new DPM/HPM tooltip that excludes passive regeneration? By passive regeneration, I mean only spirit and mp5 based regeneration. I would still include mana returns from procs and crits, discounts from clearcasting, etc because those apply only when casting a spell.

Priest: Power Infusion calculated incorrectly

The power infusion multiplier seems to be calculated on the base healing rather than the final healing power, this gives a lower predicted heal value.

e.g
base healing = 702
zhc+bpb brings it up to 1300 total
healing amount should be : (heal spell value + (1300 x coeff)) * Power infusion * crit multiplier
Actual should be (2021 + (1300*.857)) * 1.2 * 1.5 = 5643
Current calculation gives a max value of ((2021*1.2) + (1300x.857)) * 1.5 = 5309

DK :C

3x ...ceSpellCalc\UI/actionbar/ActionBarValues.lua:348: attempt to index field 'events' (a nil value)
[string "@SpellCalc\UI/actionbar/ActionBarValues.lua"]:348: in main chunk

Locals:
_addon =

{
stats =
{
}
AddLocalization = defined @SpellCalc\i18n/loc.lua:12
levelDefaultArmor =
{
}
effectHandler =
{
}
aurasPlayer =
{
}
MeleeCalc =
{
}
npcResistances =
{
}
ActionBarValues =
{
}
enchantData =
{
}
NewCalcedSpell = defined @SpellCalc\core/CalcedSpell.lua:235
GetBaseMana = defined @SpellCalc\data/basemana.lua:585
SetupActionButtonText = defined @SpellCalc\UI/actionbar/buttonText.lua:142
GetHandledSpellID = defined @SpellCalc\core/core.lua:918
Target =
{
}
scripting =
{
}
SCTooltip =
{
}
TriggerUpdate = defined @SpellCalc\core/core.lua:906
setItemData =
{
}
GetCurrentState = defined @SpellCalc\core/core.lua:958
mechanicAuras =
{
}
aurasTarget =
{
}
GetCalcedSpell = defined @SpellCalc\core/core.lua:936
itemEffects =
{
}
GetCurrentSpellData = defined @SpellCalc\core/core.lua:953
MagicCalc =
{
}
CostHandler =
{
}
UpdateManaRegen = defined @SpellCalc\system/stats.lua:317
GetEffectiveManaPool = defined @SpellCalc\core/core.lua:182
GetLocalization = defined @SpellCalc\i18n/loc.lua:20
CONST =
{
}
UpdateAurasForUnit = defined @SpellCalc\system/unitAuras.lua:183
util =
{
}
itemSetData =
{
}
}
ADDON_EFFECT_FLAGS =
{
TRIGGERED_SPELL = 256
DMG_SHIELD = 4
STACKABLE_AURA = 512
CHANNEL = 16
MANA_RESTORE = 1024
DURATION = 1
AUTO_ATTACK = 64
ABSORB = 8
DUMMY_AURA = 128
TRIGGER_SPELL_AURA = 32
HEAL = 2
}
SEAL_OF_RIGHTEOUSNESS = "Seal of Righteousness"
SEAL_OF_COMMAND = "Seal of Command"
PRAYER_OF_MENDING = "Prayer of Mending"
EARTH_SHIELD = "Earth Shield"
SEAL_OF_VENGEANCE = "Seal of Vengeance"
SEAL_OF_CORRUPTION = "Seal of Corruption"
ActionBarValues =
{
Clear = defined @SpellCalc\UI/actionbar/ActionBarValues.lua:333
UpdateStyle = defined @SpellCalc\UI/actionbar/ActionBarValues.lua:340
}
spellsInBar =
{
}
needsUpdate =
{
}
slotMap =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
10 =
{
}
11 =
{
}
12 =
{
}
13 =
{
}
14 =
{
}
15 =
{
}
16 =
{
}
17 =
{
}
18 =
{
}
19 =
{
}
20 =
{
}
21 =
{
}
22 =
{
}
23 =
{
}
24 =
{
}
25 =
{
}
26 =
{
}
27 =
{
}
28 =
{
}
29 =
{
}
30 =
{
}
31 =
{
}
32 =
{
}
33 =
{
}
34 =
{
}
35 =
{
}
36 =
{
}
37 =
{
}
38 =
{
}
39 =
{
}
40 =
{
}
41 =
{
}
42 =
{
}
43 =
{
}
44 =
{
}
45 =
{
}
46 =
{
}
47 =
{
}
48 =
{
}
49 =
{
}
50 =
{
}
51 =
{
}
52 =
{
}
53 =
{
}
54 =
{
}
55 =
{
}
56 =
{
}
57 =
{
}
58 =
{
}
59 =
{
}
60 =
{
}
61 =
{
}
62 =
{
}
63 =
{
}
64 =
{
}
65 =
{
}
66 =
{
}
67 =
{
}
68 =
{
}
69 =
{
}
70 =
{
}
71 =
{
}
72 =
{
}
73 =
{
}
74 =
{
}
75 =
{
}
76 =
{
}
77 =
{
}
78 =
{
}
79 =
{
}
80 =
{
}
81 =
{
}
82 =
{
}
83 =
{
}
84 =
{
}
85 =
{
}
86 =
{
}
87 =

ElvUI ActionBar support is wrong as of ElvUI v1.38

As per the title; As of ElvUI v1.38 they seem to have changed/fixed their actionbar ordering so that they are now in accordance with blizzard actionbar ordering. This means that currently the actionbar spellcalc text shown is assigned to the wrong actionbar.

image

Fix is simple enough:
image

Glyph of Quick Decay issue

Haste isn't being factored into corruption correctly with Glyph of Quick Decay.

In the image below, you can see that corruption is anticipated to tick 6x, every 2.61s, for a duration of 13.58s. These numbers don't add up (6 * 2.61 = 15.66). Corruption duration is longer than the expected 13.58s, and 15.66s feels about right. Perhaps Eradication is accidentally being treated as a permanent effect? When it did proc, the prediction was even lower (and still incorrect).

FhgJvN2Keo

[Not an Issue, Close Me] I love SpellCalc

Hey Coolmodi,

I'm a developer and I know using this issue board to drop a note is frowned upon, and I apologize in advance, but no more DMs in Github :( . I wanted to drop a note with some recognition for spellcalc because this mod is amazing. I've been using it reliably since classic (pretbc). It absolutely has helped make me a smarter priest player. Thank you for taking the time to update it for WotLK once again.

Cheers!

No effect handler for effect

Receiving the following error when logging in - this example is from a mage:

[11:18:02] SpellCalc: No effect handler for effect #1:2 on spell (30451) Arcane Blast
[11:18:02] SpellCalc: Please report this to the addon author.
[11:18:02] SpellCalc: No effect handler for effect #1:2 on spell (30451) Arcane Blast
[11:18:02] SpellCalc: Please report this to the addon author.
[11:18:02] SpellCalc: No effect handler for effect #1:2 on spell (30451) Arcane Blast
[11:18:02] SpellCalc: Please report this to the addon author.
[11:18:02] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:02] SpellCalc: Please report this to the addon author.
[11:18:02] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:02] SpellCalc: Please report this to the addon author.
[11:18:03] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:03] SpellCalc: Please report this to the addon author.
[11:18:03] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:03] SpellCalc: Please report this to the addon author.
[11:18:03] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:03] SpellCalc: Please report this to the addon author.
[11:18:03] SpellCalc: No effect handler for effect #1:6 on spell (38699) Arcane Missiles
[11:18:03] SpellCalc: Please report this to the addon author.
[11:18:03] SpellCalc: No effect handler for effect #1:6 on spell (27085) Blizzard
[11:18:03] SpellCalc: Please report this to the addon author.
[11:18:04] SpellCalc: No effect handler for effect #1:2 on spell (27079) Fire Blast
[11:18:04] SpellCalc: Please report this to the addon author.
[11:18:05] SpellCalc: No effect handler for effect #1:2 on spell (116) Frostbolt

Missing actionbar values

A number of my action bar buttons don't seem to be getting a predicted "avg value" showing (see screenshots). Some of these are macros (but some other macros show fine) and some are HOTs/DOTs (but not all of them), so I'm a bit lost why this happens. Missing in the screenshot are: Damage/heal values for Shadow Word: Death, Shadow Word: Pain, Devouring Plague, Renew, Flash Heal, Holy Fire, and Desperate Heal.

Note also that the values show on actionbars don't seem to update if/when the spells show do. Action button 2-4 show the heal values of buttons in that position in my "friendly" action bar (hidden because I have a hostile target), rather than updating and showing the damage values for the active action bar's spells.

image

Master Shapeshifter lua error

Master Shapeshifter Rank 1 Rank 2 has started causing frequent errors. The errors did NOT start when the talent was first learned, or the first time a shapeshift was used/cancelled. They started happening suddenly later on, with no apparent cause.

SpellCalc\system/unitAuras.lua:103: Removed Master Shapeshifter-1 with scriptValue without having cached value!
[string "=[C]"]: in function `error'
[string "@SpellCalc\system/unitAuras.lua"]:103: in function <SpellCalc\system/unitAuras.lua:91>
[string "@SpellCalc\system/unitAuras.lua"]:218: in function `UpdateAurasForUnit'
[string "@SpellCalc\system/unitAuras.lua"]:258: in function `?'
[string "@SpellCalc\events.lua"]:25: in function <SpellCalc\events.lua:21>

Locals:
(*temporary) = "Removed Master Shapeshifter-1 with scriptValue without having cached value!"

Additional context:
The shapeshift form when the error was captured was Tree of Life.
This took place inside a dungeon.
The errors appeared to start when the shapeshift was removed.

Error with labels

The labels show for my the technical labels like

DMG_PER_MANA_SHORT

i tired to copy the enUS.lua and rename it to deDE.ua and change the parameter inside the file but it did not work how can i add a translation

Paladin problems

  • JoC should be a melee spell that can't be parried, dodged or blocked.
  • HoW should be a ranged attack that uses melee crit and hit (need confirmation, makes no sense going by DBC data).
  • HS need corect def type.

Edit: HoW seems to use ranged hit, it apparently can miss even with melee hit cap. It probably uses level based max skill to calculate hit chance as it's also not a weapon based attack. Most likely also uses ranged crit chance with the same rules.

Fails to load any button text

Message: ...terface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:51: attempt to index local 'buttonFrame' (a nil value)
Time: Mon Jun 7 00:24:11 2021
Count: 1
Stack: ...terface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:51: attempt to index local 'buttonFrame' (a nil value)
[string "@interface\AddOns\SpellCalc\UI/actionbar/buttonText.lua"]:51: in function <...terface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:50>
[string "@interface\AddOns\SpellCalc\UI/actionbar/buttonText.lua"]:82: in function <...terface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:74>
[string "@interface\AddOns\SpellCalc\UI/actionbar/buttonText.lua"]:179: in function SetupActionButtonText' [string "@Interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua"]:339: in function Setup'
[string "@interface\AddOns\SpellCalc\events.lua"]:31: in function `?'
[string "@interface\AddOns\SpellCalc\events.lua"]:146: in function <Interface\AddOns\SpellCalc\events.lua:145>

Locals: buttonFrame = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'buttonFrame' (a nil value)"
SetIsHeal = defined @interface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:39
UpdatePosition = defined @interface\AddOns\SpellCalc\UI/actionbar/buttonText.lua:29

Death Coil spell mouseover error

Hello,
I get this error spam when the mouse passes over deathcoil spell:

SpellCalc: No effect handler for effect #1:9 on spell (17926) Death Coil
SpellCalc: Please report this to the addon author.

Calculations incorrect for Warlock

Tested a Corruption(Rank 7) on a target dummy, it did 335 per tick, tooltip says it should do 291. No crits.
Level 60, 278 Spellpower, 0 secondaries.
edit: hit 70, rank 8 seems to be calculated correctly

Conflict with Bartender4

20x ...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:249: attempt to index field '?' (a nil value)
[string "@interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua"]:249: in function <...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:242>
[string "@interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua"]:277: in function <...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:272>
[string "=[C]"]: ?
[string "=[C]"]: in function SetAttribute' [string "@Interface\AddOns\Bartender4\StateBar.lua"]:240: in function UpdateStates'
[string "@interface\AddOns\Bartender4\StateBar.lua"]:377: in function UpdateSelfCast' [string "@Interface\AddOns\Bartender4\ActionBar.lua"]:137: in function UpdateSelfCast'
[string "@interface\AddOns\Bartender4\ActionBar.lua"]:128: in function UpdateButtonConfig' [string "@Interface\AddOns\Bartender4\ActionBar.lua"]:357: in function SetGrid'
[string "@interface\AddOns\Bartender4\ActionBar.lua"]:307: in function UpdateButtons' [string "@Interface\AddOns\Bartender4\ActionBar.lua"]:52: in function ApplyConfig'
[string "@interface\AddOns\Bartender4\ActionBars.lua"]:365: in function EnableBar' ... [string "@Interface\AddOns\AnnoyingPopupRemover\Libs\AceConfigDialog-3.0\AceConfigDialog-3.0-86.lua"]:45: in function <...ver\Libs\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:43> [string "@Interface\AddOns\AnnoyingPopupRemover\Libs\AceConfigDialog-3.0\AceConfigDialog-3.0-86.lua"]:831: in function <...ver\Libs\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:658> [string "=[C]"]: ? [string "@Interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:66: in function <...\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0.lua:64> [string "@Interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:300: in function Fire'
[string "@interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0-41\widgets\AceGUIWidget-DropDown.lua"]:432: in function <...er\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:423>
[string "=[C]"]: ?
[string "@interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:66: in function <...\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0.lua:64>
[string "@interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:300: in function `Fire'
[string "@interface\AddOns\AnnoyingPopupRemover\Libs\AceGUI-3.0-41\widgets\AceGUIWidget-DropDown-Items.lua"]:351: in function <...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>

Locals:
barData =

{
updateOffset = 0
origOffset = 0
}
updateOffset = -12
(for index) = 1
(for limit) = 12
(for step) = 1
i = 1
(*temporary) = nil
(*temporary) = 1
(*temporary) = "attempt to index field '?' (a nil value)"
slotMap =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
10 =
{
}
11 =
{
}
12 =
{
}
13 =
{
}
14 =
{
}
15 =
{
}
16 =
{
}
17 =
{
}
18 =
{
}
19 =
{
}
20 =
{
}
21 =
{
}
22 =
{
}
23 =
{
}
24 =
{
}
25 =
{
}
26 =
{
}
27 =
{
}
28 =
{
}
29 =
{
}
30 =
{
}
31 =
{
}
32 =
{
}
33 =
{
}
34 =
{
}
35 =
{
}
36 =
{
}
37 =
{
}
38 =
{
}
39 =
{
}
40 =
{
}
41 =
{
}
42 =
{
}
43 =
{
}
44 =
{
}
45 =
{
}
46 =
{
}
47 =
{
}
48 =
{
}
49 =
{
}
50 =
{
}
51 =
{
}
52 =
{
}
53 =
{
}
54 =
{
}
55 =
{
}
56 =
{
}
57 =
{
}
58 =
{
}
59 =
{
}
60 =
{
}
61 =
{
}
62 =
{
}
63 =
{
}
64 =
{
}
65 =
{
}
66 =
{
}
67 =
{
}
68 =
{
}
69 =
{
}
70 =
{
}
71 =
{
}
72 =
{
}
73 =
{
}
74 =
{
}
75 =
{
}
76 =
{
}
77 =
{
}
78 =
{
}
79 =
{
}
80 =
{
}
81 =
{
}
82 =
{
}
83 =
{
}
84 =
{
}
85 =
{
}
86 =
{
}
87 =
{
}
88 =
{
}
89 =
{
}
90 =
{
}
91 =
{
}
92 =
{
}
93 =
{
}
94 =
{
}
95 =
{
}
96 =
{
}
97 =
{
}
98 =
{
}
99 =
{
}
100 =
{
}
101 =
{
}
102 =
{
}
103 =
{
}
104 =
{
}
105 =
{
}
106 =
{
}
107 =
{
}
108 =
{
}
109 =
{
}
110 =
{
}
111 =
{
}
112 =
{
}
113 =
{
}
114 =
{
}
115 =
{
}
116 =
{
}
117 =
{
}
118 =
{
}
119 =
{
}
120 =
{
}
121 =
{
}
122 =
{
}
123 =
{
}
124 =
{
}
125 =
{
}
126 =
{
}
127 =
{
}
128 =
{
}
129 =
{
}
130 =
{
}
131 =
{
}
132 =
{
}
133 =
{
}
134 =
{
}
135 =
{
}
136 =
{
}
137 =
{
}
138 =
{
}
139 =
{
}
140 =
{
}
141 =
{
}
142 =
{
}
143 =
{
}
144 =
{
}
145 =
{
}
146 =
{
}
147 =
{
}
148 =
{
}
149 =
{
}
150 =
{
}
151 =
{
}
152 =
{
}
153 =
{
}
154 =
{
}
155 =
{
}
156 =
{
}
}
SlotUpdate = defined @interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:210

ElvUI integration

Your releases page mentions that ElvUI integration was added previously; would you be able to explain what the integration is capable of doing?

Nil value Lua error on buttonText

Started getting the following Lua error after upgrading to 0.8.1:

ActionBarValues.lua:152: attempt to index upvalue 'buttonText' (a nil value)

This seems to happen when I loot. Not sure if I happen to be hovering over any spells at the same time.

Moonkin issues

shows no spelldamage in moonkin.
using TukUI and automatically changing actionbars

Druid Travel Form error

10x SpellCalc\system/unitAuras.lua:103: Removed Master Shapeshifter-1 with scriptValue without having cached value!
[string "=[C]"]: in function error' [string "@SpellCalc\system/unitAuras.lua"]:103: in function <SpellCalc\system/unitAuras.lua:91> [string "@SpellCalc\system/unitAuras.lua"]:218: in function UpdateAurasForUnit'
[string "@SpellCalc\system/unitAuras.lua"]:258: in function `?'
[string "@SpellCalc\events.lua"]:25: in function <SpellCalc\events.lua:21>

Locals:
(*temporary) = "Removed Master Shapeshifter-1 with scriptValue without having cached value!"

[WotLK] Resto Druid - Heals Hit Slightly Higher than SpellCalc Value in Tree Form

In tree form with full resto talents that affect heal numbers, heals are consistently slightly higher than SpellCalc value. Out of tree form, heals match SpellCalc value. I do see the numbers update when shifting to treeform, but I think it might be missing a talent or modifier somewhere.

Examples of SpellCalc value and actual heal:

  • Rejuv says it should tick for 1225, it actually ticks for 1298
  • Lifebloom says it should tick for 232, it actually ticks for 246-247
  • Healing Touch says it should hit for 6168 average, five casts were: 6591, 6689, 6449, 6541, 6647

Paladin: Showing of value on action bar doesn't work

Hey Coolmodi, thank you for the nice addon. I got a trouble with showing of values on actions bar exceptionally for Paladin's spells (tested for different levels of pally, but the result always the same - numbers are not showing on action bar and I got a LUA errors). The counter in the error is never stopped. Could you check it? Thx in advance.
P.S. Tested with standard interface without any others addons + clear Cache & WTF.

Pally 1st lvl:
image

24lvl:
image

full log:
image
image
image
image
image
image
image

ActionBar value problem with macros

I have some rank-less macros on my action-bars ( /cast Mind Blast), which results in highest rank being cast, but SpellCalc shows calculations for Rank 1.

The calculation in the tooltip seems correct, so not sure if this is fixable? GetMacroSpell has two return values according to https://vanilla-wow.fandom.com/wiki/GetMacroSpell, but SpellCalc only uses the first one now, and I haven't checked if the second one is correct for rank-less macros..

Examples of macros that it ends up showing the wrong number for:

#showtooltip Mind Blast
/run UIErrorsFrame:Hide()
/console Sound_EnableErrorSpeech 0
/cast [harm,nodead] Inner Focus
/console Sound_EnableErrorSpeech 1
/run UIErrorsFrame:Clear() UIErrorsFrame:Show()
/cast [@mouseover,harm,nodead] [] Mind Blast
#showtooltip
/cast [@player] Power Word: Shield

Error when entering Vehicle

Every time I enter a vehicle I get the following error message

Message: ...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:238: attempt to index field '?' (a nil value)
Time: Sat Oct  1 23:28:27 2022
Count: 1
Stack: ...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:238: attempt to index field '?' (a nil value)
[string "@Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua"]:146: in function `origErrorHandler'
[string "@Interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua"]:761: in function <...Ons\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:717>
[string "=[C]"]: ?
[string "@Interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua"]:238: in function <...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:231>
[string "@Interface\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua"]:266: in function <...ce\AddOns\SpellCalc\UI/actionbar/ActionBarValues.lua:261>
[string "=[C]"]: ?
[string "=[C]"]: in function `SetAttribute'
[string "@Interface\FrameXML\SecureStateDriver.lua"]:114: in function <Interface\FrameXML\SecureStateDriver.lua:95>
[string "@Interface\FrameXML\SecureStateDriver.lua"]:127: in function <Interface\FrameXML\SecureStateDriver.lua:119>

Locals: private = <table> {
 ThrowError = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:46
 DoesErrorExist = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:87
 ClearOldErrors = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:107
 SanitizeLine = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:83
 MAX_STACK_DEPTH = 10
 log = <table> {
 }
 ErrorHandler = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:116
 IncrementErrorCount = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:77
 NewError = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:50
 IsRCLootCouncilError = <function> defined @Interface\AddOns\RCLootCouncil_Classic\RCLootCouncil\Core\ErrorHandler.lua:94
}
orig_errorhandler = <function> defined @Interface\SharedXML\SharedBasicControls.lua:355

Healing tooltip value slightly below actual value

Hey coolmodi I love this addon, but on my resto shaman the healing values are slightly below the actual number. For instance my lesser healing wave shows a SpellCalc heal of 1120-1217 but my heals go as high as 1300. I took the average of about 20 heals and got a 1244 average heal, 76 more than the average heal from SpellCalc. I would guess the addon is not calculating the Purification talent which gives +10% to healing on the base spell. This works out to be about +90 healing for Lesser Healing Wave rank 6. If the talent is being calculated into the tooltip then I'm not sure what might be causing the difference. My total healing is calculated correctly at +671, and the spell damage numbers look accurate to me.

Thanks,

Elvui Spellbook no tooltips

Spellcalc is no longer showing tooltips in the spell book when using an ElvUI version greater than 1.36

Specifically it looks like the commit 6978250c ActionBars Revamp is what breaks it.

Priest: Consider T5 set bonus

2pc T5 returns 100 mana if Greater Heal heals target to full. Request to consider separate effective cost and HPM calculation from positive proc.

TBC Compatibility?

Hi, just want to say I love this addon and use your tooltip info to do math with my spells daily.

I was wondering if you plan to continue releasing updates through TBC launch to cover some of the new ways spells/spell power/stats/etc work?

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.