Comments (4)
Found the bug. It is due to incorrect dealing with time window, when birth time is determined in getUserBirthTime in the ExtendedCohortSelection class. maxDate of this class is the max date in dataset. The date range for locating birth event in the original code needs to fall in the date of the user's first record and the max date - window size. This creates a problem for tail users that have their records very close to the max date. So their ranges to find birth event are empty ranges. Now I set the range to look for birth event for one user to be from the date of its first record to the date of its last record. It can output all the users.
from cool.
I agree with the reason that causes this issue, but I do not agree to change the code because it is not the problem of the core logic. Instead, we need to add introductions about how to utilize the time window attribute.
from cool.
If we want to use the time window, it means that we only want to select users who have records for at least x days where x is defined in the time window.
from cool.
But we also need to consider the users whose last record date is earlier than the max data in the data but do not have records for continuous x days.
from cool.
Related Issues (20)
- Refactor the functionality test HOT 1
- Format the PR code
- Invariant range filed lost min-max information in DataStore HOT 3
- Funnel analysis reformat
- One tuple may meet two events. HOT 1
- Birth event not used for age selection HOT 2
- OLAP Design HOT 2
- Retrospective cohort study HOT 1
- CoolTupleReader logic rework.
- extensibility for more value types HOT 1
- Bug: float compression/decompression HOT 1
- cohort selection problem HOT 2
- Input cohort implementation HOT 3
- process the time in a more fine-grained manner HOT 2
- Restructure cohort result output HOT 1
- Iceberg support is not ported over after we restructure processors
- Age in month and year are not equivalent to fixed-day interval
- query result cohort size is incorrect
- need to update the cohortselector layout
- Need to conserder the precision problem among time and storage.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cool.