contributte / doctrine-fixtures Goto Github PK

Not to purge database by mistake..

# no purge, append
bin/console doctrine:fixtures:load

# purge requested
bin/console doctrine:fixtures:load --purge

When running command doctrine:fixtures:load without parameters invalid purge mode is selected

https://github.com/nettrine/fixtures/blob/56accd28d40e6be410d8ebb147d60c45e257eef7/src/Command/LoadDataFixturesCommand.php#L131

value of $purgeTruncate is false when command is called without parameters and expression is evaluated as ORMPurger::PURGE_MODE_TRUNCATE

Ahoj, ve verzi "nettrine/fixtures": "^0.7.1" jsem dostával pří spuštění commandu php bin/console doctrine:fixtures:load --no-interaction chybu Could not find any fixture services to load.. Po downgradu na "nettrine/fixtures": "^0.6.4" se command spustí a Fixtures najde.

Versions 0.6.1 and 0.6.2 now throw this error when trying to run fixtures:

Careful, database will be purged. Do you want to continue y/N ?y
  > purging database

In Connection.php line 1853:

  There is no active transaction                                 

This now evaluates to 2 instead of 1 as it used to (ORMPurger constants):

0.6.1 and above
https://github.com/nettrine/fixtures/blob/56accd28d40e6be410d8ebb147d60c45e257eef7/src/Command/LoadDataFixturesCommand.php#L129-L131

0.6.0
https://github.com/nettrine/fixtures/blob/395476f575f48cd37d66f7856b0804b9534455f8/src/Command/LoadDataFixturesCommand.php#L127-L128

Composer info with relevant package:

doctrine/annotations     1.13.2 
doctrine/cache           1.12.1 
doctrine/collections     1.6.8  
doctrine/common          3.2.2  
doctrine/data-fixtures   1.5.2  
doctrine/dbal            2.13.7 
doctrine/deprecations   v0.5.3 
doctrine/event-manager   1.1.1  
doctrine/inflector       2.0.4  
doctrine/instantiator    1.4.0  
doctrine/lexer           1.2.2  
doctrine/orm             2.11.1 
doctrine/persistence     2.3.0  
nettrine/annotations    v0.7.0 
nettrine/cache          v0.3.0 
nettrine/dbal           v0.7.0 
nettrine/fixtures       v0.6.2 
nettrine/orm            v0.8.3 
symfony/console         v5.4.5

I cant find any significant changes in symfony/console 6.x in regards to InputInterface::getOption() method:

• https://github.com/symfony/console/blob/v5.4.5/Input/Input.php#L147-L162
• https://github.com/symfony/console/blob/v6.0.5/Input/Input.php#L147-L162

So this looks like a bug :)

Since the --fixtures option has been removed (#28), would it be possible to load fixtures registered as services?

doctrine/DoctrineFixturesBundle loads fixtures that implement the ORMFixtureInterface:

• https://symfony.com/bundles/DoctrineFixturesBundle/current/index.html#loading-fixtures
• https://github.com/doctrine/data-fixtures/blob/ae4e845decbe177348fdbecd04331f4fb96aa301/src/FixtureInterface.php

The common interface in doctrine/data-fixtures is this one:

• https://github.com/doctrine/data-fixtures/blob/ae4e845decbe177348fdbecd04331f4fb96aa301/src/FixtureInterface.php

This could be used to automatically load fixtures from extensions. Just an idea :)

I suggest to define default path %appDir%/../fixtures to be set by default. What do you think? @benijo