Hi Constantin, Thank you for your work in developing the geom_signif

Posting a reprex for future reference: <div class="highlight highlight-source-r no

geom_signif fails when reassigning factor levels about ggsignif HOT 2 OPEN

const-ae commented on May 24, 2024

geom_signif fails when reassigning factor levels

from ggsignif.

Comments (2)

const-ae commented on May 24, 2024

Hi Joe,
thanks for letting me know. This is indeed a puzzling bug. Unfortunately I don't have the capacity right now to search for the root cause. I will just leave this issue open for others who might encounter the same problem.
Best, Constantin

from ggsignif.

IndrajeetPatil commented on May 24, 2024

Posting a reprex for future reference:

library(plyr)
library(ggplot2)
library(ggsignif)

# generate some data
mtcars.meanMPG <-
  ddply(
    mtcars,
    .(carb, am),
    summarize,
    meanMPG = round(mean(mpg), 3)
  )

# works
ggplot(
  data = mtcars.meanMPG,
  aes(
    x = factor(carb),
    y = meanMPG,
    fill = am,
    group = am
  )
) +
  geom_bar(
    stat = "identity",
    position = position_dodge(preserve = "single")
  ) +
  geom_signif(
    annotation = "p = 0.01",
    y_position = 29,
    xmin = 1.7,
    xmax = 2.3,
    tip_length = c(0.01, 0.01)
  )

# doesn't work
ggplot(
  data = mtcars.meanMPG,
  aes(
    x = factor(carb, levels = unique(rev(mtcars.meanMPG$carb))),
    y = meanMPG,
    fill = am,
    group = am
  )
) +
  geom_bar(
    stat = "identity",
    position = position_dodge(preserve = "single")
  ) +
  geom_signif(
    annotation = "p = 0.01",
    y_position = 29,
    xmin = 1.7,
    xmax = 2.3,
    tip_length = c(0.01, 0.01)
  )
#> Warning: Use of `mtcars.meanMPG$carb` is discouraged. Use `carb` instead.

#> Warning: Use of `mtcars.meanMPG$carb` is discouraged. Use `carb` instead.

# doesn't work
mtcars.meanMPG$carb <-
  factor(mtcars.meanMPG$carb, levels = unique(rev(mtcars.meanMPG$carb)))

ggplot(
  data = mtcars.meanMPG,
  aes(
    x = carb,
    y = meanMPG,
    fill = am,
    group = am
  )
) +
  geom_bar(
    stat = "identity",
    position = position_dodge(preserve = "single")
  ) +
  geom_signif(
    annotation = "p = 0.01",
    y_position = 29,
    xmin = 1.7,
    xmax = 2.3,
    tip_length = c(0.01, 0.01)
  )