conjurinc / memtar Goto Github PK

When the size of an input file is exactly a factor of 512 (the block size), then an extra block of null bytes is incorrectly appended to the file content, causing the resulting tar archive to be corrupt.

Source Reference:

Add code coverage to this project.

Acceptance Criteria:

• Code coverage should be measured across all tests defined in this repository every time a build is run in any branch.
• Coverage report should include:
  • Line Coverage (including highlighting which lines are covered and which are not - not just giving a percentage)
  • Conditional Coverage
  • Optionally, other kinds of coverage such as Package, Class, File, or Method coverage
• Coverage report should be created in or converted to Cobertura format as part of build to allow for ingestion into coverage aggregation tools
• Coverage report should be archived in the Jenkins build using the cobertura command as shown at https://github.com/cyberark/conjur-api-ruby/blob/072d21e01e46382ee4d577e180c1269f8ff9f36e/Jenkinsfile#L27
• Coverage report should be uploaded to Code Climate with each build

See https://github.com/cyberark/conjur-service-broker/blob/master/CONTRIBUTING.md#releases as an example.

MemTar#add_file with an existing file fails with error can't find user for ... if a file is owned by a user or group for which a system database entry cannot be looked up.

In this case it should gracefully degrade to set the user/group name to decimal numeric ID, or skipping it altogether.

Dependabot flagged Bundler in this repo as being vulnerable to CVE-2019-3881. It needs to be upgraded to 2.1.0 or higher.