InstanceLayers loop is wrong in CreateInstance about the-forge HOT 9 CLOSED

Effectively, if we re-enable that code by initializing i to 0, then we get another problem because this line is commented :

//gVkWantedInstanceExtensions[k] = "";

Which means that VK_EXT_debug_report is both in the VK_LAYER_LUNARG_standard_validation and the "nullptr" layer (second loop) as the standard validation layer is implicitly enabled.

The only way to fix when we require VK_EXT_debug_report is to uncomment that line again.
However, it causes a new issue as we can't call CreateInstance again as we broke the initial array.

So, the real correct solution after we fix the loop with uint i = 0; is to empty the local array of string instead :
wantedInstanceExtensions[k] = "";

from the-forge.

@simondeschenes
We just merged a fix for the loop index but we weren't able to reproduce the second part of this issue.
Could you give us repro steps?
Also, could you try it out after the latest merge?
Thanks

from the-forge.

You need to comment #define USE_DEBUG_UTILS_EXTENSION inside of Vulkan.cpp.
That way, it will want to use VK_EXT_DEBUG_REPORT_EXTENSION_NAME instead of VK_EXT_DEBUG_UTILS_EXTENSION_NAME .

If you do, and have the first loop fixed, you will get VK_EXT_debug_utils 2 times in the gVkInstanceExtensions array (member of pRenderer).

I believe this commented code (because of the comment) was supposed to address this issue :

//gVkWantedInstanceExtensions[k] = "";

However, it is not right because it modifies gVkWantedInstanceExtensions instead of the local wantedInstanceExtensions array.

This is why the code should now read :

wantedInstanceExtensions[k] = "";

in both loops.

from the-forge.

I looked at the latest merge and it is effectively partially fixed. See previous post.

from the-forge.

Just to add to this, this is crashing on Linux on this line:
https://github.com/ConfettiFX/The-Forge/blob/master/Common_3/Renderer/Vulkan/Vulkan.cpp#L2533
I tried the things @simondeschenes suggests but it still crashes. I haven't spent much time on this to investigate.

Cheers!

from the-forge.

Disregard this, it was just an issue on my side not passing #define VULKAN, it works with/without the tweak from @simondeschenes

from the-forge.

@simondeschenes this should be resolved with the next release, probably next week ... if you have a chance check it out and then we can close this.

from the-forge.

As soon as I see the code online I'll check it out.

from the-forge.

It is up now ... let us know ....

from the-forge.