confact / dunirc Goto Github PK

Hello there is an issue in the function mejoin(e)

Sometimes the lenght of: var newmsg = e.split("\r\n:");
Is not above 1 and therefore trying to do newmsg = newmsg[1].split(" ");
breaks the script.

I changed to:
var newmsg = e.split("\r\n:"); if(newmsg.length < 2) return; newmsg = newmsg[1].split(" ");

As a temp fix to prevent from breaking the code but this means all the code in the function is not executed.

Also
Sometimes after reloading the page, it connects, it can send messages but not receive them.
And when i seems to join correctly the channel and we can send messages between 2 clients.
1 of the client can see the userlist but the other cant.

This fix my 2 previous issues...

Code: http://pastebin.com/kV82GYZe

This fix all issues i found.

• Fixed not joining channel properly.
• Fixed Get userlist after joining
• Add user to userlist when he join
• Remove user from userlist when he quit/part
• Update userlist when user change nick

Hello,
First of all thank you for this nice script, i got it working using websockify.js ( node.js version located in folder other/js ) on windows!

I noticed message wasnt showing or sending, so i took a look at my web console and saw an error at e.Match
... e wasnt defined, so i looked at your past commits and saw that e should be :
var e = window.atob(content.data);

So i added it to the line 126, now it fixed the issue! YAY! 👍