Comments (7)
If it had been out in use by any packages, it would be. But this change is only in a new version just published (which should perhaps be yanked, but I don't see a big reason to because this missing header means nobody can link against it), which presumably nobody can build against due to the missing header, which is the subject of this Issue.
Reading a bit more, I think we should stick with the 32b indices as the default, and the 64b choice for Windows was probably wrong.
from mumps-feedstock.
Yes, I believe that this is due to a change introduced in 5.5.1, where MUMPS was switching integer formats. The corresponding segment of mumps_c_types.h
from 5.2.1 (the version that was previously packaged via conda) is:
#include <stdint.h>
#ifdef INTSIZE64
#define MUMPS_INT int64_t
#else
#define MUMPS_INT int
#endif
and so it doesn't include the other file.
from mumps-feedstock.
Ok, I investigate a bit:
-
On Windows, the issue is not a problem as the 64-bit header is used (see
mumps-feedstock/recipe/bld-seq.bat
Line 8 in 2ca0931
-
On Linux/macOS, the 32-bit version is selected by the makefile:
2023-12-12T15:32:54.9625337Z if echo " -O " | grep DINTSIZE64; then cat mumps_int_def64_h.in > ../include/mumps_int_def.h; else cat mumps_int_def32_h.in > ../include/mumps_int_def.h; fi
However, this is not picked as mumps-include
was built before the make
script was ever execute.
So the possible action is to move mumps-include
build after make
as been run.
A non-directly related issue is that Windows uses 64 bit indeces, while Linux/macOS 32 bit. Was this intentional @minrk ?
from mumps-feedstock.
The latest windows version win-64_mumps-seq-5.6.2-h1f49738_1 still misses the header file mumps_int_def.h
, so I believe this issue was not completely fixed, please reopen.
from mumps-feedstock.
Thanks for the report. I guess everything was fine for earlier version of mumps, right?
from mumps-feedstock.
Was this intentional @minrk ?
No, I updated the build scripts until they worked and figured defaults would apply. It probably makes sense to use 64b indices everywhere.
from mumps-feedstock.
@minrk Wouldn't this blow in our faces as a huge ABI breakage? Maybe this package would need two build variants for 32 and 64 bit indices that can be explicitly selected via the build string?
from mumps-feedstock.
Related Issues (19)
- BLAS support HOT 2
- incorrect install name in osx mumps libraries HOT 3
- pkgconfig HOT 2
- Crash with metis 5.1.1 HOT 16
- segfault when shared library used from petsc: mac + openmpi only HOT 9
- Compile mumps as a shared library HOT 2
- build with MPI HOT 5
- broken kwant builds because of MPI build HOT 8
- mumps and mumps-mpi cannot be installed side-by-side HOT 7
- build examples using test.source_files HOT 1
- Only one variant of mumps-mpi is created HOT 5
- Master branch is failing HOT 6
- including mpi.h? HOT 12
- build with OpenMP HOT 1
- Windows package installs .lib files in Library\bin\
- Support for newer versions? HOT 2
- Needs pin for metis HOT 11
- @conda-forge-admin, please add user @traversaro HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mumps-feedstock.