Code Monkey home page Code Monkey logo

ansible-feedstock's Issues

Installing ansible coda package also gets me ansible-base==2.10.3 pip package

Issue:

Sounds crazy, so if anything, I would appreciate someone telling me this isn't happening for them.
Since conda ansible 2.10, if I create a clean environment and install only ansible, I get a pip package installed with ansible-base==2.10.3... while I know conda does support pip, this seems like a bug.
Installing a version less than 2.10 (2.9.x) this does not happen.


Environment (conda list):

Ubuntu Linux 18.04 (LTS) x86
conda 4.9.2

$ conda env export
name: test
channels:
  - defaults
  - conda-forge
dependencies:
  - _libgcc_mutex=0.1=main
  - ansible=2.10.5=py36h5fab9bb_0
  - appdirs=1.4.4=py_0
  - bcrypt=3.2.0=py36h7b6447c_0
  - boto=2.49.0=py36_0
  - brotlipy=0.7.0=py36h27cfd23_1003
  - brotlipy=0.7.0=py36h27cfd23_1003
  - ca-certificates=2020.12.8=h06a4308_0
  - certifi=2020.12.5=py36h06a4308_0
  - cffi=1.14.4=py36h261ae71_0
  - chardet=4.0.0=py36h06a4308_1003
  - cryptography=3.3.1=py36h3c74f83_0
  - decorator=4.4.2=py_0
  - dogpile.cache=0.9.2=pyh9f0ad1d_0
  - httplib2=0.18.1=pyh9f0ad1d_0
  - idna=2.10=py_0
  - importlib-metadata=2.0.0=py_1
  - importlib_metadata=2.0.0=1
  - iso8601=0.1.13=py36_1
  - jinja2=2.11.2=py_0
  - jmespath=0.10.0=py_0
  - jsonpatch=1.28=pyhd3eb1b0_0
  - jsonpointer=2.0=py_0
  - keystoneauth1=4.3.0=pyhd8ed1ab_0
  - ld_impl_linux-64=2.33.1=h53a641e_7
  - libedit=3.1.20191231=h14c3975_1
  - libffi=3.3=he6710b0_2
  - libgcc-ng=9.1.0=hdf63c60_0
  - libsodium=1.0.18=h7b6447c_0
  - libstdcxx-ng=9.1.0=hdf63c60_0
  - markupsafe=1.1.1=py36h7b6447c_0
  - munch=2.5.0=py_0
  - ncurses=6.2=he6710b0_1
  - netifaces=0.10.9=py36h8c4c3a4_1003
  - openssl=1.1.1i=h27cfd23_0
  - openstacksdk=0.52.0=py36h5fab9bb_0
  - os-service-types=1.7.0=pyh9f0ad1d_0
  - paramiko=2.7.2=py_0
  - pbr=5.5.1=py_0
  - pip=20.3.3=py36h06a4308_0
  - pycparser=2.20=py_2
  - pynacl=1.4.0=py36h7b6447c_1
  - pyopenssl=20.0.1=pyhd3eb1b0_1
  - pysocks=1.7.1=py36h06a4308_0
  - python=3.6.12=hcff3b4d_2
  - python_abi=3.6=1_cp36m
  - pyyaml=5.3.1=py36h7b6447c_1
  - readline=8.0=h7b6447c_0
  - requests=2.25.1=pyhd3eb1b0_0
  - requestsexceptions=1.4.0=py_0
  - setuptools=51.0.0=py36h06a4308_2
  - six=1.15.0=py36h06a4308_0
  - sqlite=3.33.0=h62c20be_0
  - stevedore=3.3.0=py36h5fab9bb_0
  - tk=8.6.10=hbc83047_0
  - urllib3=1.26.2=pyhd3eb1b0_0
  - wheel=0.36.2=pyhd3eb1b0_0
  - xz=5.2.5=h7b6447c_0
  - yaml=0.2.5=h7b6447c_0
  - zipp=3.4.0=pyhd3eb1b0_0
  - zlib=1.2.11=h7b6447c_3
  - pip:
    - ansible-base==2.10.3

Details about conda and system ( conda info ): 
$ conda info
$ conda info

     active environment : test
    active env location : /home/calebm/miniconda3/envs/test
            shell level : 1
       user config file : /home/calebm/.condarc
 populated config files : /home/calebm/.condarc
          conda version : 4.9.2
    conda-build version : not installed
         python version : 3.8.5.final.0
       virtual packages : __cuda=11.0=0
                          __glibc=2.27=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /home/calebm/miniconda3  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /home/calebm/miniconda3/pkgs
                          /home/calebm/.conda/pkgs
       envs directories : /home/calebm/miniconda3/envs
                          /home/calebm/.conda/envs
               platform : linux-64
             user-agent : conda/4.9.2 requests/2.24.0 CPython/3.8.5 Linux/5.4.0-53-generic ubuntu/18.04.5 glibc/2.27
                UID:GID : ----:---
             netrc file : None
           offline mode : False

Review dependencies?

Thanks for making this available!

Had a look into it, and there are some issues that, while everything still works, are less-than-ideal.

pycrypto

ansible hasn't had a hard dependency on the abandoned pycrypto for some time. This is a problem for at least one CVE and who knows how many more. We could:

  • patch pycrypto feedstock (e.g. use the debian patch)
    • 👍 other packages would likely benefit from this
    • 👎 scanners (like safety) will continue to find issues with this, because the pypi upstream is probably never going to get fixed at this point
  • start using pycryptodome
    • :+0: i mean, whatever...
  • start using cryptography
    • 👍 ansible started preferring cryptography to pycrypto over two years ago, but still supports both APIs, so it seems like the last option is most in line with the upstream.

httplib2

Was never a hard dependency, and some behavior has been re-implemented for what is remaining. Some of the contrib stuff (which we don't even distribute) does use it, but...

boto, shade, ...

it's very unlikely you'd use both at once, and if these two, why not GCP/Azure/RedShift/whatever else is supported in the huge contrib library? We could introduce multiple outputs that did do this, move current ansible to ansible-core, and leave ansible as a metapackage, but bleah. I'd be more inclined to just not include these, as you'll know, and likely want to manage, the version of your provider-specific library.

paramiko

Really torn on this. This is no longer a hard dependency, and the local connection will work fine without it, BUT it seems like keeping is a good idea. Again, as a security-related library, it's probably worth a look at a sensible bottom pin for this.

Happy to work up a PR!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.