component / overlay Goto Github PK

i think all view's should expose a regular element as their this.el instead of sometimes being elements and sometimes being jquery-like objects. if they need the shorthand, they can use a private this.$el instead.

let me know what you think @visionmedia and i'll PR this (once some of the other conflicting PRs are merged/closed)

curious, is the overlay not escapable on purpose? or would it make sense to pull the escapability from dialog into overlay instead?

building my own overlay and wishing escapable was baked in

Hey,

if you use this great component in IE9 or 10 there is a bug.

Calling the remove method the element is hiding for 2 secounds.
During this time you cant use your website, because the overlay catches all the mouse events.

I dont have a solution for this problem.
Why do we have to wait 2 secounds before removing the element?
Removing it after ~300ms would avoid getting stressed.

Thanks!

(I know, there is no excuse using the IE and I dont use it! ;)

i dont think it should assume you want to remove the overlay when you are just hiding it.

in my case, adding a modal to the page and it can be opened/closed multiple times. currently i'd have to manually reattach the overlay each time, whereas if i really wanted that functionality i dont think its that hard to do hide().remove()

altho since hiding should be async (animations), it might be better to have it take a callback:

overlay.hide(function () {
  overlay.remove();
});

what do you think? i can PR this functionality if you want it @visionmedia