Code Monkey home page Code Monkey logo

borderlessmining's People

Contributors

burrconnie avatar comp500 avatar darkknightcomes avatar demonese avatar egeesin avatar felix14-v2 avatar fitfc avatar frederick888 avatar guanran928 avatar gyular avatar julienraptor01 avatar kas-tle avatar mrfrydae avatar nikitacartes avatar rfresh2 avatar thebossmagnus avatar vanjmali avatar xmikux avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

borderlessmining's Issues

minecraft stuck in borderless even without the mod

idk if im missing something, but iv loaded mc with the mod once, and now all the instances of prism launcher use borderless mode, even without having ever installed the mod on that instance, if i use the vanilla launcher instead it uses normal window mode
the first time i used the mod was on a 1.18.2 instance

Still no 1.17 download on curseforge

I know this may count as a duplicate of a few other issues, but there still isn't a download on cf so I thought I'd just make another issue here...

Sodium

I use Sodium for my fps improvements with alot of other mods tho i dont see the borderless option. So could you add Sodium support?

GLFW breaks with larger primary monitor with display scaling

Hi, I've got two monitors that are different sizes.

My main monitor is 3840x2160 while my second monitor is 1920x1080. If I choose either Current or Monitor 0 (primary 4K monitor) as the display monitor, it shows up in the top left of my 4K screen, as I expect it to. However, when I choose to have MC display on the second monitor at its native resolution, it instead appears in the top-right quadrant on my first monitor at a much smaller resolution (probably around 480p resolution).

The only way for it to show properly on my second monitor (game takes up whole screen on Monitor 1) is to have:
Custom dimensions (3840w 2160h)
Monitor-relative coordinates (3840x 1080y)
But, doing so causes my computer to render it in 4K despite it only being a 1080p screen. This defeats the purpose of having MC render on the lower-res monitor in the first place (my gfx card can't consistently handle 60fps on a 4K screen, plus my 1080p monitor is larger anyway).

I can attach images as needed, but for now I'll stick to going into my Windows settings and changing the primary monitor every time I want to play. This itself wouldn't be an issue, either, except that Windows eats my Discord notifications every fucking time I do that. To fix this, I have to restart Windows Explorer, which in turn eats up my tray notifications for Spotify and my graphics card... it's all just one massive slippery slope. πŸ˜‚πŸ”«

Borderless Window not work

I activate Borderless Window.
But when the Fullscreen Option is on i cant have another window in front of Minecraft while Minecraft are active...

The overlay then the other windows....

how fix that?

Excessive screen tearing

  • Found on Windows Intel/NVIDIA hybrid graphics, using the internal screen and Intel graphics.
  • Only occurs in Borderless Fullscreen, reason is unknown.
  • Solution: Switch to NVIDIA graphics, or use windowed / exclusive fullscreen, or move to an external screen (however this is slower).

If you have any information on this issue could be fixed, or have reproduced it, please comment!

Incompatibility with two other mods

(1.19)
Optifabric seems to have incompatibilities when it is intalled together with Slight GUI Modifications and Optifabric (and Optifine). Only the combination of those 3 mods crashes the game. No other combinations. See the following:

Optifabric (and Optifine ) + Borderless Mining = working
Optifabric (and Optifine ) + Slight GUI Modifications = working
Borderless Mining + Slight GUI Modifications = working
Borderless Mining + Optifabric (and Optifine ) + Slight GUI Modifications = crash

Shedaniel, the dev of Slight GUI Modification closed my issue to his mod with the comment "I don't care about optifine", so maybe there's a possible fix by Borderless Mining?

Linux support?

Hello,
I wanted to ask if there are plans for a future port to the Linux platform?

Greeting CoolerWuffi

Chat crashes with Optifine

When opening the chat preview with optifine/optifabric installed with BorderlessMining the game crashes.

Game crashes when I go into options.

When I have this mod installed along with OptiFabric, any attempt to open the options will crash the game with the error

The game crashed whilst mouseclicked event handler
Error: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_446 failed

The crash log reads out:

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_446 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_442.method_19863(class_442.java:179)
	at net.minecraft.class_4185.method_25306(class_4185.java:94)
	at net.minecraft.class_4264.method_25348(class_4264.java:57)
	at net.minecraft.class_339.method_25402(class_339.java:187)
	at net.minecraft.class_4069.method_25402(class_4069.java:38)
	at net.minecraft.class_442.method_25402(class_442.java:431)
	at net.minecraft.class_312.method_1611(class_312.java:98)
	at net.minecraft.class_437.method_25412(class_437.java:540)
	at net.minecraft.class_312.method_1601(class_312.java:98)
	at net.minecraft.class_312.method_22686(class_312.java:169)
	at net.minecraft.class_1255.execute(class_1255.java:118)
	at net.minecraft.class_312.method_22684(class_312.java:169)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403)
	at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:207)
	at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:218)
	at net.minecraft.class_1041.method_15998(class_1041.java:393)
	at net.minecraft.class_310.method_1523(class_310.java:1238)
	at net.minecraft.class_310.method_1514(class_310.java:801)
	at net.minecraft.client.main.Main.main(Main.java:237)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
	... 28 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Multi-argument modifier method modifyOption(Lorg/spongepowered/asm/mixin/injection/invoke/arg/Args;)V in borderlessmining.mixins.json:FullScreenOptionMixin from mod borderlessmining failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap borderless-mining-refmap.json
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	... 31 more

Stacktrace

-- Head --
Thread: Render thread
Stacktrace:
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_442.method_19863(class_442.java:179)
	at net.minecraft.class_4185.method_25306(class_4185.java:94)
	at net.minecraft.class_4264.method_25348(class_4264.java:57)
	at net.minecraft.class_339.method_25402(class_339.java:187)
	at net.minecraft.class_4069.method_25402(class_4069.java:38)
	at net.minecraft.class_442.method_25402(class_442.java:431)
	at net.minecraft.class_312.method_1611(class_312.java:98)
	at net.minecraft.class_437.method_25412(class_437.java:540)
	at net.minecraft.class_312.method_1601(class_312.java:98)
	at net.minecraft.class_312.method_22686(class_312.java:169)
	at net.minecraft.class_1255.execute(class_1255.java:118)
	at net.minecraft.class_312.method_22684(class_312.java:169)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403)
	at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:207)
	at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:218)

-- Affected screen --
Details:
	Screen name: net.minecraft.class_442
Stacktrace:
	at net.minecraft.class_437.method_25412(class_437.java:540)
	at net.minecraft.class_312.method_1601(class_312.java:98)
	at net.minecraft.class_312.method_22686(class_312.java:169)
	at net.minecraft.class_1255.execute(class_1255.java:118)
	at net.minecraft.class_312.method_22684(class_312.java:169)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403)
	at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:207)
	at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:218)
	at net.minecraft.class_1041.method_15998(class_1041.java:393)
	at net.minecraft.class_310.method_1523(class_310.java:1238)
	at net.minecraft.class_310.method_1514(class_310.java:801)
	at net.minecraft.client.main.Main.main(Main.java:237)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Microstutters

Constant microstuttering on borderless fullscreen when using V-Sync (in-game/NVIDIA Control Panel) and/or limiting the maximum FPS. Doesn't happen in exclusive fullscreen. This happens regardless the frame rate (tested on 360Hz monitor). No, #19 doesn't fix this.

Edit: I'm unable to reproduce this issue on 1.19 with Release 1.1.5+1.19. Actually, Release 1.1.5+1.19 seems to work perfectly without any other issues I experienced before, except for #2

In-game V-Sync incorrectely caps FPS to 64 instead of the maximum refrash rate

If V-Sync is enabled trough Video Settings in Sodium (haven't tested in vanilla) the FPS is capped to 64 FPS, regardless of monitor's max refresh rate. If I enabled V-Sync trough NVIDIA Control Panel (but not in-game) the FPS is correctly capped to the maximum refresh rate (e.g. 144). The borderless fullscreen is of course enabled. This doesn't happen in regular (exclusive?) fullscreen.

Mouse cursor gone

I installed borderless mining to test some stuff with recordings then I uninstalled it, now my game won't ever show my cursor when on fullscreen. Any idea how to fix this? I find it really odd that my mouse is gone AFTER uninstalling the mod completely, even deleted the configs...

Add the option to only enable when tabbed out

Running borderless fullscreen all the time gives half the fps compared to regular fullscreen, and it is only useful when tabbed out, so I thought it would be cool if there was a config option that makes it so that it switches to borderless fullscreen only when tabbed out

Valid resolutions not being reported in GLFW

(split from #25) "1366x768@75 (24bit)" video mode is added as a custom resolution in NVIDIA settings, but doesn't show up in Minecraft settings and whenever GLFW fullscreen (with patch #19) is used, the refresh rate reverts to 60 Hz

Unable to use xbox game bar

Even when in fullscreen and with this mod installed, I can't use xbox game bar
It tells me to choose fullscreen borderless in the game settings when I already have it chosen in the mod menu settings screen for the mod

Adding the borderless mod cuts performance in half...

Big performance hit ~140 fps down to around 60 fps

Using borderless mining 1.1.1-1.18
fabric-api 44.0
sodium 0.4.0 alpha 5

before adding borderless
without-borderless

after adding it
with-borderless

You can see a big increase in the proportion of the updateDisplay (light blue) part of the pie chart

Fullscreen resolution not changing with borderless mining

when i set my fullscreen resolution to 1920x1080 instead of 2560x1440, for some reason with borderless mining it stays at 1440p. i have tried changing it in the installation settings, with sodium extra, and with the fullscreen resolution slider. it only changes to 1080p when i don't have borderless mining installed or i disable it in the mod settings
image

Multi-monitor fullscreen without surround/eyefinity

Title says it all really. I currently have a triple monitor setup, but the only way to conveniently play with those is by stretching a Minecraft window over all of them. I was wondering if this mod could help actually making it fullscreen over those 3 monitors. Would be awesome, but thank you for the mod either way!

Use GLFW_AUTO_ICONIFY with GLFW's fullscreen on Linux

Linux KDE has a much better compositor and all support by default, so this mod should be disabled.
Why not make it only enabled on Windows, the only place where it is needed anyway?
Or maybe turn it off on non-windows by default so that people don't struggle with the hotkey not working corectly in some modpacks

Minecraft 1.17 is out

I would like to see this mod on 1.17 because this mod really helps out if you alt-tab alot and want to use fullscreen

I think this mod can work without the Fabric API

I don’t see anything in the code that calls Fabric API Mod.
So I tried to edit the fabric.mod.json in the release version, remove the fabric dependency and put it in the mods directory without the Fabric API. It seems to be working perfectly

"depends": {
    "fabricloader": "\u003e\u003d0.7.2",
    "minecraft": "~1.16-alpha.20.12.a"
  },

So I think we can remove the fabric dependency. In this way, I don't need to install Fabric API in my client.

Crashes w/ 1.19 optifine + fabric

When I have borderless Mining installed with optifine and fabric, and click the options button in the menu screen, I instantly crash. If I remove borderless mining, I can open the options menu and the game runs fine.

I have attached my crash report

---- Minecraft Crash Report ----
// Don't do that.

Time: 7/5/22, 9:56 PM
Description: mouseClicked event handler

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_446 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:419)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at net.minecraft.class_442.method_19863(class_442.java:173)
at net.minecraft.class_4185.method_25306(class_4185.java:40)
at net.minecraft.class_4264.method_25348(class_4264.java:16)
at net.minecraft.class_339.method_25402(class_339.java:120)
at net.minecraft.class_4069.method_25402(class_4069.java:27)
at net.minecraft.class_442.method_25402(class_442.java:492)
at net.minecraft.class_312.method_1611(class_312.java:94)
at net.minecraft.class_437.method_25412(class_437.java:491)
at net.minecraft.class_312.method_1601(class_312.java:94)
at net.minecraft.class_312.method_22686(class_312.java:165)
at net.minecraft.class_1255.execute(class_1255.java:118)
at net.minecraft.class_312.method_22684(class_312.java:165)
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
at org.lwjgl.system.JNI.invokeV(Native Method)
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:224)
at net.minecraft.class_310.method_1523(class_310.java:1174)
at net.minecraft.class_310.method_1514(class_310.java:734)
at net.minecraft.client.main.Main.main(Main.java:237)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:414)
... 34 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Multi-argument modifier method modifyOption(Lorg/spongepowered/asm/mixin/injection/invoke/arg/Args;)V in borderlessmining.mixins.json:FullScreenOptionMixin from mod borderlessmining failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap borderless-mining-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 37 more

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:419)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at net.minecraft.class_442.method_19863(class_442.java:173)
at net.minecraft.class_4185.method_25306(class_4185.java:40)
at net.minecraft.class_4264.method_25348(class_4264.java:16)
at net.minecraft.class_339.method_25402(class_339.java:120)
at net.minecraft.class_4069.method_25402(class_4069.java:27)
at net.minecraft.class_442.method_25402(class_442.java:492)
at net.minecraft.class_312.method_1611(class_312.java:94)
at net.minecraft.class_437.method_25412(class_437.java:491)
at net.minecraft.class_312.method_1601(class_312.java:94)
at net.minecraft.class_312.method_22686(class_312.java:165)
at net.minecraft.class_1255.execute(class_1255.java:118)
at net.minecraft.class_312.method_22684(class_312.java:165)
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
at org.lwjgl.system.JNI.invokeV(Native Method)
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)

-- Affected screen --
Details:
Screen name: net.minecraft.class_442
Stacktrace:
at net.minecraft.class_437.method_25412(class_437.java:491)
at net.minecraft.class_312.method_1601(class_312.java:94)
at net.minecraft.class_312.method_22686(class_312.java:165)
at net.minecraft.class_1255.execute(class_1255.java:118)
at net.minecraft.class_312.method_22684(class_312.java:165)
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
at org.lwjgl.system.JNI.invokeV(Native Method)
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:224)
at net.minecraft.class_310.method_1523(class_310.java:1174)
at net.minecraft.class_310.method_1514(class_310.java:734)
at net.minecraft.client.main.Main.main(Main.java:237)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)

-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
Packs: FIRE GLINT.zip, Default, Alternate Beehives, xali's+Enchanted+Books+v0.9.zip, Fabric Mods, Clear+Glass+Pack+1.19.zip, 1.19 vanilla Tweaks.zip
Stacktrace:
at net.minecraft.class_6360.method_36565(class_6360.java:49)
at net.minecraft.class_310.method_1587(class_310.java:2295)
at net.minecraft.class_310.method_1514(class_310.java:753)
at net.minecraft.client.main.Main.main(Main.java:237)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)

-- System Details --
Details:
Minecraft Version: 1.19
Minecraft Version ID: 1.19
Operating System: Windows 11 (amd64) version 10.0
Java Version: 17.0.2, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation
Memory: 5849021408 bytes (5578 MiB) / 6702497792 bytes (6392 MiB) up to 12884901888 bytes (12288 MiB)
CPUs: 16
Processor Vendor: AuthenticAMD
Processor Name: AMD Ryzen 7 5800H with Radeon Graphics
Identifier: AuthenticAMD Family 25 Model 80 Stepping 0
Microarchitecture: unknown
Frequency (GHz): 3.19
Number of physical packages: 1
Number of physical CPUs: 8
Number of logical CPUs: 16
Graphics card #0 name: AMD Radeon(TM) Graphics
Graphics card #0 vendor: Advanced Micro Devices, Inc. (0x1002)
Graphics card #0 VRAM (MB): 512.00
Graphics card #0 deviceId: 0x1638
Graphics card #0 versionInfo: DriverVersion=30.0.13014.7002
Graphics card #1 name: NVIDIA GeForce RTX 3050 Ti Laptop GPU
Graphics card #1 vendor: NVIDIA (0x10de)
Graphics card #1 VRAM (MB): 4095.00
Graphics card #1 deviceId: 0x25a0
Graphics card #1 versionInfo: DriverVersion=30.0.15.1259
Memory slot #0 capacity (MB): 16384.00
Memory slot #0 clockSpeed (GHz): 3.20
Memory slot #0 type: DDR4
Memory slot #1 capacity (MB): 16384.00
Memory slot #1 clockSpeed (GHz): 3.20
Memory slot #1 type: DDR4
Virtual memory max (MB): 36968.25
Virtual memory used (MB): 19664.41
Swap memory total (MB): 4864.00
Swap memory used (MB): 66.21
JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms6144m -Xmx12288m
Fabric Mods:
advancementinfo: AdvancementInfo 1.19-fabric0.53.3-1.3.1
advancementscreenshot-fabric: Advancement Screenshot (Fabric) 3.3
architectury: Architectury 5.7.28
bettercontrols: Better Controls 1.2.3
boostedbrightness: Boosted Brightness 2.1.2
borderlessmining: Borderless Mining 1.1.4+1.19
chesttracker: Chest Tracker 1.1.17
libgui: LibGui 6.0.0-beta.5+1.19-pre1
jankson: Jankson 4.1.1+j1.2.1
blue_endless_jankson: jankson 1.2.1
libninepatch: LibNinePatch 1.1.0
whereisit: Where Is It 1.14.11
collective-fabric: Collective (Fabric) 4.27
fiber: fiber 0.23.0-2
easiercrafting: EasierCrafting 1.19-fabric0.53.3-1.7
crowdin-translate: CrowdinTranslate 1.4+1.19
gbfabrictools: GBfabrictools 1.3.4+1.19
easiervillagertrading: EasierVillagerTrading 1.19-fabric0.53.3-1.5.4
fabric: Fabric API 0.56.0+1.19
fabric-api-base: Fabric API Base 0.4.9+e62f51a3a9
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.7+9ff28f40a9
fabric-biome-api-v1: Fabric Biome API (v1) 9.0.13+b2a4a624a9
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.18+9ff28f40a9
fabric-command-api-v1: Fabric Command API (v1) 1.2.5+f71b366fa9
fabric-command-api-v2: Fabric Command API (v2) 2.1.1+cda9839ba9
fabric-commands-v0: Fabric Commands (v0) 0.2.22+df3654b3a9
fabric-containers-v0: Fabric Containers (v0) 0.1.27+df3654b3a9
fabric-content-registries-v0: Fabric Content Registries (v0) 3.1.0+4a3ec384a9
fabric-convention-tags-v1: Fabric Convention Tags 1.0.8+37622d24a9
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.3+bd0a0d4aa9
fabric-data-generation-api-v1: Fabric Data Generation API (v1) 5.0.1+2a5b9210a9
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.27+72da3b3da9
fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.16+9ff28f40a9
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.26+9ff28f40a9
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.25+df3654b3a9
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.19+18990361a9
fabric-item-api-v1: Fabric Item API (v1) 1.5.4+767db26ea9
fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.23+9ff28f40a9
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.18+9ff28f40a9
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.16+df3654b3a9
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.1.0+33fbc738a9
fabric-loot-api-v2: Fabric Loot API (v2) 1.0.1+9e7660c6a9
fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.1+9e7660c6a9
fabric-message-api-v1: Fabric Message API (v1) 1.0.1+513f4a59a9
fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.8+33fbc738a9
fabric-models-v0: Fabric Models (v0) 0.3.15+9ff28f40a9
fabric-networking-api-v1: Fabric Networking API (v1) 1.0.27+7fe97409a9
fabric-networking-v0: Fabric Networking (v0) 0.3.14+df3654b3a9
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 4.0.5+9ff28f40a9
fabric-particles-v1: Fabric Particles (v1) 1.0.8+dc39553aa9
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.9.16+92cf9a3ea9
fabric-renderer-api-v1: Fabric Renderer API (v1) 1.0.8+9ff28f40a9
fabric-renderer-indigo: Fabric Renderer - Indigo 0.6.6+9ff28f40a9
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.18+df3654b3a9
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.12+9ff28f40a9
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.5+9ff28f40a9
fabric-rendering-v0: Fabric Rendering (v0) 1.1.20+df3654b3a9
fabric-rendering-v1: Fabric Rendering (v1) 1.10.14+9ff28f40a9
fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.0.9+e62f51a3a9
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.5.3+9e7660c6a9
fabric-screen-api-v1: Fabric Screen API (v1) 1.0.23+9ff28f40a9
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.2.6+9ff28f40a9
fabric-textures-v0: Fabric Textures (v0) 1.0.18+9ff28f40a9
fabric-transfer-api-v1: Fabric Transfer API (v1) 2.0.9+e62f51a3a9
fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 1.1.1+9e7660c6a9
fabricloader: Fabric Loader 0.14.8
farsight: Farsight Mod 1.19-2.0
forgeconfigapiport: Forge Config API Port 4.0.0
com_electronwill_night-config_core: core 3.6.5
com_electronwill_night-config_toml: toml 3.6.5
freecam: Freecam 1.1.1
cloth-config: Cloth Config v6 7.0.72
cloth-basic-math: cloth-basic-math 0.6.1
guiclock-fabric: GUI Clock (Fabric) 3.2
iceberg: Iceberg 1.0.38
impactfulweather: Biome Particle Weather 3.4.8
inventoryprofilesnext: Inventory Profiles Next 1.5.3
itemscroller: Item Scroller 0.16.0
java: Java HotSpot(TM) 64-Bit Server VM 17
lightoverlay: Light Overlay 7.0.0
litematica: Litematica 0.11.3
malilib: MaLiLib 0.12.1
minecraft: Minecraft 1.19
minihud: MiniHUD 0.22.0
modmenu: Mod Menu 4.0.0
mousewheelie: Mouse Wheelie 1.9.1+mc1.19-pre1
amecsapi: Amecs API 1.3.6+mc22w17a
coat: Coat 1.0.0-beta.18+mc22w17a
tweed4_annotated: tweed4_annotated 1.3.1+mc22w17a
tweed4_base: tweed4_base 1.6.0+mc22w17a
tweed4_data: tweed4_data 1.2.1+mc22w17a
tweed4_data_hjson: tweed4_data_hjson 1.1.1+mc22w17a
tweed4_tailor_coat: tweed4_tailor_coat 1.1.3+mc22w17a
tweed4_tailor_screen: tweed4_tailor_screen 1.1.1+mc22w17a
optifabric: OptiFabric 1.13.4
mm: Manningham Mills 2.3
replanter: Replanter 1.3
shulkerboxtooltip: Shulker Box Tooltip 3.0.9+1.19
torohealth: ToroHealth Damage Indicators 1.19-fabric-1
tweakeroo: Tweakeroo 0.13.3
voxelmap: Voxelmap 1.19-1.11.7
worldedit: WorldEdit 7.2.11-beta-01+6200-0877589
Launched Version: 1.19
Backend library: LWJGL version 3.3.1 SNAPSHOT
Backend API: NVIDIA GeForce RTX 3050 Ti Laptop GPU/PCIe/SSE2 GL version 3.2.0 NVIDIA 512.59, NVIDIA Corporation
Window size: 1920x1080
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fabric'
Type: Client (map_client.txt)
Graphics mode: fast
Resource Packs: file/FIRE GLINT.zip (incompatible), vanilla, file/Alternate Beehives (incompatible), file/xali's+Enchanted+Books+v0.9.zip (incompatible), Fabric Mods, file/Clear+Glass+Pack+1.19.zip, file/1.19 vanilla Tweaks.zip
Current Language: English (US)
CPU: 16x AMD Ryzen 7 5800H with Radeon Graphics
OptiFine Version: OptiFine_1.19_HD_U_H8_pre4
OptiFine Build: 20220705-014742
Render Distance Chunks: 16
Mipmaps: 0
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
Shaders: (internal)
OpenGlVersion: 3.2.0 NVIDIA 512.59
OpenGlRenderer: NVIDIA GeForce RTX 3050 Ti Laptop GPU/PCIe/SSE2
OpenGlVendor: NVIDIA Corporation
CpuCount: 16

-- OptiFabric --
Details:
OptiFine jar designed for: 1.19
OptiFine jar version: OptiFine_1.19_HD_U_H8_pre4
OptiFine jar status: Valid OptiFine mod
OptiFine remapped jar: C:/Users/andyd/Downloads/Downloads/MultiMC/instances/Fabric 1.19/.minecraft/.optifine/OptiFine_1.19_HD_U_H8_pre4/Optifine-mapped.jar
OptiFabric error:

f11 doesn't work

OS: Nobara(Linux)
PC type: laptop
GPU: NVIDIA GeForce 1050 mobile
CPU: Intel i5-8300H
Versions: Minecraft 1.19.2, Fabric Loader 0.14.9, Mod 1.1.5+1.19
Launcher: Prism launcher

The problem is that instead of changing from borderless windowed to windowed, the screen flickers and the window is still borderless windowed, but the GUI is in a different location
I have tested it with integrated/dedicated gpu, this is happening with just the borderless mining mod.

untitled.mp4

Crash without Fabric API installed

I used the latest version 1.1.1 published on Modrinth. It seems to cause a crash every time I try to run Borderless Mining without the Fabric API installed or other mods containing fabric-resource-loader.
[Demo]

1.17?

I think the title says it all @comp500

Updating this to 1.17 will help loads of people since many people are in the process of updating to 1.17.

Fullscreen Window Placement offset after CTD or Force Close

If Minecraft crashes to desktop or you force close it while it is in borderless fullscreen, upon restarting, the window will be placed in the same position as the window, offset on the screen. This prevents being able to move the window or press the buttons on the bottom of the window.

Suggested Solution: Find some way to readjust the Borderless Window on boot so it is always in the correct position to cover the screen, or at least snug to the monitor's top left corner.

Operating System: Windows 10 x64
Intel and AMD systems, nVidia and AMD graphics, dual monitors

Steps to reproduce:
0: Open Task Manager or equivalent
1: Open Minecraft (with this mod installed)
2: Enter Borderless Fullscreen
3: Create new world
4: Tab over to Task Manager (or equivalent) and force close Minecraft while it is still generating the new world
5: Re-open Minecraft
6: Figure out how to fix the fullscreen window being halfway off the screen bottom when you can't press the right buttons

Note: Sometimes, instead of staying halfway off the screen, the window displays correctly in fullscreen, but the actual window is still offset, so the buttons can't be clicked as you see them.

Snip and Sketch incompatibility

I'm currently using the lastest Borderless Fullscreen a.k.a v1.1.1
Whenever I wanna take a screenshot using Snip & Sketch (hotkey is Windows + Shift + R), normally it would show the toolbar on middle top with a "plus" mouse cursor, instead it kinda overlapped
For tabbing in and out, the screen flashed for a split second

Here's the video: https://streamable.com/xlzrb4
(to recognize the flashing screen, look at my mouse which flashed for a split second)

If these ain't bugs then I'm sorry for bothering πŸ‘€

Add options to Sodium's settings screen

Borderless Mining can't be enabled from Sodium's video options screen, as it replaces the vanilla screen. As a workaround, press Shift+P when in the Sodium video options screen to show the vanilla screen. It'd be nice to add options for Borderless Mining to the Sodium screen, at very least the ability to toggle borderless windowed.

Not planning to work on this myself since it's a fair bit of effort but contributions are welcomed.

Windows Game Bar

This could just be an issue to do with it being on 1.15.2 with LWJGL 3 and the GLFW implementation, but the windos game bar doesnt render on top of the minecraft window.

Game Crashes with Optifine/Optifabric

When using this mod with the 1.19 Optifine and 1.13.5 Optifabric mods, my game crashes whenever I try to use the chat. This applies to both single and multiplayer.

Tracking issue: GLFW patch for improved fullscreen compatibility

I'm working on a patch to GLFW that will improve borderless fullscreen compatibility using different window flags. I've been looking into the issues with current fullscreen methods Borderless Mining (and similar mods) uses, and I hope that these changes will fix some of the issues people have with the mod currently (including #1 #2 #3 #9).

These patches will only have effect on Windows - if you're experiencing issues on other operating systems, please report them separately.

As I am rather busy currently, I have no timeline or guarantee for these changes to be implemented; but please subscribe to this issue (using the button on the right) for updates and test builds.

Screen flashes black when clicking away

This is caused by the OpenGL driver forcing exclusive fullscreen to be used when the application is focussed. Some OpenGL drivers (NVIDIA, AMD) can be configured to use a "DXGI swapchain" which fixes this issue, but I am working on a better solution in #19 (currently only works on NVIDIA).

Original issue text
  • Found on Windows Intel/NVIDIA hybrid graphics, using the internal screen and Intel graphics.
  • Only occurs in Borderless Fullscreen, reason is unknown.
  • Solution: Switch to NVIDIA graphics, or use windowed / exclusive fullscreen, or move to an external screen (however this is slower).

If you have any information on this issue could be fixed, or have reproduced it, please comment!

Refresh rate forced to 60hz

When using borderless mining, the refresh rate of my monitor is automatically set to 60hz. I have tried adjusting fullscreen resolution to 144hz in the sodium menu, but since borderless mining overrides that it doesn't change anything.

Possible that I'm just missing an obvious solution though.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.