Enforce git commit message about nodejs HOT 7 CLOSED

💭 We can add a npm script that does master pull > soft reset > npm run commit. To make the workflow a bit easier.

from nodejs.

yeah I would go for that approach too, @Siilwyn

from nodejs.

@Siilwyn is this

We can add a npm script that does master pull > soft reset > npm run commit. To make the workflow a bit easier.

I don't quite understand how this is going to work? CI or after merging?

from nodejs.

@hisabimbola let me try to explain by example:

1. Open PR with some commits
2. CI checks PR including the commit message format
3. ...
4. PR ready to merge, only way to merge is rebasing
5. Run npm run pr locally > fill in commit message
6. Force push to PR branch
7. Rebase PR

This way an incorrectly formatted commit message can never make it's way into master.

from nodejs.

There is need to squash some commits, how to that come in if the only way to merge is rebasing.

Also when PR is ready to merge, what will you be committing?

from nodejs.

There is need to squash some commits, how to that come in if the only way to merge is rebasing.

The 'squashing' is done locally.

Also when PR is ready to merge, what will you be committing?

In the end you will commit the commit that was made in step 5.

from nodejs.

With the move away from semantic-release in #352, this issue is no longer relevant

from nodejs.