collijk / chordquality Goto Github PK

In order to make the code more modular, the handling of several kinds of events need to be centralized. Examples would include the playback events triggered by the play, pause, and stop buttons, file i/o, tuning changes, etc. I'm looking at implementing the event aggregator pattern to accomplish this.

The code base is very poorly documented. The classes and methods all need docstrings explaining their purpose, arguments, and return values, if any. Any block of code that is difficult to read should be explained with in-line comments, especially portions with complicated conditional branches or long sections of calculation.

If the transposeFileUpDown is adjusted while a file is being played, some of the played notes are prevented from ending, continuing to play in the background as the track progresses.

Currently only a single soundfont can be selected for a midi file. Ideally we would like to be able to select different fonts/instruments for each track in the file.

The piano roll needs an overhaul. It should "wrap" rather than have a horizontal scroll bar. From what I've read so far in the System.Windows.Forms documentation, I think we should ditch panel2 in the MainForm and create a subclass of System.Windows.Forms.Panel that will initialize as a blank panel when the program starts and handle the subdivision of the the long piano roll into segments and display them when a midi file is loaded.

The MainForm.cs is much too large. The controls at the top can and should be separated into several classes.

When tracks are removed from a playing midi file and added back, the display of the track on the piano roll returns, but the audio does not.

Adjustment of the quality weights sliders changes the display but has no impact on the audio playback.

Upon initiation, the code looks for any files with ​*.tng extension in the directory where the *​.exe file is. If any are found, the information is loaded into the Menu and used to select which tuning (i.e. which of the tng files) to use. This used to work fine, but now as soon as even one *.tng file is present, the program crashes.

The zoomScroll is the vertical scroll bar next to the piano roll. In addition to being an extremely unintuitive UI element, its function is dubious and will be made obsolete by the piano roll reformat.