Generates too many requests and responses for one code review which confuses the developer in selecting work item. Moreover, sometimes it gives error in check in even after the review's approved.

Hi, I installed your policies from Visual Studio Marketplace, for VS2017, from this link:

https://marketplace.visualstudio.com/items?itemName=ColinD.ColinsALMCheckinPoliciesVS2017

However, I can't see it in the list of check-in policies. Here's the path I went:
Team Explorer => Home => (from the top, click on the dropdown) => Settings => (under Team Project) Source Control => Check-in policy tab => Add => your policy name is not there.
My Visual Studio version is Community Edition, version 15.1.

Should I activate it in another way? If so, please add a little documentation for that.

thank you so much

Using VS 2017 Community I cannot modify or add a new source control path to apply a code review policy. The Add and Remove buttons in the dialog are cutoff and when using TAB to highlight Add, the dialog just disappears. Any ideas? Thanks

Hi.
Is it possible to have Changes History somewhere?
I saw that there is a new version of Checkin Policies and I can't find info about what has been changed.
Or I just missed it?
Thanks.

Hi - when using this, there are 4 buttons at the bottom of the ode review Policy settings that can't be seen properly... Visual Studio 2017

Cheers

Warren

The error:
"The extension 'Colin's ALM Checkin Policies for VS 2013 and VSO' requires a version of the .NET Framework that is not installed."
occurs when VS 2015 CTP is installed side by side with VS 2013 (Update 4).

The error is similar to:
madskristensen/WebEssentials2013#1737 and
fsprojects-archive/zzarchive-VisualFSharpPowerTools#929

Looks like this extension sets an explicit dependency on .NET 4.5 which is probably unnecessary. There is an install target version of 12.0 (Visual Studio 2013) which is probably sufficient.
(the fsharp project looks like it follows this approach to fix the issue)

I'll try to fix this and file a pull request.

Policy Doesn't work for the files under immediate folder. for e.g. If I have selected path $/TestProject.
1.) If I am updating any file under $/TestProject policy doesn't enforce me for code review.
2.) It works fine for files under any subfolder i.e. $/TestProject/FolderA

I had installed the checkin policy on VS 2015. Before i did a checkin it asked to submit for a code review. I did submit for a code review to one of my other colleague.. he then went and approved my changes. So the code review is done. I went in and tried to checkin the same file but it still shows that the code review is not yet done.

Hello,
this is in continuation about my previous issue. as you have told i have placed "ColinsALMCheckinPolicies.dll" in C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE but still i get the same error as before.

Please see the screen shots. You can replicate on your local as well.

this is a production issue that we are facing.

Would it be possible to update this fantastic extension so that it is supported in VS 2019?

This issue occurs when the Pending Changes window is not refreshed after a review is completed by a reviewer and a checkin is initiated. The checkin completes, but you'll get a message that says "ID XXXXX. Reason: TF237079: Team Foundation could not update the work item because it was already updated by another user, it does not exist, or you do not have permission to update it."

The ID that it's complaining about is the code review. When this happens, the code review is not associated with the changeset.

This does not happen if the Pending Changes window is refreshed before checking in (after the review is sent back by the reviewer).

A similar problem occurs if you have the "Require Review to be Closed" option turned on. In this case, if the Pending Changes window is kept open while the review is closed, when you try to check in, you get the policy warning failure message. Closing and reopening or refreshing the Pending Changes window resolves this.

Summary:
While adding or editing a Code Review Policy Setting, the default path is $, the Remove button functions properly but when clicking Add button to select a TFS Path to select, the whole Code Review Policy Settings window closes without saving or prompting to choose a path. The net result at the end is the user's inability to change the path's that the check-in policy applies to.

Expected:
Clicking the Add button would result in showing the TFS path selector dialog, once path selected the 'Paths to apply policy to:' list box would be updated with the selected path.

Actual:
Clicking the Add button closes the Code Review Policy Settings window without saving or prompting for TFS Path.

Extra Details:
Plugin Version: 3.15
Visual Studio Version: 15.2 (26430.14) & 15.5.7
TFS Server Version: 2013

Hello,
The issue i see is that if there are multiple code review request submitted on the same file.. for eg:- developer has submitted code review on a class file and the first code review is being done by the approver. Then the same developer submitted code review on the same class file and submitted again for code review. In the first case the code review submitted has been "Needs Work" and in the second case Code review response is "looks good" now the developer has to make changes to the first code review and the second code review is now approved. The developer wants to checkin the changes that are "looks good" but when i try to checkin the checkin policy fails saying the code review conditions are not met. which is weird. I have to remove the work items that are failed and associate with the code review response that has been passed. Do you have any solution for this problem.

We are having an urgent issue. We have implemented checkin policy. The issue is when the developer is trying to check in using TF.exe and argument "Checkin". It always gives this error below in the screen shot

We have excluded the folder path and it works fine using team explorer.
But when the developer is trying to checkin using TF.exe all of a sudden it creates an issue shown in the screen shot below. we are using visual studio 2015 update 3.

you can easily replicate the issue. This is causing issues. can you try to provide a solution.

C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\TF.exe checkin

you can "cheat" the policy by associating a check-in with an existing "good" code review from an older changeset

Hello Colin, I'm trying to translate this policy to French and I can't seem to get the hang of it. I just have no idea what strings the validation is looking for in a system other then english in it's validation.

Thank you

Benoit Audet

There are several reasons to decline checkin such as

• code review not closed
• There are "Needs Work"s in reviews
• There is no code review
• code review was abandoned

We can show more details to guide users to solve the problems.

Hi,
I (Project admin) have installed this plugin in my local machine (VS2017) and later I uninstalled it, but all of my team members getting the warning message "Internal error in Code Review policy, Error loading the code review policy (this policy assembly 'colinsALMCheckinPolicies.CodeReviewPolicy, Version=1.0.0.0, Culture=Neutral, PubliccKeyToken=null' is not registered.).Installation instructions: Install the extension 'colin's ALM Checkin Policies VS 2015 and VSO' from https://visualstudiogallery.msdn.microsoft.com/045730ee-63c0-498e-b972-42b05a2d0857' to get the missing policies.
Could you please tell me the resolution for this?

Thank you in advance

In our TFS setup, once a reviewer uses "Send & Finish" to complete their review with a "Needs Work", nothing can be done by either the requestor or reviewer that will allow that "Send & Finish" response to be altered, and the review then prevents check-in unless an override is done. An added option to the check-in policy to ignore Abandoned reviews would allow the Requestor to close the Review as "Abandoned", and then make changes and request a new Review.

I am still facing the issue #11 "CheckinPolicy - bottom 4 buttons hidden",
I am using VS 2017 community v. 15.5.2. and install the extension with the version 3.15
I am also unable to resize the height of the windows

I also tries to get the latest DLL version of the 'Microsoft.TeamFoundation.VersionControl.Common' and it is 15.111.26008.0 but this DLL'Microsoft.TeamFoundation.VersionControl.Controls.Common' has the version # 14.102.25619.0

Reproduces (TFS2018 and Vs2015):

• create a code change and do checkin pending changes (set comment)
• start code review (add reviewer, the review is named after the comment)
• again do a checkin pending changes (and wait for the review to finish);
  (notice that the review id is shown as related item here)
• after the review is finished (looks good)
• checkin the file(s)
• the files are checked in BUT THE ASSOCIATED ITEM / REVIEW ID IS LOST
  the errors shown now, see below (screenshot and the text as shown in the VS2015 output window)
  (note that a workaround can be to (remove and) re-enter the review id after is has been finished)

](url)
ID 733916. Reason: TF237079: Team Foundation could not update the work item because it was already updated by another user, it does not exist, or you do not have permission to update it.
Failed to update the following work item: