Comments (1)
Hey @coparks2012 - thanks for poring through the code. You're right that it's weird that we don't shuffle the data and that it might cause training instability based on the ordering of the dataset. However, I can tell you that the MPNN code was adapted from the legacy chemprop
code and there were quite a few odd design choices in there. When I wrote this, my goal was to simply interface the two codebases with as little changes to chemprop
as possible. Of course, it resulted in instances like this, but it seems to work fairly well across a variety of tasks. If we were to change it, we'd have to redo a bunch of the original studies to assess the impact (positive, negative, or neutral) of shuffling on overall optimization performance, and that's just something I've never gotten around to.
from molpal.
Related Issues (20)
- MPN model error HOT 3
- unable to reproduce results HOT 5
- Bug in explorer HOT 14
- Y_pred.npy file HOT 3
- docking for objectives HOT 7
- Fingerprints not generating HOT 3
- bug in fingerprints.py
- test on in-house data, result is bad HOT 5
- can you please provide an example config file that use docking rather than lookup? HOT 1
- molpal crush due to invalid smiles HOT 1
- [QUESTION]: Recommended paramaters for molecule screen HOT 1
- what's your take on random sampling? HOT 1
- [QUESTION]: HOT 6
- how to handle tautomers? HOT 2
- [BUG]: HOT 4
- [QUESTION]: Are docking scores for 2.1 million member HTS Collection (“Enamine HTS”) against 4UNN PBB available? HOT 3
- [BUG]: unable to run molpal in docking objective HOT 1
- [BUG]: Not compatible with the latest Ray/Pytorch-Lightning versions HOT 1
- [QUESTION]: Basic MolPal usage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from molpal.