Code Monkey home page Code Monkey logo

file_tools's Introduction

File Tools

Elgg 3.2 Build Status Scrutinizer Code Quality Latest Stable Version License

Features

  • Folders for users and for groups
  • Group admin can control who can manage folders in a group
  • Completely (forward and backward) compatible with the Folder plugin
  • Order files into folders
  • Drag files onto folders
  • Drag and drop folders to rearange folder structure
  • Delete a folder including subfolders (and optional all files in it)
  • Update folder access on all subfolders (optional including all files)
  • Infinite folder structure (no limitations in length and depth)
  • Breadcrumb on file full view
  • Switching of view type (list/gallery)
  • Take over of default file menu options

file_tools's People

Contributors

beck24 avatar brettp avatar bruno-infotrad avatar daltonstudio avatar facyla avatar jdalsem avatar jeabakker avatar monfero avatar rickterheide avatar wouter0100 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

file_tools's Issues

V 3.0 beta Group's Files link broken

Hello,
with Elgg 2.2.3 when using sidebar's group files link it reloads groups main page, no files are shown
Ie SITE/file/group/567867/all
Plugin disabled all files are there.
Cheers

Description field missing on upload form

The description field is missing on the upload page - to add a description you have to back and edit the file.

Additionally, I assume the major use case for zip uploads is related files - these would benefit from sharing tags. Could it be possible to add tags to zip uploads that get applied to all of the created files?

1.8.18 compatibility

Is this version compatible with Elgg 1.8.18?. I've installed this plugin in a fresh 1.8.18 elgg installation and I can't see the plugin anywhere.

Is this the best place to do this kind of questions?

Featured files?

In the files widget a "show only featured files" option appears, yet featuring files is not an option in this plugin nor in the core files one.

Originally reported here: ColdTrick/widget_manager#35 (comment)

Would be actually a nice feature to have though.

Incompatible with tidypics

I know this isn't necessarily a concern for you, and I'm not sure exactly where the issue lies at the moment, but both plugins use the flash uploader, so whichever the plugin is below the other in the plugin list will work, the other one won't. Tidypics still has a basic uploader so I'm still able to use both, but it really messes up the UI. If the flash uploader gains in popularity and is used in other plugins is this going to be a 'there can only be one' scenario?

[edit] I'm posting this over on tidypics too, as I said, I'm not sure where the issue is at the moment.

WSOD when viewing large folders

reported on the community by Komgrit G. Niyomrath:

I have 3,000+ files in a group. When I use this plugin to browse all files, it shows a blank page. I think It is because your plugin load all files in one page. Can you tell me how to turn on the pagination?

Unable to create file directory

Hi I am using the lastest release of your plugin (3.0). In setting page I allowed Use folder structure.
But my users are not able to create "file folder".
When they click on "file folder" button nothing is done.
I when I check my apache log. nothing is mentioned in my log.
I dont know what i did wrong.

Best regard.

WARNING: Deprecated in 2.3: elgg_view_input() is deprecated in 3.0.0-rc.3 and Elgg 2.3.4

Some warning in server log in dev elgg site with Elgg 2.3.4 and file tools 3.0.0-rc.3, no more warnings.

/mod/file_tools/views/default/forms/file/upload.php:115
/mod/file_tools/views/default/forms/file_tools/upload/zip.php:23
/mod/file_tools/views/default/forms/file_tools/upload/zip.php:30
/mod/file_tools/views/default/forms/file_tools/upload/zip.php:36

Thanks for your work
Jon

Actions shouldn't set access_id to ACCESS_DEFAULT

In actions (at least folder/edit), the default value for access_id is ACCESS_DEFAULT. There is no processing to reassign the real default access value for the user / site. If ACCESS_DEFAULT is used to save an entity, it causes ElggEntity->save() to throw an error.

FR : Allow file thumbnail view in the "Mine" tab as default

"All" tab shows thumbnail view of files even if all files are inside various user folders. It will be not-boring and useful-to-other users who see my tab to see thumbnail view of files - thus they can know whether the files are pdf or doc or image etc - folder view by default gives no such information
Please see picture
folder-file-view

1.9.x supported version please

I am not able to upgrade from 1.8 to 1.9 only because file_tools does not have any 1.9 supported version. This is the only plugin missing from my current set of plugin for 1.9.

FR : Incorporate imgLiquid.js

file/all?list_type=gallery gives a gallery view of the thumbnails of images uploaded but the look gets disproportionate and not very good looking when various thumbnails are of various sizes. This happens when one image is portrait type orientation, another landscape and yet another full square. The Photo plugins crops all thumbnails to nice square keeping the proportion but core Files or File tools do no do this.

In file tools, css changes can be made to look all image thumbnails same and square but the problem is that some images get stretched disproportionally, suppose if they are of portrait type

There is imgLiquid.js https://github.com/karacas/imgLiquid which can give a proportionate square look to all these thumbnails in the file tool gallery view but even after trying for a few days I am unable to incorporate it. I do get the squares but blank squares and no images - when I do Inspect Element from FF I do see the images but there is visibility:hidden added from somewhere. If you have free time please give a look to https://github.com/karacas/imgLiquid and whether this can be successfully added to file tools. It will be very UI friendly and will give a nice, uniform look.

Invalid file upload link on "mine" tab

Specifically on the owner filter of files the upload link is malformed

Site url is: http://localhost/landing/

Should be: http://localhost/landing/file/add/35?folder_guid=0 (and is correct on other filters)
Actually is: http://localhost/landing/landing/landing/file/add/35?folder_guid=0

(note the repetition of 'landing')

I think it has something to do with the ajax loading of the owner file list, as the link seems to render correctly immediately on the page load, then adds the additional directory when the loader view is rendered, and then the second additional directory when the file list is rendered.

No files in the list

Hello,

I experienced a bug. With this plugin actived, I cannot see the list of files...

I have only the loader which turns, turns....and turn again... and nothing appears...

I am using elgg 2.1 and just change the release in the manifest file...

thanks

capture

Elgg3: make zip upload work again

currently tab to get to the page has been disabled

folder structure is not created correctly when extracting a zip... also files do not look good (is there actually a file? or something wrong with simple/mime type)

FR : Improve plugin_settings/file_tools

How many files to show in the listing - this setting changes the number of files in the individual tab but not on the "All tab"

Provide an additional setting to the site super admin to have list view or thumbnail view - any one as default across all tabs
ftoolsfr

images (jpg, png) treated as application type

For some reason file_tools seems to change how elgg 1.8.8 interprets uploaded images (tested with jpg and png). With file_tools enabled, when I upload such an image and then view it, the image itself is not shown, only an application icon and the file name are shown, as if it was a PDF file or something. Of course I can still download the image using the download link, but I'd rather view the image directly, also for embedding within the tinymce text editor. If I subsequently disable file_tools and then try to view the image again, there is no change. So apparently there is something different with the file object when it has been added with file_tools enabled? When uploading an image with file_tools disabled, this doesn't occur, so I'm pretty sure file_tools is the culprit.

I'm using file_tools from right here, downloaded last week, on elgg 1.8.8 on a WAMP config.

Return page should also contain thumbnail of uploaded image when upload is done to other folders

Uploading a file (for example, a jpeg) to the default folder/main folder returns a listing of thumbnails with the thumbnail of the just uploaded file at the top of the list - thus I am visually confirmed that correct image has been uploaded and the upload process has worked correctly. However, when I upload to a folder ( other than the main folder) the page returned does not show that folder's listing which would have been appropriate to visually confirm me. The difference in what is returned just after upload in is not user friendly and should be uniform, I think

Option to disable "did you know" tips?

Somehow I remember this was possible in the past (or maybe with the bookmarks plugin that is based on this one?). Anyways, would be nice if there was an admin setting to disable it to reduce site clutter.
Thanks!

Document what the javascript is doing

I have trouble organizing the javascript into a good structure. I think it might help to document all the stuff that javascript is doing.

These are happening immediately on page load:

  • Fetches and lists content of the current folder
  • Converts the elgg-menu in the sidebar into a jsTree
  • Enables draggable support for the files in the list main content area
  • Enables droppable support for the tree in the sidebar

On user action:

  • Moves a file when dragged into a droppable

Other:

  • Provides support for uploading multiple files (note: broken also on 1.8?)
  • Loads a folder when the hash part of the URL is modified by ...who/what?

Did I miss anything?

When we click the links, the page not upload.

I need to have the line 414 on file file_tools/lib/hooks.php like this to upload the links:
$returnvalue = "file/group/" . $container->getGUID() . "/#" . $entity->getGUID();
The problem is that it does not work with either the sidebar and the breadcrumbs

504 Gatewat timeout

I am getting the above error when uploading a file on only a particular group yet the other groups it is uploading fine.
When I reload the page the file is uploaded but not on the folder I had selected.
Please assist.

Provide admin toggles to enable/disable file delete

This is a much requested plugin but can't use it because it provides a means for members other than the one who uploaded a file and the site admins to delete files. This seems contrary to all other Elgg permission logic I've seen. I suggest adding two toggles to the settings:

  1. Enable/Disable site member file delete
  2. Enable/Disable group member file delete

The first would allow site admins to control whether or not the delete option is available to anyone on the site (Enable is the current permission for this plugin). The second would allow group admins to allow members to delete files within their groups, and needs a second toggle in the Edit group settings. I recommend the default be set as Disable for all toggles so that it conforms to what seems to be standard Elgg permission logic.

update event handler is greedy

https://github.com/ColdTrick/file_tools/blob/master/lib/events.php#L15

The event handler that fires when a file is updated assumes that a file can only be updated via the form. If no folder input is present it will remove all relationships and the file will end up back in the main folder.

eg.

// script having nothing to do with file_tools
$file = get_entity($file_guid);
$file->access_id = $new_access;
$file->save();

The file is no longer in any folders...
I suggest passing 0 as the main folder guid in the form, or the int of an existing folder, but using a default of bool false in the event. That way if it's bool false you can simply ignore the event, if it's an int you can then handle the relationships.

Note: this affects all versions of file_tools

Support Request: manual link for creating a folder

In Elgg 1.9.6 I can get this installed and can get a list of files too. However when trying to create a new folder - nothing happens when the button for that is clicked. Is there any manual link, like an uri .../create-folder or something that can do the creation of a new folder?

Bulk Download broken with subfolders

When using "select all" and "download selected" on folder after a while it just displays white page with this url :'www.mysite.com/file/bulk_download?folder_guids[]=12198&folder_guids[]=12199&folder_guids[]=12200&folder_guids[]=10419&folder_guids[]=12201&folder_guids[]=16244" or sometimes zip would be empty.

Looking in the elggdata/file_tools/zip_temp folder I see file/zip gets created but these large ones gets saved with weird extension ( like: download_gvv1LJ.rDtboB)

When selecting only files and not folders (when there are no subfolders) it works fine and gets saved without strange extension.

PHP Fatal error: Call to a member function isValid() on null

Hi guys, when i upload file and save the upload the description is in html code
(this problem is only with files) and when I edit the file and correct the text of the description in the server it show this error:

PHP Fatal error: Call to a member function isValid() on null in /public_html/mod/file_tools/actions/file/upload.php on line 38, referer: http://my site/file/edit/5398
If I refresh the browser show in the site this error "form is missing __token or __ts fields"

All time work all perfect, but today is the error
Thanks for the work

Cannot save new file extensions

I updated to this latest iteration and can't save new file extensions, the text input returns blank and no files can be uploaded at all (I know this isn't an official release, I've just been keeping current with it).
As a request - can you please a wildcard, or an option to allow all extensions?

It would be appreciated!

Thanks,

  • Matt

Group option always enabled

Hi,
Group option to allow group members to edit group file folders is always visible, even if folders are disabled in plugin setting.
The only workaround i see would be checking plugin setting in plugin start.php so we can decide whether to display or not that option.
I can submit a PR for this if you agree with this patch.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.