The datacentersimulator from coelhudo

Currently, the Data Center abstraction is not strong. The hierarchy is not enforced. It is controlled just by ID (ex.: BladeServer has a reference to Rack ID and Chassis ID). The ideal approach is, in my opinion, have an explicit hierarchy by composition.

DataCenter has Racks. Rack has Chassis. Chassis has servers.

Also, this is going to be useful for presentation in the frontend.

Potentially dangerous use of non-short-circuit logic in simulator.am.ApplicationAM.analysis_GR(Object)

ApplicationAM

ComputeSystem test

Characterize this class.

Potentially dangerous use of non-short-circuit logic in simulator.system.EnterpriseApp.runAcycle()

Remove this and see where it is being used to improve encapsulation

Resource: simulator/src/simulator/physical/BladeServer.java
Location: method changeInternals

The method was done to improve encapsulation. It is part of a series of improvements to make the code testable

Create ComputeSystemAM test

Create test based on coverage result.

Potentially dangerous use of non-short-circuit logic in simulator.am.IteractiveUserAM.analysis_GR(Object)

InteractiveUserAM

Create a class to handle job loading

Currently each *System class and EnterpriseApp has access to a BufferedReader instance. Every time a job is requested the file (that is in memory already) is read again, which can cause exceptions, among other bad things, like file mal formation.

A class designed to handle this can read (and fail as soon as possible) the jobs before the simulation starts.

Potentially dangerous use of non-short-circuit logic in simulator.system.InteractiveSystem.readWL()

InteractiveSystem.java

Implement EnterpriseSystemIT

To make the system easier for modification.

Method simulator.am.InteractiveSystemAM.calcSysUtility() seems to be useless

InteractiveSytemAM

ChassisTest

Characterize this class.

implement EnterpriseJob reader

To make Intergration tests possible.

Loop over a collection of BladeServer everywhere

There are a lot of, readonly mostly, operations over a collection of BladeServer.

A class with static functions to provide filters or accumulators would be welcomed.

Create integration test for BatchJob

This is necessary before any further modification related to #35

Find what this means and rename it

Resource: simulator/src/simulator/am/GeneralAM.java
Location: line 9

Potentially dangerous use of non-short-circuit logic in simulator.ra.ResourceAllocation.resourceProvision(EnterpriseSystem, int)

ResourceAllocation.java

EnterpriseApp test

Characterize this class.

Potentially dangerous use of non-short-circuit logic in simulator.system.InteractiveUser.runAcycle()

InteractiveUser.java

Create ResourceAllocation Test

Characterization based on coverage

Create a prototype of a frontend in JS to see the simulation run

Create just a small prototype to show in the browser what is happening in the simulation. It can be the same result as when it is executed in console.

Potentially dangerous use of non-short-circuit logic in simulator.physical.BladeServer.getPower()

BladeServer.java

Commented lines require xml to work. Remove this dependency.

Resource: simulator/src/simulator/tests/BladeServerTest.java
Location: line 23

Create MHRTest

Characterization based on coverage.

Potentially dangerous use of non-short-circuit logic in simulator.physical.BladeServer.run(BatchJob)

BladeServer.java

BladeServerTest

For characterization and refactoring.

Create package integration tests

Create integration tests packages to separate some tests from the current unit tests.

Update Maven pom.xml file and travis configuration file.

Substitute BladeServer.getReady() == XXX for BladeServer.isXXX()

The purpose of this is make easy to understand bladeserver current status. Nowadays it is necessary to memorize each code (-1 -> Idle, 0 -> Running ... ).

BatchJobTest

Implement tests to characterize BatchJob class. Then it will be possible to finish BladeServerTest.

Potentially dangerous use of non-short-circuit logic in simulator.system.InteractiveUser.readWebJob()

InteractiveUser.java

POD validator

If a field is not set, then the POD will be considered invalid and the app will explode ASAP.

Find what this means and rename it

Resource: simulator/src/simulator/am/GeneralAM.java
Location: line 7

GeneralSystem setSLAviolation(int) / getSlaviolation() / setSLAViolation(SLAViolationType) mixed

Sometimes it is being logged accumulated violation instead of violation type.
I don't know how correct is this, seems coincidence. Need more test.

Test for floating point equality in simulator.system.InteractiveUser.runAcycle()

Bug found during findbugs plugin execution.
There is no test yet to characterize the behavior.

InteractiveUser

Builders build only POD not the instance of each element of the simulator

Today builders are responsible for creating instances of simulator data center elements. Builders are heavily dependent on XML.
To decrease this dependence, builders will only build PODs. Then this PODs will be used to create instances of simulator data center elements.
This will allow integration tests creation without depend on XML files (or streams).

coelhudo / datacentersimulator Goto Github PK

datacentersimulator's People

Contributors

Stargazers

Watchers

datacentersimulator's Issues

Recommend Projects

Recommend Topics

Recommend Org