Astrotomic/laravel-translatable Support about laravel-localized-routes HOT 8 CLOSED

At first glance, your code looks fine...

When you call...

\Route::localizedUrl($lang)

...your end result is...

/en/article/slug-in-english
/pt/artigo/slug-in-english

Right?
Or is artigo not translated either?

I will try to reproduce this in a test.

from laravel-localized-routes.

Hey @ivanvermeyen,

As far as I can see, the problem was with the method localizedUrl.

I googled the problem and found this method that fixed the problem for me in RouteServiceProvider:

Route::macro('currentLocalizedUrl', function ($locale = null, $parameters = null, $absolute = true) {
            $locale = $locale ?? app()->getLocale();
            $parameters = $parameters ?: Route::current()->parameters();
            $currentLocale = app()->getLocale();
            app()->setLocale($locale);
            foreach ($parameters as $attribute => $value) {
                if ($value instanceof Model) {
                    $parameters[$attribute] = $value->getRouteKey();
                }
            }
            app()->setLocale($currentLocale);

            return route(Route::current()->getName(), $parameters, $absolute, $locale);
        });

Let me know what you think :D

from laravel-localized-routes.

That is basically what the included macro should do, but it was expanded to handle unnamed routes and 404 pages, which don't have a Route::current().

Are you running the latest version of this package?

from laravel-localized-routes.

I am! That's why is wierd...

from laravel-localized-routes.

I got the issue myself now, will start debugging it :)

from laravel-localized-routes.

Cool @ivanvermeyen! I'll be waiting :D

from laravel-localized-routes.

Turns out that I have a different problem.
Because I use a route like posts/{id}/{slug?}, the id is using model binding but the slug is not, so it's just a string.
I'll have to fix that...

But with normal routes like posts/{slug} it should just work, as long as you type hint it in the controller.
The slugs are not cached in some way by the other package?

from laravel-localized-routes.

Hi,

Sorry, seems I lost sight of this issue...
Is this issue still relevant?
Closing for now, but feel free to reopen!

from laravel-localized-routes.