Code Monkey home page Code Monkey logo

Comments (5)

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024 1

Hi,

This wasn't possible yet, but I've just added an option to exclude the query string:

Route::localizedUrl($locale = null, $parameters = null, $absolute = true, $keepQuery = true);

I'll tag it in a sec.

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024 1

Query parameters passed to the function (or defaults in your case) were not removed.
Should be fixed now in 2.10.1 👍

from laravel-localized-routes.

cod3rshotout avatar cod3rshotout commented on May 29, 2024

@ivanvermeyen thanks for the update but I still have the parameters .. seems the following line should be updated:

if ($url = $this->generateFromNamedRoute($locale, $parameters, $absolute)) {
    dd($url);
    return empty($query) && $keepQuery ? $url . $urlBuilder->getQueryString() : $url;
}

Essentially $url contains this: https://example.com/it/form-and-function?_config%5Bview%5D=shop%3A%3Alayouts.pages.form-and-function. But should contains only: https://example.com/it/form-and-function, so even specifying keepQuery on true, the parameters are still there.

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024

Did you set $keepQuery to false to not show the query?
If true it will show the query. (which is the default)

from laravel-localized-routes.

cod3rshotout avatar cod3rshotout commented on May 29, 2024

@ivanvermeyen yes, I set it, but as I said generateFromNamedRoute return the url with the query string, so even though $keepQuery is false, I get the parameters. Guess the same parameter should be passed to generateFromNamedRoute

from laravel-localized-routes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.