Code Monkey home page Code Monkey logo

Comments (4)

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024

Thanks for reporting this! 👍

I'll take not to put this in the readme and perhaps review the current middleware feature. Maybe it makes sense to always run the middleware instead of enabling it per route anyway.

from laravel-localized-routes.

dentom avatar dentom commented on May 29, 2024

Thanks for reporting this! 👍

I'll take not to put this in the readme and perhaps review the current middleware feature. Maybe it makes sense to always run the middleware instead of enabling it per route anyway.

Just to be clear, this happens even with 'use_locale_middleware' => true. Your middleware runs, but it runs "too late" for this to work.

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024

Ok, I'm working on a few tweaks to this and another package.

I want to make this package responsible for registering routes only.
OR
Merge this package with my other package that detects and sets the app locale with a middleware.
See: https://github.com/codezero-be/laravel-localizer

The only thing I have to do is make it work nicely with this package.
So I wrote a new "detector" for that. (not online yet)

If I keep them separate, I have to make the configuration play nicely.
I would hate it if I need to define the supported locales multiple times (for each package), so I would somehow like to centralize this.
But...
You can't call config('other_package') in a config file.
You can't put arrays in .env files...

Any thoughts anyone?

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on May 29, 2024

I wrote a test for the route model binding and updated the README. 👍

from laravel-localized-routes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.