codewars / code-grouper Goto Github PK

In SQL, the solutions are grouped in a case sensitive manner, so solutions that are exactly the same besides certain words being capitalized, are not being grouped together. I'm not sure if this is intentional, as I am just starting to learn SQL, and I'm also not sure if this is the right place to make a note of this possible issue, so please let me know if this isn't appropriate. Thank you.

@njohnson7 commented on Mon Jun 12 2017

Array#delete_if mutates the array, while Array#reject returns a new array, so these methods should not be treated as equivalent.

Here is an example:

https://www.codewars.com/kata/reviews/521d8d1a123ebb5a8900008d/groups/5381907ea289d5181e000547

Here are the relevant docs pages:

• https://devdocs.io/ruby~2.4/array#method-i-delete_if
• https://devdocs.io/ruby~2.4/array#method-i-reject

@kazk commented on Mon Jun 12 2017

@njohnson7 thanks for reporting :)

@jhoffner this is Codewars/code-grouper's issue, right? Can you move this there?

code-grouper/lib/code_grouper.rb#L146-L147

Same issue with keep_if and select.
delete_if and reject! is not the same thing either because reject! can return nil when nothing changed.