coderpatros / docker-nginx-waf Goto Github PK

Seeking feedback from anyone who has an opinion on this.

There should be more specific version tags. Particularly for the CRS version. But also NGINX and ModSecurity.

I don't want to end up with a major proliferation of tags. Unless, of course, if there is a need for it.

For example NGINX has two minor versions currently being maintained, 1.16 (stable) and 1.17 (mainline). Are people actually interested in having a 1.16 image maintained?

With ModSecurity I'm thinking I'll just track the current major version. Currently 3.2.0.

With OWASP CRS I was going to create images for all versions since 3.1.1. Currently 3.1.1 and 3.2.0.

At the moment I'm leaning towards just major version NGINX, major version ModSecurity, major/minor/patch version of CRS.

i.e. current tags, at time of posting, would be

1-3-3.1 and 1-3-3.1.1 matching NGINX 1.17.3, ModSecurity 3.0.3 and CRS 3.1.1
1-3-3, 1-3-3.2 and 1-3-3.2.0 matching NGINX 1.17.3, ModSecurity 3.0.3 and CRS 3.2.0

Seems to be an error.

Modsecurity is correctly loaded by no rules are workings.

that's seems to be related to Include /usr/local/owasp-modsecurity-crs/rules/*.conf

Like in this issue owasp-modsecurity/ModSecurity-nginx#39

i don't know why it was working before and now it's broken :(