coder-spirit / flysystem-fallback-adapter Goto Github PK
View Code? Open in Web Editor NEWFlysystem adapter for fallback filesystems
Flysystem adapter for fallback filesystems
First of all; thank you for creating this adapter! It's a great help with transitioning from one storage platform to another.
I would like to make one suggestion though. Currently this is the read() method:
public function read($path)
{
if ($this->mainAdapter->has($path)) {
return $this->mainAdapter->read($path);
}
$result = $this->fallback->read($path);
if (false !== $result && $this->forceCopyOnMain) {
$this->mainAdapter->write($path, $result['contents'], new Config());
}
return $result;
}
Could the first part be changed to:
$result = $this->mainAdapter->read($path);
if (false !== $result) {
return $result;
}
This results in a 50% reduction in API calls for all reads and in the end we don't really care if the main adapter has() the requested object, all we want to know if we can read() it. Same thing goes for most other methods.
Thanks again!
This PR https://github.com/Litipk/flysystem-fallback-adapter/pull/2
created issue, you should revert these changes.
How it was before:
if ($this->mainAdapter->has($path)) {
return $this->mainAdapter->read($path);
}
How it is now:
$result = $this->mainAdapter->read($path);
if (false !== $result) {
return $result;
}
I agree that this changes save some performance. But now, you get warning if file does not exists in system (If errors are not suppressed)
Is it possible?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.