codeinwp / pirate-parrot Goto Github PK

@selul just wanted to start off a conversation for enabling the debug option in the plugin. I'm jotting down some points that come to my head.

1. each plugin should register itself with the PP plugin
2. this registration will help in filtering out logs relevant only to chosen plugins
3. the PP plugin will have a selection screen where the user can choose which plugins the log will be generated for
4. each plugin should log the message along with the type of message
5. each plugin's messages will be stored in a transient for X minutes only if its enabled in #3
6. PP plugin will have an option to export logs into a file (like RN)
7. PP plugin will have an option to show the logs on the console/screen (like RN but loaded through ajax)

Deleting plugin should also delete user - Investigate this to make sure thats what's happening

possibly because it needs email and we don't provide email while registering the user.

If WordPress instance is running on PHP 8 Pirate Parrot plugin doesn't work properly, it can be installed and Parrot can be called to get credentials, however, errors are thrown and it's not possible to debug Feedzy as before:

Currently, there are only errors:

WordPress version: 5.8
PHP Version: 8.0.8

This "delete_account" function doesn't exist: https://github.com/Codeinwp/pirate-parrot/blob/master/pirate-parrot.php#L32

the deactivation hook might also be needed to be removed from the construct

Related: #19

Steps to replicate it:

1. create a WP instance with PHP 8.1
2. install & activate the plugin
3. call parrot in Dashboard -> Tools -> Themeisle Support Parrot
4. try deactivating the plugin

Fatal error:  Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class TI_Parrot does not have a method "delete_account" in /s2-trickyfly/wordpress/wp-includes/class-wp-hook.php:307
Stack trace:
#0 /s2-trickyfly/wordpress/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters()
#1 /s2-trickyfly/wordpress/wp-includes/plugin.php(474): WP_Hook->do_action()
#2 /s2-trickyfly/wordpress/wp-admin/includes/plugin.php(812): do_action()
#3 /s2-trickyfly/wordpress/wp-admin/plugins.php(209): deactivate_plugins()
#4 {main}
  thrown in /s2-trickyfly/wordpress/wp-includes/class-wp-hook.php on line 307

Plugin version 1.4.0