codefordao / contracts Goto Github PK

View Code? Open in Web Editor NEW

613.0 613.0 89.0 568 KB

Solidity smart contracts of CodeforDAO

Solidity 69.83% JavaScript 29.85% Shell 0.32%

contracts cryotos dao evm solidity web3

contracts's People

Contributors

Stargazers

Watchers

Forkers

peiwangdb zhwycsz enixlee qunbotop mengyouhan web3hackers panpanda muraneth isanwenyu timothyshen huwangtao123 kaiix mengshi24 gaodeng hymnfish titaniumyuer nowherekai macengine jtrhb unclejimmy d-lyw ff6k brucexu-eth felixgibson wangyuaqi ffffourwood starcorpceo sonic0214 neal-zhu weizier forum-120 yeewee-cor wolegechu digglife nicholasxjy 2qov3b ilyeong-ai yyyzp king-one betty-zjl h3ar7dump huwentao1 leonard-lei stevenchu1125 mustang2247 bozaigao wdcodecn davidricardowilde kojie2008 tangminjie hssuge civiccoding beasoe combasics grustave eoauef tonyxia2016 crediety facetic 872409 shunkakinoki nf2024 yangzai929 edashaeo gizatu johnstontim shayanoffice myrnadsf stellarealm heyijie1 doramarry mathenye bitcoinlaw jackarmyinus barbock maprob mandidina seeyoucrypto tecsong mafellows shugangyao1 togiter h3xag0nx iqiyue d0ra-1h3-3xpl0ra antletsweed jasonhao518 cristina-gabriela rkmax

contracts's Issues

A Question About Proposal Status Checking in Module.sol

contracts/contracts/core/Module.sol

Lines 201 to 217 in e6d820c

    
               /** 
        
                * @dev Cancel MicroProposal 
        
                * cancel a micro-proposal, It is not possible to cancel a proposal that has already been executed. 
        
                * If the proposal is scheduled by the timelock, call the cancel method of the timelock. 
        
                */ 
        
               function cancel(bytes32 id) public virtual onlyOperator { 
        
                   DataTypes.MicroProposal memory _proposal = _proposals[id]; 
        
                   if (_proposal.status != DataTypes.ProposalStatus.Executed) 
        
                       revert Errors.InvalidProposalStatus(); 
        
                   if (_proposal.status == DataTypes.ProposalStatus.Scheduled) { 
        
                       timelock.cancel(id); 
        
                   } 
        
                   emit ModuleProposalCancelled(address(this), id, _msgSender(), block.timestamp); 
        
                   delete _proposals[id]; 
        
               }

Hi. I wanna ask a question: why you wrote _proposal.status != DataTypes.ProposalStatus.Executed in Line 208? And why is it not written as sth. like _proposal.status == DataTypes.ProposalStatus.Executed?
You've said "It is not possible to cancel a proposal that has already been executed", so does it mean that: though the status has been changed, the proposal might have not been executed? Maybe I got misunderstanding in the underlying mechanisms in blockchain?

Thanks.

can't run any tests when execute npm run test

can't run any tests when execute npm run test and npm run test:coverage is also invalid.

➜  coderfordao git:(main) npm run test

> [email protected] test
> npx hardhat test --network hardhat

Compiled 68 Solidity files successfully


  0 passing (0ms)

npm run test:coverage:

Compiled 68 Solidity files successfully

Network Info
============
> HardhatEVM: v2.9.0
> network:    hardhat



  0 passing (0ms)

-----------------------|----------|----------|----------|----------|----------------|
File                   |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-----------------------|----------|----------|----------|----------|----------------|
 core/                 |        0 |        0 |        0 |        0 |                |
  Governor.sol         |        0 |        0 |        0 |        0 |... 118,127,136 |
  Membership.sol       |        0 |        0 |        0 |        0 |... 273,284,294 |
  Module.sol           |        0 |        0 |        0 |        0 |... 216,226,227 |
  Share.sol            |        0 |        0 |        0 |        0 |... 55,59,67,75 |
  Treasury.sol         |        0 |        0 |        0 |        0 |... 241,242,243 |

Add test suite for foundry?

I've come to really dig Foundry for all purposes testing
Would you mind if i create a test suite to demonstrate its capabilities?
It's really fast. Writing tests in solidity makes you feel like a magician without any context swtiching required

Failed to compile contracts with TypeError: Function needs to specify overridden contract "GovernorVotes"

Failed to run npm run compile on OSX 12.6 with Node.js v16.4.2.

The message says TypeError: Function needs to specify overridden contract "GovernorVotes".

It appears that override(Governor, IGovernor) should be override(GovernorVotes, IGovernor) to pass the compilation according to the message tip.

Detailed Output

➜  contracts git:(main) ✗ npm run compile

> [email protected] compile
> npx hardhat compile

Solidity 0.8.12 is not fully supported yet. You can still use Hardhat, but some features, like stack traces, might not work correctly.

Learn more at https://hardhat.org/hardhat-runner/docs/reference/solidity-support

TypeError: Function needs to specify overridden contract "GovernorVotes".
  --> contracts/core/Governor.sol:69:9:
   |
69 |         override(Governor, IGovernor)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> @openzeppelin/contracts/governance/extensions/GovernorVotes.sol:14:1:
   |
14 | abstract contract GovernorVotes is Governor {
   | ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Invalid contract specified in override list: "Governor".
  --> contracts/core/Governor.sol:69:9:
   |
69 |         override(Governor, IGovernor)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> @openzeppelin/contracts/governance/Governor.sol:26:1:
   |
26 | abstract contract Governor is Context, ERC165, EIP712, IGovernor {
   | ^ (Relevant source part starts here and spans across multiple lines).


Error HH600: Compilation failed

For more info go to https://hardhat.org/HH600 or run Hardhat with --show-stack-traces

codefordao / contracts Goto Github PK

contracts's People

Contributors

Stargazers

Watchers

Forkers

contracts's Issues

A Question About Proposal Status Checking in Module.sol

can't run any tests when execute npm run test

Add test suite for foundry?

Failed to compile contracts with TypeError: Function needs to specify overridden contract "GovernorVotes"

Detailed Output

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/**
	* @dev Cancel MicroProposal
	* cancel a micro-proposal, It is not possible to cancel a proposal that has already been executed.
	* If the proposal is scheduled by the timelock, call the cancel method of the timelock.
	*/
	function cancel(bytes32 id) public virtual onlyOperator {
	DataTypes.MicroProposal memory _proposal = _proposals[id];
	if (_proposal.status != DataTypes.ProposalStatus.Executed)
	revert Errors.InvalidProposalStatus();

	if (_proposal.status == DataTypes.ProposalStatus.Scheduled) {
	timelock.cancel(id);
	}

	emit ModuleProposalCancelled(address(this), id, _msgSender(), block.timestamp);
	delete _proposals[id];
	}