code-sketch / memory-game Goto Github PK

At the start of the game not all the cards are displayed so there is a problem of usability, also the menu is not readable.

1. Destructive assignment in this simple case?

 function resetBoard() {
    [hasFlippedCard, lockBoard] = [false, false];
    [firstCard, secondCard] = [null, null];
  }

Easily replaces with

 function resetBoard() {
    hasFlippedCard =  lockBoard = false;
    firstCard = secondCard = null
  }

2. Shuffle is incorrect

Code flow: shuffle is not uniform

Try to count how often vue turns out on top-left card

Code style

(function shuffle() {
    cards.forEach(card => {
      let ramdomPos = Math.floor(Math.random() * 12);
      card.style.order = ramdomPos;
    });
  })();

let should be replaced with const
12 should be replaced with cards.length
moreover why you use IIFE here? you could simply write

// shuffle elements
cards.forEach(card => {
    const ramdomPos = Math.floor(Math.random() * cards.length); 
    card.style.order = ramdomPos;
});

3. It is a de-facto standard to use brackets in if statements (even in one-liners)

if (lockBoard) {return;}
if (this === firstCard) {return;}

And there are plenty more...

I came across your memory sample project and I think this is really nice work. Ideally I would like to use your code for an educational project for new colleagues but given you have not put any license I don't want to do it. Did you intentionally not include a licence or did you simply forget to use it? @marina-ferreira

Estou seguindo o tutorial e tentando reproduzir o código, porém ao clicar na carta ocorre apenas o efeito de clique, sem o flip e a mudança de imagem. Não está aparecendo nenhuma mensagem de erro então não consigo identificar o que pode estar errado. Gostaria de ajuda caso alguém tenha encontrado o mesmo problema.