Code Monkey home page Code Monkey logo

Comments (5)

cfergeau avatar cfergeau commented on June 14, 2024

I've updated https://github.com/cfergeau/vz/commits/asan with tests which can be used to test the suggested fix in that same branch.

from vz.

cfergeau avatar cfergeau commented on June 14, 2024

See #46 (comment) for CI changes reproducing this problem

from vz.

Code-Hex avatar Code-Hex commented on June 14, 2024

I tried on this branch master...issue-50
However, It's not reproduced now. (But I need o fix a few other points. I will fix it by adding tests #69) So I close this issue.


I have carefully observed the logs here (you reported). I made sure that the trace always contains getUUID. Perhaps #47 has been resolved at the root cause.

https://github.com/cfergeau/vz/actions/runs/3089765099/jobs/4997751402

from vz.

cfergeau avatar cfergeau commented on June 14, 2024

I tried on this branch master...issue-50
However, It's not reproduced now.

I managed to reproduce with current master: https://github.com/cfergeau/vz/actions/runs/3244632281
Changes on top of your issue-50 branch are:

diff --git a/.github/workflows/compile.yml b/.github/workflows/compile.yml
index 5bf85ac..e9b6524 100644
--- a/.github/workflows/compile.yml
+++ b/.github/workflows/compile.yml
@@ -25,6 +25,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
+        - macOS-11
         - macOS-12
         go:
         - 1.17
diff --git a/Makefile b/Makefile
index 94d8f6c..ac214d0 100644
--- a/Makefile
+++ b/Makefile
@@ -4,4 +4,4 @@ fmt:
 
 .PHONY: test
 test:
-       CGO_CFLAGS="-fsanitize=address" CGO_LDFLAGS="-fsanitize=address" CGO_ENABLED=1 go test -exec "go run $(PWD)/cmd/codesign" -count=1 ./...
+       CGO_ENABLED=1 go test -exec "go run $(PWD)/cmd/codesign" -count=1 ./...
diff --git a/check_test.go b/check_test.go
index 2bc6fd2..78385e4 100644
--- a/check_test.go
+++ b/check_test.go
@@ -36,6 +36,8 @@ func TestVM(t *testing.T) {
                t.Fatal("cannot start")
        }
        m.Start(func(err error) {
-               t.Error(err)
+               if err == nil {
+                       t.Fatal("Start() did not return an error")
+               }
        })
 }

I can no longer reproduce with asan enabled, which is odd. Maybe this is caused by some memory corruption.

from vz.

Code-Hex avatar Code-Hex commented on June 14, 2024

I tried to cherry-pick your this commit. but the commit does not exist now.

So I created again as a new PR for this fix. thanks for your report!

#74

from vz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.