Comments (5)
I've updated https://github.com/cfergeau/vz/commits/asan with tests which can be used to test the suggested fix in that same branch.
from vz.
See #46 (comment) for CI changes reproducing this problem
from vz.
I tried on this branch master...issue-50
However, It's not reproduced now. (But I need o fix a few other points. I will fix it by adding tests #69) So I close this issue.
I have carefully observed the logs here (you reported). I made sure that the trace always contains getUUID
. Perhaps #47 has been resolved at the root cause.
https://github.com/cfergeau/vz/actions/runs/3089765099/jobs/4997751402
from vz.
I tried on this branch master...issue-50
However, It's not reproduced now.
I managed to reproduce with current master: https://github.com/cfergeau/vz/actions/runs/3244632281
Changes on top of your issue-50
branch are:
diff --git a/.github/workflows/compile.yml b/.github/workflows/compile.yml
index 5bf85ac..e9b6524 100644
--- a/.github/workflows/compile.yml
+++ b/.github/workflows/compile.yml
@@ -25,6 +25,7 @@ jobs:
fail-fast: false
matrix:
os:
+ - macOS-11
- macOS-12
go:
- 1.17
diff --git a/Makefile b/Makefile
index 94d8f6c..ac214d0 100644
--- a/Makefile
+++ b/Makefile
@@ -4,4 +4,4 @@ fmt:
.PHONY: test
test:
- CGO_CFLAGS="-fsanitize=address" CGO_LDFLAGS="-fsanitize=address" CGO_ENABLED=1 go test -exec "go run $(PWD)/cmd/codesign" -count=1 ./...
+ CGO_ENABLED=1 go test -exec "go run $(PWD)/cmd/codesign" -count=1 ./...
diff --git a/check_test.go b/check_test.go
index 2bc6fd2..78385e4 100644
--- a/check_test.go
+++ b/check_test.go
@@ -36,6 +36,8 @@ func TestVM(t *testing.T) {
t.Fatal("cannot start")
}
m.Start(func(err error) {
- t.Error(err)
+ if err == nil {
+ t.Fatal("Start() did not return an error")
+ }
})
}
I can no longer reproduce with asan enabled, which is odd. Maybe this is caused by some memory corruption.
from vz.
I tried to cherry-pick your this commit. but the commit does not exist now.
So I created again as a new PR for this fix. thanks for your report!
from vz.
Related Issues (20)
- Make easier to check API is available HOT 2
- socket.go could provide a Dial() method HOT 10
- macOS 13 API has been disabled despite being on Ventura with latest Xcode 14.1 HOT 1
- Support for VirtualMachine.networkDevices HOT 9
- panic: runtime/cgo: misuse of an invalid Handle HOT 11
- panic: runtime/cgo: misuse of an invalid Handle on RequestStop and waiting for vm stopped state HOT 18
- Uncaught exception when using EFI bootloader with empty NVRAM file HOT 3
- macOS 14 HOT 2
- Please tell me about the projects that are using this library HOT 5
- Occasional ` runtime/cgo: misuse of an invalid Handle` panic when using vsock HOT 6
- Is it possible to run pre-built MacOS images from Packer? HOT 14
- Add `func (v *VirtioNetworkDeviceConfiguration) GetMACAddress() string`? HOT 1
- Bridged Networking HOT 7
- Seeking Continuous Sponsorship for development HOT 1
- Help: Tests Not Executing on macOS 13 (amd64) HOT 4
- VZNetworkBlockDeviceStorageDeviceAttachment
- VZMacKeyboardConfiguration
- example/gui-linux does not exit when `vm.Stop()` is used
- Vulnerability patch (golang.org/x/crypto/ssh) HOT 1
- gui-linux VZErrorDomain Internal Virtualization error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vz.