panic: runtime/cgo: misuse of an invalid Handle about vz HOT 11 CLOSED

@ryancurrah I've released v3.0.4

from vz.

@ryancurrah Thanks!
I'll investigate it!

from vz.

@Code-Hex
Am still getting cgo panics during stop (sometimes)

INFO[0001] [hostagent] panic:                           
INFO[0001] [hostagent] runtime/cgo: misuse of an invalid Handle 
INFO[0001] [hostagent] goroutine 17 [running, locked to thread]: 
INFO[0001] [hostagent] runtime/cgo.Handle.Value(...)    
INFO[0001] [hostagent]  /usr/local/opt/go/libexec/src/runtime/cgo/handle.go:124 
INFO[0001] [hostagent] github.com/Code-Hex/vz/v3.changeStateOnObserver(0x0, 0xc000006601?) 
INFO[0001] [hostagent]  /Users/balaji/go/pkg/mod/github.com/!code-!hex/vz/[email protected]/virtualization.go: 

from vz.

OK, I can make a reproduction! Thanks.
90ae4df

from vz.

Nice! I just opened my laptop to see if I could try as well.

from vz.

mmm, minimal reproduction seems hard...

from vz.

I can try to reproduce as well.

How are you doing it?

from vz.

I'm trying to make a minimal reproduction like below in issues_test.go
But haven't done yet :(

func TestIssue119(t *testing.T) {
	container := newVirtualizationMachine(t,
		func(vmc *vz.VirtualMachineConfiguration) error {
			return setupConsoleConfig(vmc)
		},
	)

	sshSession := container.NewSession(t)
	defer sshSession.Close()

	vm := container.VirtualMachine

	if got := vm.State(); vz.VirtualMachineStateRunning != got {
		container.Close()
		t.Fatalf("want state %v but got %v", vz.VirtualMachineStateRunning, got)
	}

	done := make(chan struct{})
	go func() {
		defer close(done)

		for {
			select {
			case newState := <-vm.StateChangedNotify():
				if newState == vz.VirtualMachineStateStopped {
					return
				}
			}
		}
	}()

	sshSession.Run("poweroff")

	for i := 0; i < 10; i++ {
		runtime.GC()
		time.Sleep(time.Second)
	}

	<-done
}

from vz.

@ryancurrah Oops, if you look closely at your stack trace, you see an error in changeStateOnObserver.
My reproduction code was wrong because caused an error in StateChangedNotify.

Maybe, the reason is happened Go's VirtualMachine struct has been destructured but Objective-C VZVirtualMachine object has not been destructured.

Re-create the reproduction code 😢

from vz.

It could be reproduced 7d2aa2f

from vz.

@Code-Hex you're the best. Thank you!

from vz.