cmuchimpslab / playstore-scraper Goto Github PK

Scraping for details using the package names on the scraper-server is returning an error with the following message:
Cannot read property 'replace' of undefined

I noticed that

1. when starting the server, it actually takes a little time to start up, so doing
   'proc = server_helper.start_scraper_server()' and then immediately executing commands using the server causes the first set of commands to fail as the server is still starting. I managed to do a simple fix by adding a pause of .5-1 sec in start_scraper_server, not sure if there is a more exact method of waiting until the server starts.

2. Perhaps the larger problem I noticed is even after running stop_scraper_server, the server still persists on my machine and I can only stop it through the system monitor. Not sure how to fix or why the server does not stop (stop_scraper_server is running correctly as it logs the messages "Shutting down scraper server" and "Server shut down completed with code -15", not sure if -15 is an error code). An EXTREMELY hacky way to fix is by executing command line commands to kill the 'node' process. I believe it is terminating the wrong process right now (i.e. doing npm start spawns another process, npm start is being terminated but not the other process so the server persists).

Like I mentioned the fix for 1 can be pretty simple but not exact, and I don't really know a clean way to fix 2.