cmcginty / flacsync Goto Github PK

I just renamed the folders I had with those characters because I didn't know how to solve it, but I think this problem should be addressed in a future. It constantly failed to parse wave file when they where within a folder with the character $.

Found bug in encoder.py, class p3Encoder, method set_cover. Variable err was not initialize outside of the if statement but tested outside of the if block. Added line 379 err='' just before the if statement.

Could this be implemented? I have a lot of high-rez stuff in my library. I would resample 88.2 kHz and 176.4 kHz stuff to 44.1 kHz, and 96 kHz and 192 kHz stuff to 48 kHz. Yeah, lame makes stuff that is > 48 kHz into 48 kHz, but a lot of people would rather do even division.

For AAC files and maybe other in the Android music player. When a file is tagged with a disc num field, it break tag parsing in the app.

Should be fixed in Android, but might need a work around until that happens.

If you have faulty FLAC files (as I unfortunately have), flacsync simply stops in the middle of the file, and leaves a partial aac file. flacsync should either not create an aac file or try to decode the entire file if possible (using -F).

e.g., for a 10:00 flac file with an error 2 minutes inside the file, you get a 2 minute aac file.

adding -F looks like the easiest solution (and the best in many cases). This can be done by adding -F in encoder.py approx line 131:

    # encode to AAC                                                                                                                                                                                
     err = sp.call( 'flac -d "%s" -c -s -F | neroAacEnc -q %s -if - -of "%s"' %
       (self.src, self.q, self.dst), shell=True, stderr=NULL)

Cheers,

Jens

I discovered Easytag creates duplicate tag names for some fields. For example if you have multiple ARTISTS, it will create as many ARTIST tags as necessary. Flacsync does not account for this behavior, and will improperly write out the AAC tag.