cloudposse / terraform-github-repository-webhooks Goto Github PK

Found a bug? Maybe our Slack Community can help.

Describe the Bug

The Terraform Github provider was updated to remove the anonymous access flag. This was unfortunately done in a minor release. The current pessimistic constraint of ~> 2.2 fails, as the change appeared after 2.8.1 in 2.9.0.

See this change.

Expected Behavior

The module would continue to cleanly apply with the given constraint.

Steps to Reproduce

Steps to reproduce the behavior:
An example can be seen in this PR.

Screenshots

N/A

Environment (please complete the following information):

Terraform version: 0.12.24
Github Provider version: 2.9.0

Additional Context

It can probably be fixed by setting the constraint to ~> 2.8.0 or >= 2.2, <2.9. Another potential fix is to adapt the module to use the newer provider, assuming there is equivalent functionality to the anonymous access now.

Upstream issue here, though I suspect that will result in just a clarification, and perhaps CHANGELOG change.

what

• application/json is an incorrect default value to use for the webhook_content_type variable

why

• The only supported values for content_type in the github api are json & form
  https://developer.github.com/v3/repos/hooks/#parameters
  

what

• webhook_url is wrong variable and should be github_webhook_url

why

• #2 fixed this but the change was lost

Found a bug? Maybe our Slack Community can help.

Describe the Bug

Running a module (which uses this one) with Terraform 1.2.0 an error is thrown:

╷
│ Error: Module is incompatible with count, for_each, and depends_on
│ 
│   on database.tf line 90, in module "rds_postgres_serverless":
│   90:     aws_route53_zone.private
│ 
│ The module at module.api.module.ecs_codepipeline.module.github_webhooks is
│ a legacy module which contains its own local provider configurations, and
│ so calls to it may not use the count, for_each, or depends_on arguments.
│ 
│ If you also control the module
│ "registry.terraform.io/cloudposse/repository-webhooks/github", consider
│ updating this module to instead expect provider configurations to be passed
│ by its caller.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• chore(deps): update terraform github to v3.1.0
• chore(deps): update terraform github to v5

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository