[Bug]: Cache misses because of wrong assumptions in the ordering of hashmap keys about joint HOT 4 CLOSED

The problem with this approach is that hashmap keys don't have a guaranteed order, which means that this code is most probably missing the textHash / cache most often than not.

The order is indeed not guaranteed.

In my experience, browsers return the same string for the same object instance (and for objects whose properties were created in the same order - which is JointJS case).

So even though in theory there are inaccuracies, in practice it works well enough. This caching should prevent the same text from being rendered on every update. And I do believe it does.

Do you have any example where the cache is missed?

from joint.

Looking at the code, it would be relatively easy to store the text attributes one by one in a variable instead of using the util.pick method. I'm just trying to guess how critical this problem is.

from joint.

Hey! It's not critical at all. In fact, worst case scenario the cache will be missed and the text will be rerendered. I can't create a demo that will reproduce the bug. It did happened to me a couple of times (in the span of a week), but it's very random.

from joint.

Fixed in #2333.

from joint.