Code Monkey home page Code Monkey logo

clerk-prestashop's Issues

Module compatibillity with Prestashop 9

Just a friendly heads up/reminder that Prestashop 9 is in the works with an expected release date in Q1 of 2024.

Please be a head of developing process by installing Prestashop 9 (allready downloadable) and make the necessary adjustments in the Clerk.io module so the webshops can be updated short after the release of Prestashop 9.

Just to prevent a development disadvantage of 1 year like the compatibillity with Prestashop 8.

Recomended Product Missing in Category Page

Good evening,
I have downloaded the module using the github repository and installed the zip on my prestashop... The version is 6.6.1 not officially released.
I noticed that after updating the module from 6.6.0 to 6.6.1 on category pages were missing recomanded products "Best in this category".
If i revert the module to 6.6.0 recomanded products in category page are present.

Thank you

Product Features missing

Good evening,
I have installed on my prestashop 1.7.8.6 last version of your module 6.6.0
I need to include all product feature for boost some products and I have enabled in the module configuration the option "Include Product Features"
After the full sync with clerk.io seems that no features is included.

I tried to disable "Include Product Features" and start a new sync with clerk.io and all feature are present but time by time almost every product lose all the prestashop features previously included. If i restart the sync manually all features are coming back on clerk.io but after some time features are not present again..

Can you check if this functionality is fully working in 6.6.0 and not bugged?
Thank you

Issue with php versions

The code is not working on php 5.4

change
$this->shop_id = (! empty(Tools::getValue('clerk_shop_select'))) ? (int)Tools::getValue('clerk_shop_select') : $this->context->shop->id;

to
$this->shop_id = Tools::getIsset('clerk_shop_select') ? (int)Tools::getValue('clerk_shop_select') : $this->context->shop->id;

$this->language_id = (! empty(Tools::getValue('clerk_language_select'))) ? (int)Tools::getValue('clerk_language_select') : $this->context->language->id;

to
$this->language_id = Tools::getIsset('clerk_language_select') ? (int)Tools::getValue('clerk_language_select') : $this->context->language->id;

And

if (! empty(Tools::getValue('ignore_changes'))) {
return true;
}

to
if (Tools::getIsset('ignore_changes')) {
return true;
}

Module compatibility with Prestashop 8

Module ins't compatible with Prestashop 8.X.

Module is using Attribute class instead of ProductAttribute.
Since php 8 Attribute is reserved word. To make this module compatible with Prestashop 8.X this code have to adjusted with backwards compatibility for Prestashop < 8.

Curly braces - Unsupported

ERROR 2022/10/25 - 09:28:33: Array and string offset access syntax with curly braces is no longer supported at line 124 in file modules/clerk/controllers/admin/Clerk-Api.php

PHP8

Clerk.io module causing js-errors in frontend of PS 1.7.7.2

I get errors like:

Uncaught TypeError: $(...).staccordion is not a function
    at HTMLDocument.<anonymous> (theme.js:436)
    at c (core.js:39)
    at d (core.js:39)

..causing other functions in the PS frontend to stop.
Deactivating the module stops the errors.

Stack Owerflow answers is suggesting jQuery being loaded more than once can cause such errors.

Aggiungere all'elenco dei dati del prodotto il link alla pagina del Brand

Aggiungere all'elenco dei dati del prodotto il link alla pagina del Brand.

Piccolo esempio:

private static function getLinkBrand($language_id, $product_id, $context){

	$product = new Product($product_id, $language_id);
		
	$manufacturer = new Manufacturer($product->id_manufacturer,$language_id);
	
    return $context->link->getManufacturerLink($manufacturer->id);        
}

Loop async call to file .log in backoffice configuration page

Hi,

Describe the bug

Loop problem with url '/modules/clerk/clerk_log.log' in back-office configuration page.
The problem persists if file not exist and if it exists (with log active and access set to 'file').

Expected behavior

Do not call clerk_log.log file in loop

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to back-office configuration page of your module (like: /index.php?controller=AdminModules&configure=clerk...)
  2. Set debug log active
  3. Set access to 'file' setting and level to 'error'
  4. reload back-office page
  5. open console network and see over load calls

Screenshots

Schermata 2020-10-07 alle 12 23 34

Schermata 2020-10-07 alle 12 27 38

Additional information

  • PrestaShop version: 1.7.6.4
  • PHP version: 7.2.22

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.