clemens-e / better-airhorn Goto Github PK

It was quite a pain to find any command for the bot. even the $help command was hard to find.
There should be a simple solution to access the help for any user.

my idea:

• use the status text of the bot to display the $help command,
• send an text with rudimentary instruction to the user if he messages the bot with any message containing the string "help".

You mention using 'mode zero' to download the audio rather than uploading it. What command exactly is that?
I tried:
$mode 0
$mode zero
$mode0
$modezero
It helps for your readme to be as specific as possible with commands. Thank you for your bot!

as it is:

1. $help
2. bot displays page 1 of help with <1 and >1
3. i click >1
4. help page 2 (music) is displayed with <1 and >2
5. to reach the next page i've to click >2 twice (1st to remove one reaction, then another time to reach the next page

what it should be:

1. $help
2. bot displays page 1 of help with <1 and >1
3. i click >1
4. help page 2 (music) is displayed with <1 and >2
5. bot removes my reaction, so that <1 and >1 is displayed
6. next or previous page can be reached by clicking just once

how it is:
whenever someone uses the $play command, the bot joins a channel, plays the selected file and leaves the channel thereafter.
this is quite the annoying behavior, because, everyone gets the "someone joined the channel" notification sound from discord, then the played sound, and then the "someone left the channel" notification sound.

how it should be:
there should be an option (like $join and $leave commands) to let the bot linger in the voice channel, so that the Sounds can be played without the join and leave notification sounds from discord.

how it is:
The $help command doesn't contain information about uploading sound files.

how it should be:
there should be information in the $help command how to upload sound files.

how it is:

1. $play <something i don't have the rights to play>
2. bot joins voice
3. bot leaves voice
4. bot gives error message "Misssing permission to this audio"

How it should be:

1. $play <something i don't have the rights to play>
2. bot gives error message "Misssing permission to this audio"

In the code snippet above, the play command already has a voice connection created by message.ts, so any play command will always connect to the voice chat first. Then the permission checking happens in the switch (cmd.privacymode) and will fail if the user does not have permission to play the requested audio clip and return the reject message. This means the voice.disconnect() is not being invoked in the instance where you do not have permissions to play an audio clip and the bot is left stuck in the voice channel.

My recommendation is to either modify the reject() function to always attempt a voice.disconnect() before returning, or to modify the switch (cmd.privacymode) to call voice.disconnect() before returning reject.