Comments (3)
Thanks for the suggestions. In the future let's stick to referring to chapters by name rather than number, since the numbering is more ephemeral (indeed, the preface should really be front matter so all the chapter numbers will be reduced by one).
Sec 11.1, 4th paragraph: State explicitly what are R and \Lambda. Or at least cite Chapter 4, where we first introduce this diagonalization.
I added the phrase "eigenvalue decomposition" before this is introduced.
Sec 11.1, end: Should we cite notebooks not in printed version of the book like acoustics in heterogeneous media?
I think not; that notebook hasn't been updated for quite some time. I removed the italicized comment to ourselves.
Before Sec 11.2 and Sec 11.3: maybe add a small paragraph saying that most approximate (if not all) Riemann solvers fall within two categories: linearized Riemann solvers and two (or more) wave solvers.
Depending on your definition of "two or more wave solvers", this claim is either trivially true or (in my opinion) not true. We can discuss it further if you disagree.
Sec 11.3: Mention that in some special cases additional waves can be added to the two-wave solvers (as is the case with the HLLC)
I think that would be fine, especially if you want to add HLLC to the book.
Chapter 12
I'm hesitant to spend more time on the HLL solver here since I'm pretty sure nobody has ever actually used a two-wave solver for Burgers, and it seems a bit foolish to do so for a scalar equation. Showing the exact solution and the Roe solution would be nice for the transonic rarefaction case (in the case of a shock I think all three will be indistinguishable). Please go ahead and add it.
Sec 13.1.1, first paragraph: Maybe say explicitly that the averages must be chose to satisfy Property 3.
I don't understand. Doesn't it say that already?
Sec 13.1.2, after first code section and before examples: Add subsection for Roe solver examples and maybe a brief description before each example.
Sec 13.2.2 examples, Same as before, maybe add a brief desription before each example: Dam-break, isolated 2-shock, transonic rarefaction
Good ideas; done.
The interact from the last two code cells in the notebook doesn't work.
It works for me. I'm happy to help you debug.
Second paragraph: When mentioning the Energy is given by the relation 14.4, maybe also add the ideal gas equation of state for reference.
Good idea.
Sec 14.1, first paragraph. Reference as in Chapter not working in pdf. Maybe this is already fixed in latest version of make_pdf.
Should be fixed now.
Sec 14.2 HLLE Solver: Many parts uses HLL instead of HLLE. I know it is basically the same, but maybe somewhat confusing to have the two acronyms. Maybe change all to HLLE since we are using the HLLE choice of wave speed.
Good catch. I changed it to HLLE almost everywhere. Left one instance that I think should remain as HLL.
Maybe add the HLLC/HLLEC solver as an example of a three wave HLL solver. I am happy to do this.
That would be great!
adding a tab to choose density/momentum or energy in the interacts of Chapter 15
That would also be great.
I've implemented most of your suggestions in #202. Thanks again.
from riemann_book.
@ketch Thank you for going over these. The interacts in the end of shallow_water approximate were not working because I needed to update clawpack, so it is all good now. On my side I will work on the following then:
- Add an interact with the exact solution and the Roe solution for the transonic rarefaction case in
Burgers_approximate
. - Add an HLLC solver in
Euler_approximate
and mention 3 wave cases might come up in Sec 11.3. - Add a tab o choose density/momentum or energy to interacts in
Euler_comparisons
.
from riemann_book.
That sounds great.
from riemann_book.
Related Issues (20)
- Error pops up in plot_riemann for Traffic
- Try out `nbinteract` HOT 5
- Use of red and blue colors in shallow water plots HOT 1
- Spacing before equations
- Characteristics incorrectly terminate in SW section 1.4.5 HOT 1
- Eq. in acoustics NB HOT 2
- Euler compare suggestions HOT 1
- Burgers interact HOT 2
- Burgers chapter HOT 9
- Things to do in multiple notebooks
- Second equation of subsection 9.1.3 HOT 2
- make_pdf.py cannot find riemann.tex HOT 6
- nbconvert --to html doesn't handle equation numbers HOT 1
- Create pdf in build_pdf directory? HOT 1
- Azure Notebooks issues HOT 1
- kitchen sink animations not working on Azure HOT 9
- Code lines in the PDF go past the right edge of the page HOT 1
- Polishing chapters for the submission
- Tammann notebook issues HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riemann_book.