Comments (9)
Regarding the comments in Burgers'.
- The explanation in “Rarefaction wave” section doesn’t seem to make sense without talking about smoothing out the IC. Since no initial point takes values between q_l and q_r, where do those values in the later solution come from?
Not sure what you want to add here. Are you thinking of moving the self-similarity solution explanation in the Traffic_flow notebook into Burgers? We can do that.
-In the section "Weak solutions": I don't understand what is meant by saying "We can generalize this result." What result?
Minor wording, fixed.
In the same section: without saying more about the support of \phi, I don’t think the integration by parts makes sense. Why do we get a boundary term at t=0 and not at the other boundaries?
Compact support imples vanishing at infinity, so no problem here. Changed text to make that clear.
What does “any form of the integral conservation law” mean?
Minor wording, fixed.
The sentence starting “Note this rules out the interval…” doesn’t make sense to me.
Minor wording, fixed.
Figure captions should say “x-t plane” rather than “xt-plane”. But maybe it would be better to change them simply to “characteristics”.
Now they say characteristics.
I pushed a pulled request to more_editing_dk, with these minor changes.
from riemann_book.
Thanks, @maojrs. Some comments:
Not sure what you want to add here. Are you thinking of moving the self-similarity solution explanation in th
e Traffic_flow notebook into Burgers? We can do that.
I don't have a fix. My preference would be to change the order back (Traffic chapter first); then this explanation is unneeded.
Compact support imples vanishing at infinity, so no problem here. Changed text to make that clear.
It's still unclear why there is a boundary term at t=0.
The sentence starting “Note this rules out the interval…” doesn’t make sense to me.
Minor wording, fixed.
This still doesn't quite make sense to me (I know more or less what you're trying to say, but the sentence is unclear).
from riemann_book.
I don't have a fix. My preference would be to change the order back (Traffic chapter first); then this explanation is unneeded.
Well, then this is not about the Burgers' notebook, but about the order of the chapters. If we decide to keep the current order, then we need to decide if anything needs to be changed in Burgers' or if it is enough to introduce the basic concepts in Burgers' and leave more detailed explanations for later. I thought we chose the latter one, but we can talk again about it again.
It's still unclear why there is a boundary term at t=0.
More explanation added.
This still doesn't quite make sense to me (I know more or less what you're trying to say, but the sentence is unclear).
Tried different wording. If it still doesn't quite makes sense to you, feel free to change it.
Latest changes should already be in the pull request.
from riemann_book.
@maojrs Remember that I was opposed to changing the order of those chapters. We spent a great deal of time polishing the traffic chapter to be the introduction to nonlinear conservation laws, while the Burgers chapter (which didn't exist at all in the original outline of the book) has undergone much less revision.
Anyway, if @rjleveque feels that the explanation of the centered rarefaction is good enough then I am willing to leave it as is.
from riemann_book.
Sorry if I complicated things moving the chapters around and then apparently not beefing up the Burgers' chapter enough. I'll take another look at this today. Regardless of order it might be good if both can somewhat stand on their own, since readers coming into the notebooks probably will not do them all in linear order. Some will be attracted first to traffic flow while others might go straight to Burgers', particularly if they are using the notebooks to complement reading some text (or taking a class) where traffic flow isn't mentioned, and Burgers' is what they are trying to understand.
from riemann_book.
Ok, then I will also make another pass to Burgers' to see if anything should be improved. I am also happy to incorporate any concrete suggestions/improvements both of you might have.
@ketch Maybe we can merge the 'more_editing_dk' branch (including my latest pull request), so we do the changes in the latest version. However, there seems to be a problem with the Travis test.
from riemann_book.
Okay, I merged my PR. The test failures are fixed in
except for a lingering issue that I mentioned there and that I hope @rjleveque can tackle.
from riemann_book.
Great, thanks!
from riemann_book.
Issues addressed in pull request #194, so I am closing this one.
from riemann_book.
Related Issues (20)
- Error pops up in plot_riemann for Traffic
- Try out `nbinteract` HOT 5
- Use of red and blue colors in shallow water plots HOT 1
- Spacing before equations
- Characteristics incorrectly terminate in SW section 1.4.5 HOT 1
- Eq. in acoustics NB HOT 2
- Euler compare suggestions HOT 1
- Burgers interact HOT 2
- Things to do in multiple notebooks
- Comments and suggestions for Part II HOT 3
- Second equation of subsection 9.1.3 HOT 2
- make_pdf.py cannot find riemann.tex HOT 6
- nbconvert --to html doesn't handle equation numbers HOT 1
- Create pdf in build_pdf directory? HOT 1
- Azure Notebooks issues HOT 1
- kitchen sink animations not working on Azure HOT 9
- Code lines in the PDF go past the right edge of the page HOT 1
- Polishing chapters for the submission
- Tammann notebook issues HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riemann_book.