Code Monkey home page Code Monkey logo

flarum-ext-emojionearea's Introduction

EmojiOne Area for Flarum

GitHub license Packagist Packagist Donate

Screenshot of the editor Screenshot of the settings

This extension adds the EmojiOne Area emoji picker to Flarum.

Please note that, as the name suggests, the emoji list and images used in this library are EmojiOne, which was previously used by Flarum until beta 7.

However Flarum now switched to Twemoji, which means the images shown in the picker and those inserted in the post will be (slightly or radically) different.

The picker is dynamically loaded from jsDelivr CDN when opened, which means this extension has virtually no impact on performance until the user interacts with the picker.

Installation

composer require clarkwinkelmann/flarum-ext-emojionearea

Support

This extension is under minimal maintenance.

It was developed for a client and released as open-source for the benefit of the community. I might publish simple bugfixes or compatibility updates for free.

You can contact me to sponsor additional features or updates.

Support is offered on a "best effort" basis through the Flarum community thread.

Sponsors: ctml

Links

flarum-ext-emojionearea's People

Contributors

clarkwinkelmann avatar matteocontrini avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

flarum-ext-emojionearea's Issues

EmojiOne Area pulls libraries from cdnjs.cloudflare.com

This is probably due to the default configuration of the library.

It fetches images at cdnjs.cloudflare.com whereas the base emoji plugin fetches them at cdn.jsdelivr.net.

It also load additional css and js files from cdnjs.cloudflare.com. These files are probably already included in the core and should not be fetched again.

data: image cause CSP header issues

The EmojiOne Area plugin uses a data: image in the CSS for the default button.

In my extension this default icon is hidden and another is used with the core icon() helper.

But the image is still in the CSS and still triggers CSP error if data: is not allowed by the img-src rule. It does not prevent the use of the plugin, but it will spam the CSP report URI if enabled.

It might be a good idea to extract the useful parts of the CSS into extension.less and not import all the original rules.

Quote never work in Firefox if some Emoji are present

I received a report that in Firefox if a text with Emoji in the middle is select than is used "quote" the text after the smiles are not quoted.

I tested this in Firefox stable and developers and the issue is present.
Is not present in Chrome based browser.

I was thinking to report this bug to the WebCompat but there is no demo about this that they can test for reproduce the issue.

Also I tried to reproduce the issue with "normal Emoji means with no extension" and I was unable to reproduce the issue on Firefox. So the issue is the Firefox browser or the extension? How can we report the bug if is a browser bug?

https://www.screencast.com/t/usihW1Pyr0kZ
https://www.screencast.com/t/eEQUbZvL

Features not available in emojionearea

Things that have been asked and are not (yet) available in the emojionearea plugin.
I'll take these ideas into account if I create my own popup in the future.

  • Ability to search emojis
  • Be aware of left/right borders and not go out of screen (linked with next one)
  • Change number of emojis per row request, request

Davis' Code Review

Bundled translations maintenance status

What is the status of translations provided in https://github.com/clarkwinkelmann/flarum-ext-emojionearea/tree/master/locale? I'm trying to cleanup redundant translations from Weblate - if translation for given language is already bundled with extension, there is no sense to have it duplicated in Weblate. But this is true only for actively maintained translations, which usually means only translations maintained by extension author. For example if extension author knows Italian, he can provide en and it translations, while the rest should probably be handled inside of respective language packs. So now I'm trying to figure out which translations are available because of extension author knows this language and will be able to maintain them, and which are just leftovers from old days where translations were contributed by community to extensions instead of language packs (in that case translations may become outdated after some times, since nobody will update them).

So how does it looks like for https://github.com/clarkwinkelmann/flarum-ext-emojionearea/tree/master/locale? Which languages do you know and will be able to update if any change will be needed?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.