clandrew / wdrp Goto Github PK

Side effect of how this project began as a small convenience for myself, but now it's expected to work generally for more people.

The settings file lives, right now, right alongside the plug-in in the Winamp program folder. Depending on where Winamp was installed, say, Winamp was installed to Program Files (common situation) that means it won't have write privileges for that folder.

To fix this, the settings file could live somewhere else where you don't need special permissions to write there. Maybe in your app local folder somewhere.

Hey there,
I want to thank you for this nice plugin, however I do have a suggestion.
Would it be hard for you to implement "time elapsed" display also? From what I checked in the documentation you'd only need to provide a "startTimestamp" to show how much time has passed. Would be a nice little add-on to the plugin.
(Also, you forget to mention in the ReadMe that if you want to have a logo in Discord pop-up you also need to upload image named "winamp-logo" to "Rich Presence -> Art Assets" part of Developer section.)
Thanks.

The plugin has stopped working in Discord

I would like to say that the plugin was working fantastic, thank you very much for all the work you have put into this!

Althrough i manually edited the .ini file adding my Application ID and changed the DiscordRichPresence folder permissions for every user read/write, i still cant get this plugin to work.

Currently running Windows 10 1903 x64, Winamp 5.8 build 3660 with Bento skin.

Can you include the application image you used for your discord application?

As mentioned in the README.md:

Q: How come the status says "Playing a game" instead of "Listening to" like with Spotify?

A: The Discord RPC library doesn't (at the time of writing this) currently expose a way of changing this UI element. The status for Spotify worked because Discord gave Spotify special treatment. If it comes to be that the RPC library adds flexibility of changing this, I'd be interested in adopting it.

Update (6/28/2019): it looks like Discord is distributing a new SDK called GameSDK, and ultimately the RPC SDK will become deprecated. From a quick glance at the docs, it looks like the new SDK supports the ability to customize this. If so, great! I think it is kind of a hassle I need to move the plugin to a new SDK just to get this small feature, but I suppose they are phasing out the RPC SDK anyway. I can take a look at GameSDK and see how easy or hard it is to make it work and start there.

To implement:

https://discordapp.com/developers/docs/game-sdk/sdk-starter-guide#code-primer-unreal-engine-c

And the relevant "Activity" that this plugin must use:

https://discordapp.com/developers/docs/game-sdk/activities

I often listen to streaming radio via Winamp (namely DI.FM). The plugin never picks up the currently playing song, it only will show the URL of the stream it's trying to connect to. One can pause the stream and press play and the plugin will update for the current track, but on song change it does not change unless you pause/unpause again.

Is it possible to add support for streaming audio?

I've uploaded winamp-logo.png to art assets of my Discord Application but am not seeing it pop up in my RPC status. Not sure if its expecting jpg or what. Deleted application and started over and still persists with fresh appID.

Theres no file named gen_DiscordRichPresence.dll in download

The rich presence always shows [Connecting] and then some of the URL, but not the actual song title as shown within WACUP.

Need to test end-to-end Unicode support, make sure non-Latin characters show up properly.

Anscheinend speichert sich die Discord-ID nicht,
sodass bei jedem Neustart von Winamp die ID neu eingegeben werden muss was ziemlich nervig ist.

Need to double check that the Discord connection/RPC is being closed when Winamp is shutting down.

I noticed I closed Winamp today and the status in Discord stuck around.

wa_ipc.h:

#define IPC_ISFULLSTOP 400
/* (requires winamp 2.7+ I think)
** int ret=SendMessage(hwnd_winamp,WM_WA_IPC,0,IPC_ISFULLSTOP);
** This is useful for when you're an output plugin and you want to see if the stop/close
** happening is a full stop or if you are just between tracks. This returns non zero if
** it is a full stop or zero if it is just a new track.
** benski> i think it's actually the other way around - 
**         !0 for EOF and 0 for user pressing stop
*/

From e-mail:

"I was wondering if it's possible to modify the plugin to, instead of looking like this:

App Title
Band - Song
(Playing)
xx:xx elapsed

To change it to look like this:

App Title
Band
Song
xx:xx elapsed"

When I was first getting my feet wet in the Discord platform I thought this was necessary, but it's not really.

Feature Request:

When I have Winamp open but paused, Discord can only see Winamp as my currently used 'presence'. If I start playing Spotify my Discord status does not update until Winamp is closed.

It would be fantastic to have the option of NOT sending presence when the player is paused. Could even have a delay such as 30 seconds since paused?

Acceptance Criteria

• Option to pause presence updates when Winamp is paused
• If Winamp is paused and option is selected, Discord no longer receives updates.
• If WInamp is paused and option is not selected, Discord continues to receive presence updates of (Paused) status.

Hi there,

so I've followed your guide with my ancient Winamp 2.95 and it almost works - it shows in plugins, there's a dialog for entering appid, but when I play a song the player crashes.

I know that it's probably ridiculous to have a support for such version, but perhaps we could at least give a shot at debugging it? Is there some kind of logging? Or can I attach a debugger somehow to see what's going on?

It would be great if the Artist tag and Album tags can be included beneath the Track tag.

Honestly, I find the (Paused)/(Playing) notification to be pointless. If space is an issue, have an option of replacing that with the artist and album. It's more useful information imo.

Also, can you give us an option to make it say the time remaining instead of time elapsed?

Thanks a lot, this is a great plugin and I'm very glad winamp is still getting the love it deserves!

Everything works fine while Winamp is running but does not save the app ID between sessions when installed with latest Winamp v5.9.1 build 10029 that was released 21 Dec 2022

It's only mildly inconvenient I guess but if anyone has a fix, that'd be great.
Can always downgrade to an earlier version of Winamp when it saved the app ID across sessions if needed I suppose.

H

Hello,

I just started on discord to make this [https://github.com/clandrew/wdrp]plugin(url) working again, but its not showing the avatar... what im doing wrong? the wrong is the winamp version, the avatar itself, i really dont understand why its not showing the avatar anymore...

https://media.discordapp.net/attachments/1089198854102073473/1090727306009518161/image.png

Other details:

Version: Winamp 5.666 (i downloaded from a random website, cant remember anymore)
Plugins installed: YES
Application installed: YES

Best regards.

Winamp RPC tends to override any other RPC that is started later than it.
It'd be useful to be able disable and enable the RPC with an easy to access option without having to go into Winamp Preferences

I started using VS 2019 for all my stuff some months ago but haven't yet upgraded this project.
I plan to do this after merging @derekgates 's change- i hope this is not too disruptive?

When Winamp is opened normally, the plug-in behaves normally.

However when Winamp was opened due to opening a file with a Winamp program association, sometimes the plug-in doesn't appear to communicate with Discord. Need to investigate. A guess at what could be happening is some local-working-directory thing is preventing the plug-in from loading the Discord RPC dll, kind of silly.