sinatra-named-routes's People
Forkers
companionstudiosinatra-named-routes's Issues
Rails like link_to tag helper
Support for optional parameters in route patterns
Better error messages
Support same Ruby versions as Sinatra
Helper for printing out routes as javascript functions
Feature that would be cool to have.
Support optional named captures in route patterns
Support optional named parameters in route patterns
The Regexp route parser doesn't handle nested parentheses
The parse_regexp method uses the expression: /\([^\)]*\)/
to find captures in routes defined with a regex - this doesn't handle situations where parentheses are nested (even if they're not captures), raising the error:
RegexpError: end pattern with unmatched parenthesis.
I found this issue with an expression like this:
/foo/(bar\+(?<bar>[^/?#]+)/?|baz\+(?<baz>[^/?#]+)/?)*
Where the outermost parentheses are used to define an 'a or b' style selection, not a capture. Using this expression against the following routes:
/foo/bar+blue/baz+yellow
/foo/baz+yellow/bar+blue
Should match, yielding bar = blue and baz = yellow as named captures. This works for actual routing, but fails when we try to generate a path for this route.
Changing the pattern in route_parser.rb to \([^\(\)]*\)
should fix it.
License missing from gemspec
RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.
via e.g.
spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']
Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.
There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.
I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!
Appendix:
If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies
p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.
Support named captures in route patterns
Add support for sinatra-contrib namespaces
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.