Code Monkey home page Code Monkey logo

ckeditor4-releases's People

Contributors

annatomanek avatar comandeer avatar dumluregn avatar f1ames avatar fredck avatar jacekbogdanski avatar jbaylina avatar mlewand avatar oleq avatar reinmar avatar wwalc avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ckeditor4-releases's Issues

Lost half of the successive spaces

Using Ckeditor 4.4.5

When I input four spaces continuously in the ckeditor and then use the getData() method, what I expect is

"& nbsp;& nbsp;& nbsp;& nbsp;",

but what I got is this

" & nbsp; & nbsp;"

Nuget packages

Hey,

I've been trying to contact the owners of the ckeditor packages on Nuget to update their packages to the latest versions but with no luck.

I've taken it upon myself to add an additional package with the latest versions. I hope that is ok?

If you guys want to take ownership of the packages please say and i'll transfer ownership to you. To make things easier I've got a github repository with all of the nuspec files, batch file etc at https://github.com/mdevilliers/ckeditor-nuget

If you don't want to take ownership I am more than happy to continue putting up the latest version. Maybe if you guys raise an issue at my github I can get it done.
Hopefully that will ensure efficient updates of the latest versions but i'm open to any ideas?

Thanks,

Mark

How to open filemanger in a modal window

Hello,

I'm having big troubles trying to open the filemanger (i'm using elFinder) in a modal window when clicking the "Browse" button.

I've found that code on the web but it seems it's not working for me :

CKEDITOR.on('dialogDefinition', function(event) {
var editor = event.editor;
var dialogDefinition = event.data.definition;
console.log(event.editor);
var dialogName = event.data.name;

var tabCount = dialogDefinition.contents.length;
for (var i = 0; i < tabCount; i++) {
    var browseButton = dialogDefinition.contents[i].get('browse');

    if (browseButton !== null) {
        browseButton.hidden = false;
        browseButton.onClick = function(dialog, i) {
            editor._.filebrowserSe = this;
            jQuery('<div \>').dialog({modal: true, width: "80%", title: "Insert image", zIndex: 99999,
                create: function(event, ui) {
                    jQuery(this).elfinder({
                        resizable: false,
                        url: "/path/to/connector.php",
                        getFileCallback: function(url) {
                            CKEDITOR.tools.callFunction(editor._.filebrowserFn, url);
                            jQuery('a.ui-dialog-titlebar-close[role="button"]').click()
                        }
                    }).elfinder('instance')
                }
            })
        }
    }
}

});

Is there any chance to open the filemanager (whatever it is ckfinder, simogeo filemanager, elfinder..) in a new modal window ?

thanks for your help

Display the page break in editor during text edit

Hello,

I'm looking for a solution that would display the edited text on separate pages (so that there would exist a visual clue for the user indicating that the text belongs to the next page).

I know about the pagebreak plugin, but this one allows the user to explicitly define a page break. As far as I know, it doesn't add the page breaks automatically when there is enough text to fill the whole page.

Does such plugin or solution exist? I couldn't find anything yet.

Thanks,
Marcin

Use semver format for tags

Would it be possible to use semver for the tag names?

Bower isn't compatible with your existing scheme as I understand it.

Bower Package is Empty

While listed on the package manager, the package itself pulls down nothing but the readme.

inline widget downcast error

Hi,

A widget that has the property inline:true throws an error when it's downcast.
Here are the steps to reproduce:

  1. create a simple widget:
CKEDITOR.plugins.add( 'a', {
    requires: 'widget',

    init: function( editor ) {
        editor.widgets.add( 'a', {
            allowedContent: 'div(!qqq);',
            requiredContent: 'div(qqq)',
            inline: true,
            template: '<div class="qqq"></div>',
            upcast: function( element ) {
                return element.name == 'div' && element.hasClass( 'qqq' );
            },
        } );
    }
} );
  1. insert the widget html into the editor so that it's upcast to widget:
<textarea name="asd" id="rich">&lt;div class="qqq">initial text&lt;/div></textarea>
  1. trigger the widget downcast:
editor.getData()

The error is Uncaught TypeError: Cannot read property 'attributes' of null in widget/plugin.js line 2282

Using ckeditor 4.3.3 full + widget downloaded from the online builder page.

adding a tab getting class cke_dialog_tab_disabled

Using Ckeditor 4.4.7, trying in recents browsers.

I am trying to add to the dialog plugin my own tab.

Here is how I did :

var FuncDialogNrImage;
var pluginName = 'imageBrowser';
var dialog;
CKEDITOR.plugins.add('imageBrowser',
    {
        requires: ['iframedialog'],

        init: function(editor)
        {
            dialog = this;

            FuncDialogNrImage = editor._.FuncDialogNrImage = CKEDITOR.tools.addFunction( dialogFunctionImage,  editor );
            CKEDITOR.on( 'dialogDefinition', function( ev )
            {
                // Take the dialog name and its definition from the event
                // data.
                var dialogName = ev.data.name;

                var dialogDefinition = ev.data.definition;
                if (dialogName == "link" || dialogName == "image" )
                {
                    dialogDefinition.minWidth = 800;
                    dialogDefinition.minHeight = 500;
                }

                // Check if the definition is from the dialog we're
                // interested on (the 'Link' dialog).
                if ( dialogName == 'image' || dialogName == 'flash')
                {
                    if(document.location.pathname.indexOf('administrator') > -1)
                    {
                        path = '../';
                    }else
                    {
                        path = '';
                    }
                    dialog = dialogDefinition;
                    // Add a new tab to the 'Link' dialog.
                    dialogDefinition.removeContents('imageBrowserTab');
                    dialogDefinition.addContents({
                        id : 'imageBrowserTab',
                        label : 'Médiathèque',
                        title : 'Médiathèque',
                        elements : [
                            {
                                id : 'imageBrowser',
                                label : 'Médiathèque',
                                type : 'html',
                                html: '<iframe src="/backend.php/Mediatheque/Browser/'+dialogName+'" id="iframeNextgen" allowtransparency="1" style="width:800px;height:490px;margin:0;padding:0;vertical-align: auto;"></iframe>'
                            }
                        ]
                    });
                }
            });
        }
    });

function dialogFunctionImage(string)
{

    var dialogName = dialog.dialog.getName();
    if(string.indexOf("internal://") !== -1)
    {
        dialogName = 'link';
    }


    if (dialogName == 'image')
    {
        dialog.dialog.selectPage('info');
        dialog.dialog.setValueOf('info', 'txtUrl', string);
    }

    if (dialogName == 'link')
    {
        dialog.dialog.selectPage('info');
        dialog.dialog.setValueOf('info', 'url', string);
    }
    if (dialogName == 'flash')
    {
        dialog.dialog.selectPage('info');
        dialog.dialog.setValueOf('info', 'src', string);
    }    
}

It mostly works but the problem I have ius that the tab is unclickable with an added 'cke_dialog_tab_disabled' class.
The wierdest thing is that the content is well generated in the dom.

Bellow is the html generated :

In the dialog

<a class="cke_dialog_tab cke_dialog_tab_disabled" cke_last="" title="Médiathèque" id="cke_imageBrowserTab_173" href="javascript:void(0)" tabindex="-1" hidefocus="true" role="tab" style="-webkit-user-select: none;">Médiathèque</a>

In the content

<div role="tabpanel" id="cke_172_uiElement" class="cke_dialog_ui_vbox cke_dialog_page_contents" style="width: 100%; display: none;" aria-labelledby="cke_imageBrowserTab_173" name="imageBrowserTab" aria-hidden="true">
<iframe src="/backend.php/Mediatheque/Browser/image" id="iframeNextgen" allowtransparency="1" style="width:800px;height:490px;margin:0;padding:0;vertical-align: auto;" class="cke_dialog_ui_html"></iframe>

Datalist

Is it possible to add datalist

support?

Possible issue with build system; non-printable chars in strings

Unfortunately I haven't had much time to look into it, but it seems that the \u200B string in core/selection.js gets corrupted during the build / minifying process:
https://github.com/ckeditor/ckeditor-dev/blob/master/core/selection.js#L123

var fillingChar = element.getDocument().createText( '\u200B' );

Compare this to the current release version where this line becomes

i=l.getDocument().createText("​")

I stumbled upon this when debugging a strange issue on Google Chrome with question marks being inserted into the editor field every time I changed the text formatting (without active selection) or pressed Shift + Enter to insert a linebreak. In my downloaded version of ckeditor.js, this line looked like this:

i=o.getDocument().createText("?");

Sure enough, replacing the question mark by "\u200B" did the trick for me.

There seem to be a few bug reports mentioning this issue [1], but apparently no one was able to identify the problem conclusively. So I hope this helps.

[1] e.g. http://ckeditor.com/forums/Support/Question-Mark-after-pressing-button-toolbar

Ckeditor remove my php, html code

Hello,

sorry for my pure English. I use latest version Ckeditor and want to use code snippet plugin. When i use code snippet and insert my html code that code show for 1 sec on ckeditor end than disapear. Same problem is with php code. I try code snippet on your official web site and work.

Did you now what is problem?

Using relative url for CKEDITOR_BASEPATH

If I'm using a relative url like

CKEDITOR_BASEPATH  = "//mydomain.com/ckeditor";

for CKEDITOR_BASEPATH variable, then CKEDITOR tries to load

 http://mydomain.com//mydomain.com/ckeditor/config.js?t=DBAA

(which obviously is wrong) instead of

 //mydomain.com/ckeditor/config.js?t=DBAA

This issue comes from https://github.com/ckeditor/ckeditor-dev/blob/master/core/ckeditor_base.js#L178 which should be

if ( resource.indexOf( ':/' ) == -1 && resource.substr(0, 2) != '//' &&  resource.indexOf( '/' ) !== 0 )

There is this ticket about this issue : http://dev.ckeditor.com/ticket/10068 but it hasn't changed in 10 months

config "on" not working in external customConfig.

When using a customconfig:

 CKEDITOR.replace('text', {
    customConfig: "/assets/js/ckeditor_config.js"
});

And adding events via :

  config.on = {
    instanceReady: function() {
            alert( this.name );
        }
      };
    //...

That code is never executed. However, add the same code to the replace method and it will work;

  CKEDITOR.replace('text', {
    customConfig: "/assets/js/ckeditor_config.js",
      on: {
        instanceReady: function() {
            alert( this.name );
        }
      }
  });

License type on npm

It would be easier to identify the license programmatically if you changed the package.json from "See license..." to
"(GPL-2.0 OR LGPL-2.1 OR MPL-1.1)"

Space at the end of content not inserted in Internet Explorer 11

I noticed inconsistance When inserting space caracter at the end of the ckeditor content .
In chrome the source shows (typed : test + space) :

<p>test&nbsp;</p> 

In Internet explorer we get :

<p>test</p>

So , Chrome behaviour is OK Not the case in Internet Explorer . Any explanation ?

Installation of full package via bower install --save does not work properly

When you follow the instructions in the docs and run

bower install ckeditor#full/4.3.3 --save

The bower.json file is updated as follows

  "dependencies": {
    "ckeditor": "full/4.3.x"
  }

This is incorrect and will not work with bower install in the future. The correct code for bower.json seems to be (notice the # symbol in front of full)

  "dependencies": {
    "ckeditor": "#full/4.3.x"
  }

I dont know if this is a bower bug or an issue with the way the ckeditor tags are in this repo.

Kama skin missing?

Why does full/4.5.3 branch include only moono skin without the kama skin, while standard/4.5.3 does include both skins?

Separate readme file for npm

Since README.md contains information about tags, branches, installation from github and other stuff, we decide to prepare simpler version for npm so the package page will contain information related only to npm.

It can be done via readme field added to package.json which is not the best solution. Adding and maintaining markdown (or simply, long formatted text) as a field in package.json is quite messy and decreases package.json readability.

The other solution could be adding separate file, e.g. README.npm.md (not sure how it should be named) and integrate it in tools/scripts which are used for npm publishing so it will be seamless for us. Integrate in this case means renaming README.npm.md to README.md for a duration of publishing process so npm will pack the file we want. Sounds little hacky, but it is rather simple solution and makes the README.npm.md file more maintainable. The only danger is that publishing package manually (not via script) will use default README.md so the person should be aware of the fact that we use such procedure for npm.

Imho, we could use second solution for this.

Provide compiled but non-minimized resources (JS/CSS)

Hey guys,

you are doing great job with providing CKEditor as Bower package.

One thing that I would appreciate is having access to compiled (released) version of CKEditor 4 but without doing minification/uglification/obfuscation.

I'm not sure whether it is achieavable in current CKEditor build system,

but the problem with obfuscated resources is that they can't be easily debugged (when source maps aren't provided)

On the other hand, you can't simply switch released repo (ckeditor bower dependency) to dev repo (ckeditor-dev bower dependency) to debug.

Do you consider it a valid issue?

Should I report this issue to CKEditor issue tracker?

editor.on('change') is not fired after pasting from clipboard for the first two input symbols

Hi, guys! I registered on your official issue tracker but email verification letter is not coming, I tried to send it three times and waited for 30 minutes and it didn't work. So I put the issue here.

After pasting from clipboard something goes wrong and next two input chars do not cause emitting of 'change' event. It can be reproduced on your official demo page. From the third symbol all works properly. Could you please check that? Thanks :)

Can't install alternate distribution releases with composer

Following the docs at http://ckeditor.com/blog/CKEditor-Supports-Bower-and-Composer, I tried the following code:

"require": {
    "ckeditor/ckeditor": "full/4.3.3",
}

Unfortunately composer fails with the following message:

[UnexpectedValueException]                                                            
Could not parse version constraint full/4.3.3: Invalid version string "full/4.3.3"  

On the other hand branches seem to work OK. Unfortunately, I work with a very picky project manager that wants all dependencies to be pinned versions.

Is there any workarounds?

Add samples to Bower ignore

I think several files including documentation/project info (README.md and CHANGES.md) and examples (samples/ directory) could be ignored when loading CKEditor by using Bower.

Currently, the standard package contains 325 files, while 16% of them are examples and Markdown files.

cache-busting build number missing from editor.css urls

Rules for putting the right background image on toolbar buttons appear both inline on each button's span element and are also defined in the skin's editor.css. The url in the former is an absolute path with the build number in the query string, but the latter is a relative url with no build number, and the latter is the one with higher precedence of a !important attribute. This allows an older version of the icons image to be used in the browser, such that the buttons show the wrong images.

nuget package

please don't just stuff everything from the repo into the nuget package. I really don't need the bower, and readme files, etc.

A way of including extra themes in bower

It would be really great if you could pull in extra themes using bower, without having to edit any stuff manually.

(or am I just ignorant and it can already be done?)

I was using the Bootstrap theme and then switched to Bower, but I found that Bootstrap was no longer included.

Not working for mobile

This is environment for my android

CKEDITOR.env

{
   "ie":false,
   "opera":false,
   "webkit":true,
   "air":false,
   "mac":false,
   "quirks":false,
   "mobile":true,
   "iOS":false,
   "secure":false,
   "gecko":false,
   "chrome":true,
   "version":537,
   "isCompatible":false,
   "hidpi":true,
   "needsBrFiller":true,
   "needsNbspFiller":false,
   "cssClass":"cke_browser_webkit cke_hidpi",
   "hc":false
}

Seem like CKEDITOR.replace(elem[0]) was returning null

I tried to change CKEDITOR.env.isCompatible = true manually. It fixed the return null problem, but the editor still not been displayed.

CKEditor in jade not working

I included CKEditor in MYAPP as mentioned in it's documentation guide. The referenced file-path is OK. The div id is called correctly, but still it is not working.
I checked CKEditor (the same downloaded version) on an HTML sampleApp, there it is OK to work.

2 snaps of the code-section are attached.

snapp2
snap

Issue with ReCaptcha

Hope this is where I go to report bugs, I noticed when I try to edit something that recaptcha code, it will cause the captcha to get executed and then cause that code to get stripped out when you attempt to save the changes.

[enhancement] Add missing bower.json.

Hey, maintainer(s) of ckeditor/ckeditor-releases!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library ckeditor/ckeditor-releases is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "ckeditor/ckeditor-releases",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo,
twitter: @versioneye
email: [email protected]
VersionEye - no more legacy software!

Subdomain fails loading plugins

eg. I have two blog sites domain.com/ and name.domain.com.

In both sites I have the same Blog software containing the ckeditor lib in web-root/lib.

Site 1 works and loads well, including my personal plugins, which are in libs/ckeditor/plugins/myplugin and are configured through a custom config. The Plugin failing in special does not hook into toolbar, so it is just added to the extraPlugins config.

I get an error for the subdomain site:
uncaught exception: [CKEDITOR.resourceManager.load] Resource name "myplugin" was not found at http://name.domain.com/lib/ckeditor/plugins/myplugin/plugin.js

I can access domain.com/lib/ckeditor/plugins/myplugin/plugin.js in browser, but not name.domain.com/lib/ckeditor/plugins/myplugin/plugin.js. Directory structure is /var/wwww/site1/html for the first and and /var/wwww/site1/html/name for the second. Second is a htaccess restricted site.

I checked this on both 4.4.6 and 4.4.7 full releases.

Do you have any ideas on this, being a bug in CKE?

Compatibility with laravel. Add autoload.php file

https://packagist.org/packages/ckeditor/ckeditor
I used this for installing ckeditor to my laravel project
When I install the package through composer, it copies the files or all assets(js, css) to the vendor folder (which contains all the dependencies).
But thats not enough, we cannot use the assets from the vendor folder directly. We need to copy it to the public folder.
So, I recommend you to provide a autoload.php file that will automatically copy these files to the public folder, from where we can use it to create views.
Without this, the package is useless and we have no other choice other than manually copying the files to the public folder.

What about adding composer support

Hi, would be great if you add composer support so we can install ckeditor as a dependency.

Twitter bootstrap is doing that.

If you agree I can make a PR for you and you will just have to register this on packagist.

What do you think about this idea ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.