cisco-open / go-lanai Goto Github PK

Authored by xinzlu
Jan 11, 2023

see https://cto-github.cisco.com/NFV-BU/go-lanai/pull/273

Description

Errors returned by some httpclient methods, e.g. WithBaseUrl contain strings with the raw, uninterpolated %v verb. It appears that ErrMsg is being set with a string is never actually formatted - the string format specified here is not processed as intended:

Expected Behavior

String representation of error should not contain %v

Actual Behavior

E.g. when calling WithBaseUrl with an empty string, the error string is cannot create client with base URL: %v

Affected Version

v0.13.1-0.20240330193930-c61e79fc6004

Steps to Reproduce

Call WithBaseUrl using an empty string. Other methods like WithService may be impacted similarly.

Checklist

• I have read the contributing guidelines
• I have verified this does not duplicate an existing issue

Problem Statement

When used as OAuth2 authorization/authentication server, if client doesn't have auto-approved scopes configured, the user is asked to approve the requested scope every time when client initiate the "authorize" process. The decision is not saved even in the same session.

Proposed Solution

User's approval decision should be cached in session.

Alternatives Considered

Currently the only alternative is to configure "auto-approval" for the client, which might not be desirable for certain use cases

Additional Context

Relavent implementation is in pkg/security/oauth2/auth/authorize/middleware.go

Description

Please provide a description of the problem.

Expected Behavior

Please describe what you expected would happen.

Actual Behavior

Please describe what happened instead.

Affected Version

Please provide the version number where this issue was encountered.

Steps to Reproduce

1. First step
2. Second step
3. etc.

Checklist

• I have read the contributing guidelines
• I have verified this does not duplicate an existing issue