circlefin / circle-nodejs-sdk Goto Github PK

Is there any reason why we need 2 API calls to get the addresses of a wallet? Why can't the getWallet operation response come with an array of Addresses included?

ignore

The network enum Chain needs to be extended to support Arbitrum network

I was talking with a developer in the Build on Circle community, and we found a bug in the API type definitions.

GetPaymentResponseData is defined as never because of conflicting type attributes in a type intersection. Since these types are autogenerated by OpenAPI, it looks like it's probably an error in definitions.

CryptoPayment is defined as:

export interface CryptoPayment {
// …
    type: CryptoPaymentTypeEnum; // "payment" | "refund"
// …

And GetPaymentReponseData is defined as an intersection with a specific type that conflicts with that union:

export type GetPaymentResponseData =
  | ({ type: "Crypto Payment" } & CryptoPayment)
  | ({ type: "Fiat Payment" } & FiatPaymentPolymorphic);

This resolves to never because "Crypto Payment" & ("payment" | "refund") cannot be reconciled, which (downstream) results in GetPaymentResponse resolving to { data: undefined } in all cases.

Hello - can you please advice where I can find SDK doc? Is it available online or need to use the yarn gen-sdk <sdk-version> ? If the later, we were able to execute it but not sure how to access/view the generated doc - please kindly advice.

Thank you for creating this node library, super helpful to access to the Circle APIs.

Regards,
Right

Will merchants functionality be included in the SDK?