chriswayg / ansible-msmtp-mailer Goto Github PK

@chriswayg Thanks for getting those PRs in, notably #5. Would you kindly do an import on Galaxy to update the code there?

Last Commit: 2 years ago
Last Import: 2 years ago

I'm trying to unfork now that PRs have been merged and use your role directly from Galaxy, without having to submodule the repo. Thanks!

Optional values msmtp_alias_root and msmtp_alias_cron are overridden by the default values from file defaults/main.yml

New Debian version 11 (bulseyes) includes a msmtp upgrade to version 1.8.11 (Debian 10 buster has 1.8.3 by default).

This new version (since 1.8.8) allows to replace From: header with set_from_header on parameter.

Could you please include this parameter in config?

Many thanks

I pin all of my ansible deps to a specific version and I'd like to do the same here. Any chance you could push a tag?

I believe in the test mail, echo -e should be used for the newlines to be parsed properly.

Also, the test fail failed to go out through SES because it objected to the mail to root.

I guess that failed because I have msmtp_alias_root set up, so the mail is attempted to be forwarded through the smtp server, but the email address was left as only root, I'm not sure which component is at fault there, but I would just remove root as one of the test addresses, since msmtp is all about sending remote mail.

Some Linux utilities will send mail from a local address with no @ sign, like "cron" , to a local email address like "root" (again, no "@" sign or domain).

While msmtp has features to alter the envelope sender and recipient, it doesn't alter the "To:" or "From:" message itself.

When the Envelope doesn't match these details, it can be considered spam. AWS SES is an example of an SMTP service that won't accept mail addressed to "root", even if the Envelope recipient is valid. But sending out cron mails is exactly the kind of thing that msmtp should be good for!

One issue about this in the msmtp bug tracker is here:
marlam/msmtp#98

So I propose that the Ansible role introduce a small feature to address, since the msmtp maintainer considers it out of scope.

I successfully tested the solution of adding my own sendmail wrapper. In my case, I hard-coded an email address to use, but a proper solution could use a template variable and a variable for this:

#!/usr/bin/sh
# If either the "From" or "To" contain a bare local address like just "root"
# Then rewrite that to be [email protected]
# This feature is missing from msmtp.
# Ref: https://github.com/marlam/msmtp-mirror/issues/98
sed -e '/From:[^@]*$/ s/From:.*$/From: [email protected]/;/To:[^@]*$/ s/To:.*$/To: [email protected]/;' | /usr/bin/msmtp $@

Then in Ansible:

- name: Install mstmp wrapper to fix local addresses
  tags: mail
  ansible.builtin.copy:
    src: usr/local/sbin/sendmail
    dest: /usr/local/sbin/sendmail
    # Must be setuid
    mode: "u+rwx,g=sr,o=x"
    group: msmtp

I tested this with the mail app (mailx) on Ubuntu 22. It relies on clients looking up sendmail in $PATH. If some place has hardcoded the path to /usr/sbin/sendmail, my fix wouldn't cover that since I don't replace that file.