christianwgd / django-bootstrap-icons Goto Github PK

In the bootstrap_icons.py file, it uses os.path.join in both bs_icon and md_icon, but it's building a URL where we should always have forward slashes, never backwards slashes as you'll end up with if you're running the code on Windows.

As I loaded more icons in my template file on my django project, the site slowed down considerable. Even when I included just 5 icons there was a noticeable difference in site load times. I'm not sure why this is currently but it's a huge downside to using icons in django templates this way.

Tried to use this module with the latest version, 0.8.7, followed the instruction on the pypy page(https://pypi.org/project/django-bootstrap-icons/):

• Installed with pip
• Added the django_bootstrap_icons in INSTALLED_APPS
• Added {% load bootstrap_icons %} in the template base used for every template
• Tried {% bs_icon 'alarm' %} in the homepage

Recived this error:
Invalid block tag on line 9: 'bs_icon', expected 'endblock'. Did you forget to register or load this tag?

At some point Bootstrap Icons seems to have changed the default vertical alignment of the icons. I'll have to take a closer look.

A reliable workaround is to set an explicit alignment with the extra_classes argument or override the global default in CSS.

I noticed performance issues, if i have a long list of objects in a template, that use the same icon. Each icon is completely new rendered.

To avoid this, build some sort of cache, so that icons are only rendered once and simply loaded for each subsequent use.

A width of "1.5rem" seems to work in most browsers but creates errors in the console. Change to "em".