christianhbye / lusee_sky_simulations Goto Github PK

lots of new code recently, no new tests ...

parse_fits has a function (mk_linspace) that wraps numpy.linspace and causes mypy to complain due to more restrictive typing than the native numpy function. The dirty fix is to ignore typing for this function, but this is not a long-term solution.

Example (mypy throws error)

import numpy as np
def mk_linspace(start: float, stop: float, step: float) -> np.ndarray:
    num = (stop-start)//step + 1
    return np.linspace(start, stop, num)

Current fix:

def mk_linspace(start,: float stop: float, step: float):  -> np.ndarray # type: ignore

These files are quite ugly and made in a rush. Fix them

make_pygdsm.py
run_sim.py

add init, setup.py and some documentation

The scripts in utils/csv_beams are not being type checked at the moment since they're not in use. Would be good to fix some time...

in general, check its utility and whether it might as well be replaced by the script provided by uvsim. The main problem with uvsim is that it doesn't discard the imaginary part.

as of commit 95ccad1

works for python3.8 and python3.9 though

move the ULSA stuff to its own file, add to readme (describe different files and the overall goal etc)